IRC logs for #openttd.dev on OFTC at 2017-01-22
#openttd.dev / 2017 / 01 
            

01:58:42  *** welshdragon has joined #openttd.dev



02:19:55  *** welshdragon has quit IRC



07:48:33  *** Supercheese has left #openttd.dev



07:48:37  *** adf88 has joined #openttd.dev



07:48:37  *** ChanServ sets mode: +v adf88



08:29:31  *** adf88 has quit IRC



08:44:04  *** adf88 has joined #openttd.dev



08:44:04  *** ChanServ sets mode: +v adf88



12:34:47  *** frosch123 has joined #openttd.dev



12:34:47  *** ChanServ sets mode: +v frosch123



12:53:38  <adf88> there are few lines of dead code in town_cmd.cpp



12:53:53  <adf88> they can be removed



12:53:54  <adf88> http://pastebin.com/X4ZcmAGj



12:54:15  <adf88> since "DoCommand(tile, 0, 0, DC_AUTO | DC_NO_WATER, CMD_LANDSCAPE_CLEAR)"



12:54:37  <adf88> will make sure that the tile is empty (the DC_AUTO flag)



12:55:39  <adf88> (see ClearTile_Town: http://hg.openttd.org/trunk.hg/file/e9f2d6e79dfb/src/town_cmd.cpp#l551)



13:04:51  <adf88> after removing the lines, the code can be further simplified:



13:08:51  <adf88> (all in one): http://pastebin.com/xm4rRc08



13:27:29  <adf88> I didn't bring it before because I wasn't sure



13:28:07  <adf88> but after spending some time with town_cmd.cpp now I'm sure ;)



13:29:28  *** aard has joined #openttd.dev



13:50:58  <frosch123> @commit 12162



13:50:58  <DorpsGek> frosch123: Commit by smatz :: r12162 trunk/src/town_cmd.cpp (2008-02-16 18:54:29 +0100 )



13:50:59  <DorpsGek> frosch123: -Fix [FS#1757]: towns shouldn't build over houses owned by another town



13:51:04  <frosch123> funny, isn't it :)



13:59:24  <adf88> ClearTile_Town changed too



13:59:39  <frosch123> the DC_AUTO was already present back then



14:07:40  <adf88> it seems that problem was fixed some revisions before



14:07:50  <adf88> and the "fix" didn't fix anything



14:13:16  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r27739 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"



14:38:07  *** welshdragon has joined #openttd.dev



14:46:30  *** welshdragon has quit IRC



14:47:48  *** welshdragon has joined #openttd.dev



14:52:00  *** welshdragon has quit IRC



14:52:46  *** welshdragon has joined #openttd.dev



15:00:50  *** welshdragon has quit IRC



15:09:50  *** welshdragon has joined #openttd.dev



15:58:06  *** adf88 has quit IRC



16:35:12  *** aard has quit IRC



16:39:50  *** welshdragon has quit IRC



16:40:11  *** welshdragon has joined #openttd.dev



16:51:59  *** aard has joined #openttd.dev



17:06:50  *** welshdragon has quit IRC



17:10:32  *** aard has quit IRC



17:52:26  *** frosch has joined #openttd.dev



17:57:05  *** frosch123 has quit IRC



18:20:10  *** welshdragon has joined #openttd.dev



19:38:25  *** welshdragon has quit IRC



20:56:27  *** Supercheese has joined #openttd.dev



20:56:27  *** ChanServ sets mode: +v Supercheese



21:23:02  *** welshdragon has joined #openttd.dev



21:30:27  *** frosch has quit IRC



21:55:50  *** welshdragon has quit IRC



21:55:50  *** sim642 has quit IRC



21:56:53  *** welshdragon has joined #openttd.dev



21:59:38  *** welshdragon has quit IRC



22:00:28  *** welshdragon has joined #openttd.dev