IRC logs for #openttd.dev on OFTC at 2016-07-22
⏴ go to previous day
04:23:40 *** Klanticus has joined #openttd.dev
11:31:22 *** JacobD88 has joined #openttd.dev
14:53:59 *** JacobD88 has joined #openttd.dev
16:22:51 *** Klanticus_ has joined #openttd.dev
16:45:02 *** Klanticus has joined #openttd.dev
19:39:28 *** adf88 has joined #openttd.dev
19:39:28 *** ChanServ sets mode: +v adf88
20:31:52 <adf88> Some time ago we talked with Alberth about an issue with industries on the smallmap.
20:31:52 <adf88> The problem occurs when industries overlap each other.
20:31:52 <adf88> When you hide some industries, other industries "beneath" them won't show up, the spot will just become "clear".
20:31:52 <adf88> Zooming out, many industries, small industries, all these factors make things worse.
20:31:52 <adf88> It can be a real pain when using FIRS.
20:31:53 <adf88> It also makes sense to give highest priority to industries while in smallmap "Industries" view.
20:31:53 <adf88> Roads, railroads and stations may overlap them and this is undesirable, I think.
20:31:55 <adf88> Recently I wrote a patch for the two above, they nicely combine into something simpler so I decided to make one, common patch.
20:35:17 <adf88> oil rigs are also a good exaple
20:35:34 *** frosch123 has joined #openttd.dev
20:35:34 *** ChanServ sets mode: +v frosch123
20:36:01 <adf88> should the station hide the industry when zoomed out?
20:40:27 <adf88> small industries inside towns like banks "disappear" too when zooming out
20:41:23 <frosch123> isn't that what _tiletype_importance is about?
20:43:03 <frosch123> hmm, so road is more important than industries currently :p
20:43:18 <frosch123> i guess that is fine for player-owned road, but meh for town-owned roads
20:45:48 <adf88> yes, it's _tiletype_importance responsible currently
20:46:24 <frosch123> i always use the industry map view, never any of the other ones
20:46:40 <frosch123> so, i kind of have no idea whether it needs different priorities for different map types
20:47:19 <frosch123> but yes, industries seem to be the most important
20:47:46 <frosch123> since single tiles matter, while they do not really for other types
20:48:16 *** Milek7 has left #openttd.dev
20:48:23 *** milek7 has joined #openttd.dev
20:48:43 <adf88> industries should not become globally most important
20:50:26 <adf88> when you are in "routes" view, you want to see routes right? :)
20:52:38 <frosch123> yes, but routes are generally small and next to each other, so they hide each other
20:52:56 <adf88> routes was just an example
20:53:02 <adf88> anyway, giving highest priority doesn't solve the first problem
20:53:13 <frosch123> ultimately the ownership view will always fail when zoomed out :)
20:53:14 <adf88> one industries hiding other
20:53:43 <frosch123> i think there is no point in changing the other map modes, or at least i wouldn't know what to change
20:53:48 <frosch123> so, just changing industry view is fine
20:54:23 *** Klanticus_ has joined #openttd.dev
20:57:21 <frosch123> i wonder whether to remove GetEffectiveTileType and inline it
20:57:27 <frosch123> it is only called once
20:57:39 <frosch123> and what it does is not much different to the new stuff you added
20:58:06 <frosch123> (and it does not make sense to add the new stuff to GetEffectiveTileType)
21:03:47 <adf88> frosch123: before, I tried to put everything into GetEffectiveTileType
21:04:16 <adf88> perhaps doing the opposite is the way to go
21:35:48 <frosch123> will commit later :)
21:50:32 *** sgtbigman has joined #openttd.dev
23:32:25 *** ChanServ sets mode: +o DorpsGek
23:51:11 *** sgtbigman has joined #openttd.dev
continue to next day ⏵