IRC logs for #openttd.dev on OFTC at 2014-09-18
⏴ go to previous day
00:08:31 *** Supercheese has joined #openttd.dev
07:57:56 *** nickolai has joined #openttd.dev
15:38:25 *** Alberth has joined #openttd.dev
15:38:25 *** ChanServ sets mode: +v Alberth
16:48:06 *** frosch123 has joined #openttd.dev
16:48:06 *** ChanServ sets mode: +v frosch123
17:36:53 <Alberth> getting cargo stuck at some point is not the solution, this seems nicer to me
17:54:03 <fonsinchen> This changes the behaviour of improved loading slightly
17:54:45 <fonsinchen> Vehicles without refit orders can "steal" cargo from vehicles with refit orders like this. But as we don't know if or when the refit will succeed we better do it like this.
17:56:24 <fonsinchen> Oh, actually we should also check for improved loading in the HandleRefit parameter ...
17:57:28 <frosch123> the abort_on_false is not checked between the two parts of dual headed engines, intended?
17:58:59 <frosch123> if the default parameter is supposed to result in the old behaviour, it needs to be true instead of false, intented?
17:59:40 <fonsinchen> 1, not intended 2, intended
18:00:15 <fonsinchen> Having it default to false is nicer for readability and all the other actions always return true anyway
18:08:20 <fonsinchen> Now the next interesting thing is getting CT_AUTO_REFIT into the link prediction
19:02:18 <Alberth> The src/engine_gui.cpp change is unrelated, and a code change
19:03:47 <Alberth> people seem to confuse parts with cargoes, which I somewhat exploited to reduce the max number of entries :p
19:04:44 <Alberth> not sure I like the gold "(refittable)", shouldn't that be black?
19:11:09 <frosch123> how were capacities of 0 displayed before?
19:12:41 <Alberth> if (cap[c] == 0) continue; <-- didn't change line 62
19:15:07 <Alberth> if (new_y == y) { <-- maybe line 835 of build_vehicle_gui.cpp handles that?
19:17:50 <frosch123> *refits |= 1 << cargo_type; <- SetBit imho
19:19:21 <frosch123> looks fine otherwise
19:19:24 <Alberth> I somewhat prefer the explicit bit operations, but np, I'll change it
19:19:25 <frosch123> until the next grf breaks it :p
19:20:12 <frosch123> * The refits are linked to a cargo rather than an articulated part to prevent an long list of parts. <- s/an/a/
19:20:44 <frosch123> * @param cargoes [out] Total amount of units that can be transported, summed by cargo. <- doesn't the [out] need to be between @param and param name?
19:21:19 <Alberth> I thought not, but can test that
19:21:24 <frosch123> oi, there are various places in ottd which do it either way :p
19:21:32 <frosch123> which one does doxygen expect? :p
19:21:49 <Alberth> my output of doxygen doesn't have cargo_type.h for some reason
19:22:57 <Alberth> I thought the one after the name, but can test
19:24:31 * Alberth thought wrong, apparently :)
19:24:37 <frosch123> oi, didn't know abuot being able to doc multiple parameters at once
19:27:55 <frosch123> not a big difference actually :p
19:29:39 <Alberth> in the latter case, the [out] is probably part of the description
19:37:27 <frosch123> i think black would look weird
19:37:39 <frosch123> and using a third colour would only fit with nuts :)
19:38:12 <Alberth> yeah, a third colour would be really bad :)
19:39:53 <fonsinchen> We should definitely be careful with adding more weirdness to that part of the newgrf spec
19:40:12 <fonsinchen> Refit to passengers and then half the vehicle carries mail?? wtf?
19:41:20 <Alberth> btw hover timeout is too short
19:42:55 <Alberth> mail is very undervalued as cargo, everybody just transports passengers
19:54:47 *** Alberth has left #openttd.dev
continue to next day ⏵
