IRC logs for #openttd.dev on OFTC at 2014-06-21
#openttd.dev / 2014 / 06 
            

00:30:25  *** frosch123 has quit IRC



06:11:19  *** Zuu has joined #openttd.dev



06:11:19  *** ChanServ sets mode: +v Zuu



06:41:39  *** Supercheese has quit IRC



07:03:28  *** Zuu has quit IRC



09:54:28  *** Alberth has joined #openttd.dev



09:54:28  *** ChanServ sets mode: +v Alberth



09:58:50  *** frosch123 has joined #openttd.dev



09:58:50  *** ChanServ sets mode: +v frosch123



12:42:38  <frosch123> Rubidium: what does r26651 do exactly?



12:42:52  <frosch123> i thought it was about OverflowSafeInt



12:43:00  <frosch123> but i do not see min/max being used there



12:43:35  <frosch123> otherwise backporting that revision would just mean adding the math_func include to overflowsafe_type



12:43:54  <Rubidium> it's about abs



12:44:23  <Rubidium> and not using the abs from that file, but some other one from the C headers or so



12:44:35  <Rubidium> the latter is int which will truncate on long long int



12:44:39  <frosch123> ah, right, abs, not min/max



12:45:01  <frosch123> so, is adding math_func.hpp to overflowsafe_type.hpp good enough?



12:54:37  <Rubidium> yup



12:55:03  <Rubidium> I at least don't know any other uses of abs without including math_func.hpp



17:45:13  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26659 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"



18:24:19  <fonsinchen> https://github.com/ulfhermann/openttd/commit/63392e1d83d4d93bf461b761fa3387e5ea7dbf94 fixes a silly typo



18:49:05  <Alberth> quite :)



18:49:36  <planetmaker> he :)



19:52:53  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26660 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"



19:55:11  <fonsinchen> https://github.com/ulfhermann/openttd/blob/4ec9fd9a7344771f227f102feb3411bca7587ebd/src/script/api/script_stationlist.hpp < nicer API for ScriptStationList_Cargo; comments welcome



20:02:39  <frosch123> looks fine to me



22:24:47  *** frosch123 has quit IRC



22:28:46  *** Alberth has left #openttd.dev