⏴ go to previous day
07:49:10  *** Supercheese has quit IRC

07:54:25  *** Alberth has joined #openttd.dev

07:54:25  *** ChanServ sets mode: +v Alberth

08:45:55  *** frosch123 has joined #openttd.dev

08:45:55  *** ChanServ sets mode: +v frosch123

08:54:47  *** Godde has joined #openttd.dev

08:56:06  *** Godde has quit IRC

09:57:34  *** Godde has joined #openttd.dev

10:06:03  *** Godde has quit IRC

10:11:19  *** Godde has joined #openttd.dev

12:46:28  <Rubidium> frosch123: I wouldn't introduce STRINGx because STRINGn becomes STRING in the translations and there the 'x' is not known to the user, so the user might simply move it to another location in the translation and then failure at a much later state again

12:47:03  <Rubidium> frosch123: STRING0 -> STRING is a fairly simple change in the string backport thingy ;)

12:48:32  <Rubidium> for that STR_JUST_STRINGN case, you could use STRING7 as placeholder

12:48:51  <Rubidium> instead of STRINGx

12:49:33  <frosch123> i don't get what you mean with STRINGx and the moving of it?

12:49:43  <frosch123> it only has to be at the end for the base language

12:51:47  <Rubidium> hmm...

12:52:30  <frosch123> it's basically when the string does not include another string, but rather prefixes it or something

12:52:49  <Rubidium> where would STRINGx be used in openttd itself?

12:53:20  <frosch123> mostly when we put STR_JUST_STRING in a widget and then fill the actual stuff via the string params

12:53:23  <frosch123> like query window caption

12:53:37  <frosch123> or error messages

12:53:42  <frosch123> script messages and such

12:54:01  <frosch123> "Message from script: {STRINGx}"

12:54:07  <frosch123> it's more like a concatenation than an inclusion

12:54:37  <Rubidium> then why not use STRING7? That can be used for better bound checks and the likes

12:55:12  <frosch123> well, for now it would be enough

12:55:20  <frosch123> we have no more than 2 parameters to a query gui

12:55:31  <frosch123> and the script messages (which supply up to 20 params) are drawn directly only

12:55:55  <Rubidium> joy

12:56:18  <Rubidium> so STRINGx is more a synonym for STRING20

12:56:35  <frosch123> yeah :p

12:56:50  <Rubidium> so STRINGXX ;)

13:02:34  <frosch123> do you remember the reason why we added so many STR_COLOUR_STRING in the past, instead of passing the colour to DrawString?

13:02:44  <frosch123> was it only due to widgets and stuff without colour parameter?

13:07:02  <Rubidium> nope

13:07:22  <Rubidium> I'd reckon for substrings that needed to be a particular color depending on some setting

13:10:31  <Rubidium> seems like Maedhros misunderstanding DrawString when he made the timetable stuff?

13:11:42  <frosch123> yeah, i simplified that code

13:12:06  <frosch123> a bit weird to mix STR_COLOUR with passing an explicit colour and letting them override each other :p

14:03:37  *** DorpsGek has joined #openttd.dev

14:03:37  *** ChanServ sets mode: +v DorpsGek

14:04:17  *** TrueBrain has joined #openttd.dev

14:04:29  *** TrueBrain has left #openttd.dev

17:23:53  <Rubidium> http://rbijker.net/openttd/fs6038.diff couldn't quickly find more bad spots

17:49:35  <frosch123> @services op

17:49:47  *** frosch123 has quit IRC

17:50:02  *** frosch123 has joined #openttd.dev

17:50:02  *** ChanServ sets mode: +v frosch123

17:50:04  <frosch123> @services op

17:50:04  *** ChanServ sets mode: +o DorpsGek

18:47:58  *** Alberth has left #openttd.dev

21:02:48  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26636 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"

21:02:52  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26637 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"

21:02:55  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26638 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"

21:45:41  *** frosch123 has quit IRC

23:48:42  *** Supercheese has joined #openttd.dev

23:48:42  *** ChanServ sets mode: +v Supercheese

continue to next day ⏵