⏴ go to previous day
11:32:04  *** Supercheese has quit IRC

11:32:37  *** Supercheese has joined #openttd.dev

11:32:37  *** ChanServ sets mode: +v Supercheese

15:12:41  *** Alberth has joined #openttd.dev

15:12:41  *** ChanServ sets mode: +v Alberth

17:15:39  *** frosch123 has joined #openttd.dev

17:15:39  *** ChanServ sets mode: +v frosch123

17:45:03  <Alberth> http://paste.openttdcoop.org/show/3339/    wip, but will this work? ie copy an already existing newgrfconfig rather than refinding it?

17:45:10  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26601 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"

18:32:25  <frosch123> do you check for duplicates multiple times?

18:32:39  <frosch123> there is somethnig around line 1470 and 1530

18:34:29  <Alberth> the latter is for the case !has_grfid, ie the assignment at line 1494

18:35:05  <frosch123> well, but why don't you just add all grfs, and then check for duplciates at the end?

18:35:35  <frosch123> anyway, GRFConfig copy constructor looks fine

18:37:28  <frosch123> also gotos :p

18:38:02  <Alberth> I am worried about 1510 the FillGrfDetails, it loads the grf file, instead of relying on already present data

18:41:09  <frosch123> hmm, looks funny

18:41:27  <frosch123> but only makes a difference if that part of the config is loaded before grfscan

18:42:28  <frosch123> but it is called for the !minimal case in LoadFromConfig, thus after the scan

18:42:50  <Alberth> ok, it just looks scary thus :p

19:09:08  *** Klanticus has joined #openttd.dev

19:59:27  *** Klanticus has quit IRC

20:37:14  *** frosch123 has quit IRC

21:02:01  *** Alberth has left #openttd.dev

22:44:12  *** Supercheese has quit IRC

23:11:33  *** Supercheese has joined #openttd.dev

23:11:33  *** ChanServ sets mode: +v Supercheese

continue to next day ⏵