IRC logs for #openttd.dev on OFTC at 2014-04-08
⏴ go to previous day
03:08:22 *** JGR_ has joined #openttd.dev
07:22:55 <planetmaker> looks good to me, fonsinchen
08:19:03 *** michi_cc has joined #openttd.dev
08:19:03 *** ChanServ sets mode: +v michi_cc
09:00:41 *** michi_cc has joined #openttd.dev
09:00:41 *** ChanServ sets mode: +v michi_cc
16:40:45 *** Alberth has joined #openttd.dev
16:40:45 *** ChanServ sets mode: +v Alberth
16:43:01 *** frosch123 has joined #openttd.dev
16:43:01 *** ChanServ sets mode: +v frosch123
17:10:33 <planetmaker> what's the difference between /= and //= ?
17:11:43 <LordAro> didn't you know that? :p
17:11:55 <Alberth> in python2, nothing if you divide 2 integers, in python 3 / is always a real result
17:12:07 <frosch123> LordAro: stuff that involves "real" is unpopular
17:12:24 <rubidium> ... after all, OpenTTD isn't real...
17:12:56 <Alberth> real world is also not that useful
17:13:38 <Alberth> I wonder whether return int(value.value // divisor) * 10 // 16 * unit.ottd_mul >> unit.ottd_shift should be moved around to do the division at the end
17:14:00 <planetmaker> is the paste truncated?
17:14:24 <frosch123> ah, good point, "raw" is a lot longer
17:14:26 <Alberth> setup.py is the last file
17:14:39 <frosch123> Alberth: i guess that formula is quite criticial wrt. rounding
17:14:49 <frosch123> it tries to reverse what ottd does
17:14:49 <rubidium> Alberth: it should be in the same order as in openttd due to rounding crap
17:15:07 <Alberth> ok, I'll leave it alone then :)
17:21:53 <planetmaker> so you went for the 'traditional' string way, yes?
17:23:01 <planetmaker> I clearly need more tea
17:23:26 <Alberth> I don't consider it very useful to change all % things for python2 tbh, too much risk breaking things
17:24:43 <planetmaker> no, definitely no point doing that just for py2
17:25:13 <Alberth> main goal is to reduce the size of the step to python3, as well as to get the documentation in
17:27:24 <planetmaker> - 'industry_town_count' : { 'var': 0x68, 'start': 16, 'size': 8, 'param_function': industry_town_count },
17:27:24 <planetmaker> + 'nearby_tile_industry_tile_id' : {'var': 0x60, 'start': 0, 'size': 16, 'param_function': unsigned_tile_offset},
17:27:42 <planetmaker> ^you don't like the spaces after and before the { } in the var definitions?
17:43:33 <Alberth> it's not consistent, and pylint for python3 wants them removed :)
17:44:37 <planetmaker> good enough reason :)
18:31:55 <planetmaker> Alberth, so to spell it out explicitly: please go for the change :)
18:36:01 <Alberth> hmm, I guess I should split it even further by type of change :)
18:36:23 <planetmaker> in doc and codechange
18:36:30 <planetmaker> but up to you. I won't insist
18:37:50 <Alberth> the commit message gets too messy otherwise :)
18:47:45 <frosch123> how does that work with build-while-pause?
18:48:03 <frosch123> doesn't it confuse clients? delay building?
18:48:05 <planetmaker> *good* question :)
19:46:38 <rubidium> it would delay things
19:46:59 <rubidium> it would also delay the server probing
19:55:29 <Alberth> nml patch splitting is a bit too much for now, will do that another evenink
19:56:14 *** Alberth has left #openttd.dev
20:27:00 *** Supercheese has joined #openttd.dev
20:27:00 *** ChanServ sets mode: +v Supercheese
20:40:26 *** planetmaker is now known as planetmake
20:42:14 *** planetmake is now known as planetmaker
21:11:43 *** JGR has joined #openttd.dev
23:51:34 *** JGR has joined #openttd.dev
continue to next day ⏵