IRC logs for #openttd.dev on OFTC at 2014-03-12
⏴ go to previous day
00:12:09 *** Knogle has joined #openttd.dev
00:53:13 *** juzza1 has joined #openttd.dev
16:59:43 *** Knogle has joined #openttd.dev
17:00:18 *** Zuu has joined #openttd.dev
18:01:00 *** frosch123 has joined #openttd.dev
18:01:00 *** ChanServ sets mode: +v frosch123
20:06:29 *** Knogle2 has joined #openttd.dev
20:07:56 *** Knogle2 has left #openttd.dev
20:08:00 *** Knogle has joined #openttd.dev
21:04:33 <frosch123> LordAro: i did not commit the removal of the functions in grfdiff
21:04:57 <frosch123> they are not exactly unused, they were meant to overwrite methods in the base class
21:05:12 <frosch123> but someone changed the signature in the base class, so now the functions are complete bollocks
21:05:23 <frosch123> but anyway, likely noone used grfdiff in the past 10 years
21:05:38 <frosch123> also whoever wrote it, did not know what virtual base classes are
21:11:21 <rubidium> is that bug really pre-repository?
21:13:41 <rubidium> maybe just drop grfdiff/grfmerge
21:14:32 <frosch123> and yes, the first import has still the same signature
21:14:39 <frosch123> removal would be a solution
21:29:26 <rubidium> even that doesn't seem to be complete
21:30:01 <frosch123> missing something specific?
21:30:25 <rubidium> patch unexpectedly ends in middle of line
21:30:25 <rubidium> patch: **** malformed patch at line 1791:
21:31:05 <rubidium> also some fuzz was needed for other lines at 978:51845bc5ce89
continue to next day ⏵