⏴ go to previous day
01:24:11  *** Supercheese has quit IRC

06:50:51  *** Supercheese has joined #openttd.dev

06:50:51  *** ChanServ sets mode: +v Supercheese

08:58:32  *** Alberth has joined #openttd.dev

08:58:32  *** ChanServ sets mode: +v Alberth

09:02:20  <Alberth> http://bugs.openttd.org/task/5933/getfile/9724/no-need-to-call-onfocus-twice.diff   looks ok to me

10:51:17  *** frosch123 has joined #openttd.dev

10:51:17  *** ChanServ sets mode: +v frosch123

10:55:07  <frosch123> funnily OnFocus is not used anywhere :p

10:56:28  <Alberth> maybe it was before editboxes were fully integrated?

10:56:39  <LordAro> probably because it was somewhat broken? :p

10:56:52  <frosch123> osk_gui calls _video_driver->EditBoxLostFocus(); twice though

10:57:03  <frosch123> no idea whether that matters, likely only michi_cc knows

10:57:39  <Alberth> or perhaps zuu?

11:01:10  <michi_cc> Where does it call it twice?

11:02:45  <Alberth> at the deleted line in the patch, the call above it also calls it

11:03:37  <Alberth> or were you not asking about OnFocus() ?

11:03:49  <frosch123> well, kind of depends. OnFocusLost triggers window destruction

11:03:54  <frosch123> and window destruction calls it again

11:04:27  <frosch123> hmm, though likely _focused_window is already NULL then

11:04:32  <frosch123> so, never mind .)

11:05:19  <frosch123> i think i got confused because it did not call the baseclass' OnFocusLost, but called the video_driver itself

11:05:44  <michi_cc> Even if it would, the video drivers that do implement it (Win32, OSX) just clear the IME input buffer. Clearing an empty buffer shouldn't harm :)

11:06:20  <michi_cc> And SDL/Unix doesn't even have an implementation :p

11:10:16  <frosch123> yeah, quite unusual, usally it's the other way around :p

12:34:20  *** Supercheese has quit IRC

12:34:54  *** Supercheese has joined #openttd.dev

12:34:54  *** ChanServ sets mode: +v Supercheese

21:04:52  *** frosch123 has quit IRC

21:52:09  *** Alberth has left #openttd.dev

continue to next day ⏵