IRC logs for #openttd.dev on OFTC at 2014-02-08
#openttd.dev / 2014 / 02 
            

01:15:55  *** Zuu has quit IRC



07:22:37  *** adf88 has joined #openttd.dev



07:22:38  *** ChanServ sets mode: +v adf88



10:32:16  *** Alberth has joined #openttd.dev



10:32:16  *** ChanServ sets mode: +v Alberth



11:55:11  *** frosch123 has joined #openttd.dev



11:55:11  *** ChanServ sets mode: +v frosch123



13:08:37  *** adf88 has quit IRC



13:08:49  *** adf88 has joined #openttd.dev



13:08:49  *** ChanServ sets mode: +v adf88



14:07:58  *** adf88 has quit IRC



14:08:27  *** adf88 has joined #openttd.dev



14:08:28  *** ChanServ sets mode: +v adf88



14:34:10  *** adf88 has quit IRC



14:35:32  *** adf88 has joined #openttd.dev



14:35:33  *** ChanServ sets mode: +v adf88



15:17:54  <Alberth> http://devs.openttd.org/~alberth/diffs/warn_missing_results/



15:20:04  <Alberth> first patch adds labels to the category and type filters of the advanced settings window; second patch adds warning about missing results; third patch adds warning about nothing being displayed



15:21:16  <planetmaker> which was the category, which the type?



15:22:49  *** adf88 has quit IRC



15:23:43  <Alberth> type is the bottom one



15:24:08  <planetmaker> so category: basic/adv./expert and type: game/company/client



15:24:18  <Alberth> yep



15:25:13  <planetmaker> +DECLARE_POSTFIX_INCREMENT(RestrictionMode) <-- what does that mean?



15:25:15  <frosch123> +					while (filter.min_cat < RM_ALL && (filter.min_cat == filter.mode || !this->IsVisibleByRestrictionMode(filter.min_cat))) filter.min_cat++; <- i don't get the "filter.min_cat == filter.mode"



15:25:35  <frosch123> when is it true and the !IsVisible is not true?



15:25:56  <Alberth>  http://devs.openttd.org/~alberth/missing_results1.png



15:26:24  <Alberth> planetmaker: filter.min_cat++   <-- otherwise that doesn't work



15:27:00  <Alberth> frosch123: otherwise the this->IsVisibleByRestrictionMode() is computed for the same value twice



15:27:42  <frosch123> about 3: town and sign list also display some string if everything is filtered



15:27:48  <frosch123> can you use the same one?



15:28:49  <Alberth> good point, I originally wanted "all settings were filtered away" but opted for a simpler text in the end



15:29:00  <frosch123> "- None -"



15:29:04  <planetmaker> +	WHR_CAT,      ///< Category setting filtered matches away. <-- can we name it WHR_CATEGORY ?



15:29:08  <Alberth> that makes re-use of the already available string possible.



15:29:11  <planetmaker> otherwise I expect dogs, too ;)



15:29:25  <Alberth> planetmaker: can be added :p



15:30:31  <planetmaker> maybe similarily expend WHR_CAT_TYPE



15:31:10  <Alberth> already added :)



15:32:46  <Alberth> hmm, we have lots of "- None -" strings :)



15:33:15  <planetmaker> yes... but it's not always good to reduce number. Translations might require them to be different



15:33:43  <planetmaker> so I'm not actually sure I support the notion to re-use an existing string



15:34:00  <planetmaker> actually rather not



15:34:15  <Alberth> STR_CONFIG_SETTINGS_NONE                                        :{WHITE}- None -



15:34:43  <planetmaker> there you have a colour you might not want :)



15:35:55  <Alberth> http://paste.openttdcoop.org/show/3069/   orange or yellow better? :)



15:36:35  <Alberth> white seems better to me



15:37:00  <planetmaker> likely yes



15:37:11  <planetmaker> and indeed, easy to add a string there, if really needed



15:39:20  <Alberth> http://devs.openttd.org/~alberth/missing_results2.png   this is a bit too much, but not sure how to reduce it



15:39:39  <Alberth> anyway, as you can see, it wraps automagically



15:40:33  <Alberth> patches 2 and 3 updated



15:40:55  <Alberth> (no CAT, STR_CONFIG_SETTINGS_NONE)



15:46:39  <planetmaker> add a {} after 'and'



15:47:07  <planetmaker> And possibly this is a case where the string needs some padding left and top



15:48:10  <planetmaker> hm... "Hint: Set Category to ... " ?



15:48:18  <planetmaker> or is 'hint' bad and uncommon



15:48:58  <Alberth> openttd is not a guessing game imho



15:50:11  <Alberth>  http://devs.openttd.org/~alberth/missing_results3.png   added {}{NBSP}



15:51:01  <Alberth> it needs "set" added as well ?



15:51:43  <frosch123> wasn't it centered before?



15:51:47  <planetmaker> what about vice versa: In order to show all results set{}Category to ... and Type to ...



15:52:00  <planetmaker> and centered would be nice



15:52:14  <Alberth>  http://devs.openttd.org/~alberth/missing_results4.png  look better



15:52:32  <Alberth> it's centered when it fits at one line



15:53:10  <Alberth> do we have code to center multi-line strings at all?



15:53:18  <planetmaker> with line break the paranthesis look weired imho



15:54:02  <Alberth> hmm, more -  ?



15:55:08  <Alberth> hmm, the "to show all search results)" messes it up



15:56:37  <Alberth> just leave it as is? ":{BLACK}(set {SILVER}Category {BLACK}to {WHITE}{STRING} {BLACK}and {SILVER}Type {BLACK}to {WHITE}All setting types {BLACK}to show all search results)"



15:59:44  <Alberth> planetmaker:   http://devs.openttd.org/~alberth/missing_results5.png   other way around



15:59:53  <Alberth> only changed this string currently



16:17:51  <planetmaker> hm... no multi-line centred strings possible?



16:23:10  <Alberth> GetStringMultiLineBoundingBox (StringID str, const Dimension &suggestion)    <-- you can get a bounding box if you suggest a width



16:23:26  <Alberth> there is no "natural width" calculation afaik.



16:26:26  * Alberth suggests to leave the (set ... results)   string



16:27:16  <planetmaker> http://paste.openttdcoop.org/show/3070/ <-- I wanted to suggest. But it doesn't exactly look too nice without center alignment either



16:30:30  <Alberth> ok, let's just use your suggestions then (without . )



16:31:59  <Alberth> it's not going to get much better



16:33:17  <Alberth> dinner time



16:48:55  *** adf88 has joined #openttd.dev



16:48:55  *** ChanServ sets mode: +v adf88



17:36:10  *** adf88 has quit IRC



17:36:23  *** adf88 has joined #openttd.dev



17:36:23  *** ChanServ sets mode: +v adf88



18:15:24  *** adf88 has quit IRC



18:20:54  *** adf88 has joined #openttd.dev



18:20:54  *** ChanServ sets mode: +v adf88



18:46:36  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26318 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"



19:21:56  *** adf88 has quit IRC



19:22:09  *** adf88 has joined #openttd.dev



19:22:09  *** ChanServ sets mode: +v adf88



19:51:54  *** adf88 has quit IRC



19:52:14  *** adf88 has joined #openttd.dev



19:52:15  *** ChanServ sets mode: +v adf88



20:29:56  *** adf88 has quit IRC



20:31:23  *** adf88 has joined #openttd.dev



20:31:23  *** ChanServ sets mode: +v adf88



21:06:36  *** Alberth has left #openttd.dev



21:53:20  *** adf88 has quit IRC



21:53:36  *** adf88 has joined #openttd.dev



21:53:36  *** ChanServ sets mode: +v adf88



22:00:52  *** adf88 has quit IRC



22:01:04  *** adf88 has joined #openttd.dev



22:01:04  *** ChanServ sets mode: +v adf88



22:17:22  *** adf88 has quit IRC



22:17:38  *** adf88 has joined #openttd.dev



22:17:38  *** ChanServ sets mode: +v adf88



22:55:30  *** frosch123 has quit IRC



23:00:57  *** adf88 has quit IRC



23:01:11  *** adf88 has joined #openttd.dev



23:01:11  *** ChanServ sets mode: +v adf88



23:27:38  *** adf88 has quit IRC



23:28:11  *** adf88 has joined #openttd.dev



23:28:11  *** ChanServ sets mode: +v adf88



23:35:24  *** adf88 has quit IRC



23:41:07  *** adf88 has joined #openttd.dev



23:41:07  *** ChanServ sets mode: +v adf88



23:57:33  *** Lizz has joined #openttd.dev