IRC logs for #openttd.dev on OFTC at 2014-01-16
#openttd.dev / 2014 / 01 
            

01:04:07  *** Supercheese has joined #openttd.dev



01:04:07  *** ChanServ sets mode: +v Supercheese



04:05:36  *** _1man2kinds has quit IRC



07:17:31  *** Supercheese has quit IRC



07:52:47  *** YogiM has joined #openttd.dev



07:54:43  *** YogiM has quit IRC



08:19:09  *** adf88 has joined #openttd.dev



08:19:09  *** ChanServ sets mode: +v adf88



10:32:29  *** akuryou has quit IRC



10:32:29  *** Webster has quit IRC



10:32:29  *** fonsinchen has quit IRC



10:32:29  *** TheIJ has quit IRC



10:32:29  *** Hirundo has quit IRC



10:32:29  *** juzza1 has quit IRC



10:32:29  *** planetmaker has quit IRC



10:32:29  *** LordAro has quit IRC



10:33:17  *** LordAro has joined #openttd.dev



10:33:17  *** solenoid.oftc.net sets mode: +v LordAro



10:41:39  *** akuryou has joined #openttd.dev



10:41:39  *** Webster has joined #openttd.dev



10:41:39  *** Hirundo has joined #openttd.dev



10:41:39  *** fonsinchen has joined #openttd.dev



10:41:39  *** planetmaker has joined #openttd.dev



10:41:39  *** juzza1 has joined #openttd.dev



10:41:39  *** TheIJ has joined #openttd.dev



10:41:39  *** reticulum.oftc.net sets mode: +vvv Webster fonsinchen planetmaker



16:02:10  *** Alberth has joined #openttd.dev



16:02:10  *** ChanServ sets mode: +v Alberth



16:55:45  *** _1man2kinds has joined #openttd.dev



17:58:58  *** frosch123 has joined #openttd.dev



17:58:58  *** ChanServ sets mode: +v frosch123



18:13:29  *** adf88 has quit IRC



19:11:27  *** adf88 has joined #openttd.dev



19:11:27  *** ChanServ sets mode: +v adf88



19:21:29  *** adf88 has quit IRC



19:38:32  *** _1man2kinds_ has joined #openttd.dev



19:42:24  *** _1man2kinds has quit IRC



19:46:53  *** _1man2kinds has joined #openttd.dev



19:50:24  *** _1man2kinds_ has quit IRC



20:15:35  <fonsinchen> https://github.com/ulfhermann/openttd/commit/6bd1dade36f35c0e674eb59a03e3865c321c6073 for FS#5865



20:20:16  <frosch123> looks fine



20:49:43  <fonsinchen> https://github.com/ulfhermann/openttd/commit/07622115337a46cddc8a2aa551cb6810ddf36886 for FS#5860



20:50:44  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26263 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"



20:53:16  <frosch123> how long is that refresh period actually?



20:53:40  <frosch123> does it disrupt when switching the cargo mask?



20:54:17  <fonsinchen> the period is about 2 seconds it seems



20:54:34  <fonsinchen> what do you mean with "disrupt when switching the cargo mask"?



20:55:09  <frosch123> i thought the first hunk would delay updating the display to the next refresh period when switching cargo



20:55:12  <frosch123> maybe that is wrong :p



20:55:57  <fonsinchen> that is wrong.



20:56:08  <fonsinchen> It just updates the cache twice



20:56:18  <fonsinchen> I can make that a second patch if necessary



20:56:49  <fonsinchen> in SetCargoMask it already does RebuildCache()



20:57:06  <frosch123> yeah, make two diffs then



20:57:10  <frosch123> more cake



20:58:45  *** adf88 has joined #openttd.dev



20:58:45  *** ChanServ sets mode: +v adf88



21:00:09  <fonsinchen> https://github.com/ulfhermann/openttd/commits/fixes2



21:00:12  <fonsinchen> there we go



21:01:09  <frosch123> is 1U << _local_company actually troublesome for spectators?



21:01:57  <frosch123> sometimes compilers/processors do silly things if the rhs is bigger than the bitsize of the lhs



21:02:51  *** _1man2kinds has left #openttd.dev



21:03:14  <fonsinchen> I better check for that then



21:06:07  <fonsinchen> What shall we do with spectators? Display nothing? Or rather everything?



21:06:36  <frosch123> c++98 5.8.1: The behavior is undefined if the right operand is negative, or greater than or equal to the length in bits of the promoted left operand.



21:07:50  <fonsinchen> I think I'll go for displaying all links from all companies.



21:08:38  <frosch123> fine by me either way, but if you show nothing, then better disable the linkstats button in legend



21:30:37  <fonsinchen> https://github.com/ulfhermann/openttd/commit/62f9373ec9ad521afbc5e4010c58464cce6e1f97 doesn't do invalid bit shifts anymore



21:35:39  <frosch123> +    return _local_company < 32 ? 1U << _local_company : 0xff; <- 0xFF is only 8 companies, there can be 15



21:36:41  <fonsinchen> interesting ...



21:37:31  <fonsinchen> Sorry for the spam. It seems I'm somewhat tired.



21:37:33  <frosch123> maybe also <= MAX_COMPANIES or Company::IsValid instead of < 32



21:38:14  <frosch123> at least it is productive spam :p



21:47:05  <fonsinchen> https://github.com/ulfhermann/openttd/commits/fixes2



21:47:15  <fonsinchen> I hope now I really got it right.



22:05:56  <frosch123> +  this->overlay = new LinkGraphOverlay(this, WID_SM_MAP, 0, this->GetOverlayCompanyMask()); <- shall the cargo-mask be zero here? it was ffffffff before



22:07:16  <frosch123> anyway, night



22:07:20  *** frosch123 has quit IRC



22:14:30  <fonsinchen> That was on purpose. It's set explicitly from both places where it's called now



22:15:27  <fonsinchen> I think r26263 is not enough to actually prevent all kinds of such recursion :(



22:15:35  <fonsinchen> I better go to sleep now ...



22:15:46  <fonsinchen> good night



22:38:27  *** Alberth has left #openttd.dev