⏴ go to previous day
01:14:05  *** adf88 has quit IRC

06:03:20  *** JGR_ has joined #openttd.dev

06:06:15  *** JGR has quit IRC

08:36:42  *** adf88 has joined #openttd.dev

08:36:43  *** ChanServ sets mode: +v adf88

09:28:35  *** Alberth has joined #openttd.dev

09:28:35  *** ChanServ sets mode: +v Alberth

11:02:14  *** adf88 has quit IRC

11:39:28  *** adf88 has joined #openttd.dev

11:39:28  *** ChanServ sets mode: +v adf88

12:21:48  *** adf88 has quit IRC

12:25:03  *** adf88 has joined #openttd.dev

12:25:03  *** ChanServ sets mode: +v adf88

12:39:51  *** adf88 has quit IRC

12:44:20  *** adf88 has joined #openttd.dev

12:44:21  *** ChanServ sets mode: +v adf88

16:29:31  *** adf88 has quit IRC

16:54:40  *** frosch123 has joined #openttd.dev

16:54:40  *** ChanServ sets mode: +v frosch123

17:40:14  *** adf88 has joined #openttd.dev

17:40:14  *** ChanServ sets mode: +v adf88

18:45:14  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26163 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"

19:33:28  *** Supercheese has joined #openttd.dev

19:33:28  *** ChanServ sets mode: +v Supercheese

20:24:15  *** Zuu has joined #openttd.dev

20:24:15  *** ChanServ sets mode: +v Zuu

20:24:58  <Zuu> Upon reading the source code of a new GS lib, I spotted an error in our docs which this patch fixes: http://devs.openttd.org/~zuu/10-fix-gs-prospect-doc.patch

20:25:45  <Zuu> Namely, that deity can build/prospect industries independent of setting "construction.raw_industry_construction"

20:28:06  <Alberth> If no valid ScriptCompanyMode active in scope  <-- first hunk, misses "is" (is in scope)

20:29:16  <Zuu> Yeah, I noticed that in the existing sentence on the unchanged line and decided to stay with the same wording.

20:29:36  <Alberth> there are supposed to be 2    @note If no valid ScriptCompanyMode   conditions?

20:29:51  <Alberth> I'd expect one for no mode, and one for having a mode

20:31:10  <Zuu> There are two @note for different cases when the method returns false. Both these situations are overrided/not valid when you construct as deity (no company mode in scope)

20:31:40  <Zuu> So both @note carry a leading condition that company mode must be in scope in order for that condition to apply.

20:34:15  <Alberth> ah, right. I'd expect that in a single sentence, but that may be too complex here

20:35:29  <Zuu> I think it is good to be as clear as possible.

20:35:44  <Alberth> btw I am translating the NAI script, and collect some english text comments; should I make an issue for it?

20:35:51  <Zuu> Which in some sense would be better to direct people to the source code.

20:35:57  <Alberth> I agree, the patch seems ok to me

20:36:28  <Zuu> Creating a ticket for it sounds good.

20:36:53  <Alberth> usually using source code for defining behaviour is bad, as it doesn't explain why things as they are

20:41:52  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26164 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"

21:45:07  *** Alberth has left #openttd.dev

22:29:54  *** adf88 has quit IRC

23:08:06  *** Zuu has quit IRC

23:19:12  *** DorpsGek has joined #openttd.dev

23:19:12  *** ChanServ sets mode: +v DorpsGek

23:20:25  <frosch123> @services op

23:20:25  *** ChanServ sets mode: +o DorpsGek

23:20:40  *** frosch123 has quit IRC

23:35:36  *** LordAro has joined #openttd.dev

23:35:36  *** ChanServ sets mode: +v LordAro

23:51:19  *** DorpsGek has joined #openttd.dev

23:51:19  *** ChanServ sets mode: +v DorpsGek

continue to next day ⏵