IRC logs for #openttd.dev on OFTC at 2013-07-12
⏴ go to previous day
09:12:13 *** ntoskrnl has joined #openttd.dev
15:15:30 *** Ristovski has joined #openttd.dev
15:41:53 *** Ristovski has joined #openttd.dev
16:47:55 <Rubidium> planetmaker: that smells like obiwan
16:48:53 <Rubidium> "The maximum length of a gamescript json string, in bytes including '\0'. Must not be longer than SEND_MTU including \0 and header (3 bytes)"
16:49:41 <Rubidium> the 4 are the header + '\0'
16:49:58 <Rubidium> but SEND_MTU - 4 already includes '\0' (according to the docs)
16:50:18 <Rubidium> but then you check without thinking of the '\0' in the code
16:51:36 <Rubidium> so... there's still a 1 byte difference between what can be sent or received
16:53:21 <planetmaker> but that constant for the max length of json strings is then used eveywhere (which is the main point). Not so much the actual length (which I set to SEND_MTU-4 on the save side. you say it should be -3?
16:54:22 <Rubidium> the constant should be SEND_MTU-3, and after the strlen there should be a +1 (so it counts the '\0')
16:54:30 *** LordAro has joined #openttd.dev
16:54:30 *** ChanServ sets mode: +v LordAro
17:00:06 *** frosch123 has joined #openttd.dev
17:00:06 *** ChanServ sets mode: +v frosch123
17:00:35 <planetmaker> you mean like the updated patch?
17:02:32 *** Ristovski has joined #openttd.dev
17:02:40 <planetmaker> should I also fix the alignment of the doxygen in the same commit?
17:02:49 <planetmaker> which the patch destroys?
17:03:16 <planetmaker> could be separate ;-)
17:03:28 <LordAro> Alberth would complain if you didn't fix :P
17:03:42 <Rubidium> if we want to go for 6420h, then the more the merrier
17:03:57 <frosch123> webster is broken :(
17:04:34 <planetmaker> and we want that, not? :-P
17:04:43 <planetmaker> what's wrong with webster, frosch123 ?
17:05:00 <frosch123> today's log of .dev fails to load
17:05:35 <frosch123> .devzone also works
17:10:01 *** Supercheese has joined #openttd.dev
17:11:55 *** Alberth has joined #openttd.dev
17:11:55 *** ChanServ sets mode: +v Alberth
17:20:27 *** Ristovski has joined #openttd.dev
18:42:47 *** ntoskrnl has joined #openttd.dev
18:50:32 <planetmaker> Rubidium, that's not the whole story
18:51:09 <planetmaker> the main problem is that the AI's individual settings are disabled if the difficulty is not set to 'custom'
18:51:19 <planetmaker> or so I understood the explanation on IRC
18:51:37 <Rubidium> that's not what I read in the bug report
18:51:58 <frosch123> i also read it like rb read it
18:52:22 <frosch123> planetmaker: there is no "custom" difficulty
18:52:27 <planetmaker> he's bad at expressing himself. I didn't check the bug report he made after that. Took me 30 minutes to understand the real issue
18:52:28 <Rubidium> and as far as I can see, I can still change settings
18:52:33 <planetmaker> frosch123, exactly. Not anymore
18:52:46 <planetmaker> was during day, so I didn't check life ingame
18:53:22 <Rubidium> anyhow, if that's the case... it's significantly different from the bug report and should've been a separate bug report
21:10:59 *** Alberth has left #openttd.dev
continue to next day ⏵