IRC logs for #openttd.dev on OFTC at 2013-06-08
⏴ go to previous day
03:05:52 *** Supercheese has joined #openttd.dev
06:02:10 *** Zuu has joined #openttd.dev
07:59:11 *** Alberth has joined #openttd.dev
07:59:11 *** ChanServ sets mode: +v Alberth
08:32:38 *** ntoskrnl has joined #openttd.dev
11:21:31 *** FLHerne has joined #openttd.dev
11:51:08 *** FLHerne has joined #openttd.dev
12:16:31 *** frosch123 has joined #openttd.dev
12:16:31 *** ChanServ sets mode: +v frosch123
12:24:33 <planetmaker> adding widget gets more and more complicated :-)
12:25:43 <planetmaker> Zuu, looks... funny though. At the end of the patch the same enum is defined...?
12:26:57 <Zuu> In the end of the patch the usual enum is defined. The script_window duplicates all enums for some reason.
12:28:39 <planetmaker> uh... against which OpenTTD should that patch apply?
12:28:52 <planetmaker> not against my trunk head
12:29:12 <planetmaker> hm... or I look in the wrong file :D
12:29:22 <Zuu> Hmm, I forgot to actually re-generate the API too. Patch updated.
12:30:03 <Zuu> My local clone is 2-3 weeks old. I should bring it up to date. :-)
12:30:30 <planetmaker> my comment was really based on looking for the last lines in the wrong file, but yeah :-)
12:31:15 <Zuu> It was just 22 revs behind trunk and no conflicts for that particular patch.
12:35:29 <frosch123> [14:28] <planetmaker> uh... against which OpenTTD should that patch apply? <- you could run the scripts yourself :p
12:38:53 <Zuu> That will make sure I don't include the graph window widgets when I run the script to fix my patcehs to include those changes. :-)
12:39:18 *** FLHerne has joined #openttd.dev
12:46:36 <frosch123> the compile farm burped
12:47:28 <frosch123> looks like you committed too much
12:47:35 <frosch123> there is also GSStoryPage stuff in it
12:47:48 <frosch123> /bamboo/src/game/game_instance.cpp:173: error: 'SQGSStoryPage_Register' was not declared in this scope
12:48:33 <Zuu> hmm, yes that is clearly an error. I wonder why it exist at the bottom of my patch queue
12:55:13 <Zuu> I'll commit a fix soon, I shall just ensure that the fix compiles.
12:55:31 <Zuu> (in a separate OpenTTD clone to be sure)
14:06:23 *** FLHerne has joined #openttd.dev
14:06:23 *** frosch123 has joined #openttd.dev
14:06:23 *** ntoskrnl has joined #openttd.dev
14:06:23 *** tycoondemon has joined #openttd.dev
14:06:23 *** Rubidium has joined #openttd.dev
14:06:23 *** planetmaker has joined #openttd.dev
14:06:23 *** Yexo has joined #openttd.dev
14:06:23 *** Terkhen has joined #openttd.dev
14:06:23 *** reticulum.oftc.net sets mode: +vvvv frosch123 Rubidium planetmaker Terkhen
14:06:23 *** Belugas has joined #openttd.dev
14:06:23 *** argonel_ has joined #openttd.dev
14:06:23 *** Webster has joined #openttd.dev
14:06:23 *** SmatZ has joined #openttd.dev
14:06:23 *** orudge has joined #openttd.dev
14:06:23 *** reticulum.oftc.net sets mode: +vvvo Belugas Webster SmatZ orudge
14:06:23 *** reticulum.oftc.net sets mode: +v orudge
14:38:08 *** frosch has joined #openttd.dev
14:52:56 *** frosch_ has joined #openttd.dev
14:55:06 *** DorpsGek sets mode: +v frosch_
14:55:29 <frosch_> also fix the linkgraph WindowDesc
15:48:44 <Rubidium> frosch_: looks okay to me
18:33:24 <Zuu> Regarding the story book patch queue: the feature patches are 30, 40 and 60. The others are preparations. (#65-70 are not finished yet)
18:34:06 <Zuu> I wonder, should I run the vbs to update the visual studio project files and include those changes into the patches which add files?
18:37:59 <frosch_> it's easier if you do the generated files only shortly before commit
18:38:16 <frosch_> though otoh, merging them is only reverting and regen
18:39:14 <frosch_> oh, hm, or are you acutally using vs?
18:39:15 <Zuu> In that case I'll generate those before commit, but perhaps I can keep the generated API/script file changes.
18:39:43 <Zuu> I use VS, but strip those changes away manually when uploading the patches.
18:39:57 <frosch_> well, then just keep them :)
18:43:01 <Zuu> If we want to start somewhere with getting it to trunk, I'd suggest starting with 20 (story data), 25 (count lines helper) and 30 (story gui). Those form more or less one unit after which the story book is functional and can be used. (but the player has to open it manually and find it in the league menu)
18:44:31 <Zuu> 30 is quite long. If it helps, I can create a variant of 30 that excludes the binary blobs with openttdgui.png and openttd.grf.
18:44:50 *** fonsinchen has joined #openttd.dev
18:44:50 *** ChanServ sets mode: +v fonsinchen
18:48:57 <frosch_> the docs in 20 do not seem to be correct anymore
18:49:11 <frosch_> "publishing" and stuff
18:51:06 <frosch_> there are also some IsPublishedStoryPage preconditions mentioned
18:51:30 *** FLHerne has joined #openttd.dev
18:52:56 <Zuu> I will remove them and look over the API docs.
18:53:50 <Zuu> I've been looking at this code for so many times that I'm getting blind. :-)
18:55:54 <frosch_> "\ No newline at end of file" <- there are some of those in 20
18:56:36 <frosch_> always put nl at end of file, your editor should have an option for that
18:57:24 <Zuu> I specifically looked over my files to remove the new line as Rubidium said something about them being unwanted, but perhaps I didn't understand what he ment.
18:57:41 <Alberth> the last line should also have a \n
18:58:12 <Alberth> depending on the editor, that either means no empty last line, or an empty last line
18:59:16 <Alberth> make a file with a single line containing a single letter
18:59:42 <Alberth> that file should be 2 bytes for unix EOL conventions, and 3 bytes for windows EOL conventions
19:00:15 <Rubidium> Zuu: I meant it shouldn't have that line saying there is no EOL at EOF
19:04:57 <frosch_> this->SetWidgetsDisabledState(Company::GetNumItems() == 0, WID_TN_STATIONS, WID_TN_FINANCES, WID_TN_TRAINS, WID_TN_ROADVEHS, WID_TN_SHIPS, WID_TN_AIRCRAFTS, WIDGET_LIST_END); <- in 60 that line might need extending for goal and storybook
19:06:39 <Zuu> 60 do not cover hiding and/or making the buttons disabled when they are useless. That will later be added either in 60 or a later patch.
19:07:08 <frosch_> yeah, but you need to disable them in multiplayer, if there are no companies
19:07:12 <frosch_> like the other company-dropdowns
19:07:26 <frosch_> not sure what happens when you try to open a dropdown with zero items :)
19:07:34 <frosch_> i would expect a crash :p
19:07:51 <Zuu> yes 60 needs to disable and hiding could go into 61 or so :-)
19:14:52 <Zuu> 20 do no longer refere to the action of publishing pages. It also now have a \n on the last line.
19:17:23 <Zuu> Hmm this looks interesting:
19:17:23 <Zuu> <Zuu> I use VS, but strip those changes away
19:17:32 <Zuu> + InvalidateWindowData(WC_STORY_BOOK, p->index);
19:28:17 <Rubidium> that looks bad (tm) ;)
19:37:42 <Zuu> A point that my test GS should have tested that command too.
19:42:10 <Zuu> It is indeed good, but the code need to get excuted in order to catch the bug.
20:09:39 <Rubidium> Zuu: 20 has misaligned entries in the saveload tables (tabs vs spaces)
20:10:48 <Zuu> Rubidium: Thanks for pointing that out
20:12:52 <Rubidium> Zuu: <> -> != since that's also used for e.g. text != NULL
20:13:43 <Zuu> possible a mismatch between Delphi and C++/Squirrel
20:15:15 <Rubidium> that reminds me of that joke about hide and seek and Newton and Pascal
20:24:29 <Zuu> Fixed tabs, and <> of 20. Fixed the bug in the DoCommand when deleting pages. However, I found a bug in the page selector code when you have a hole in the page IDs that needs fixing.
21:26:14 *** Alberth has left #openttd.dev
continue to next day ⏵