IRC logs for #openttd.dev on OFTC at 2013-05-24
⏴ go to previous day
04:19:43 *** Supercheese has joined #openttd.dev
10:07:22 *** Ristovski has joined #openttd.dev
11:33:18 *** Supercheese has joined #openttd.dev
13:02:54 *** Ristovski has joined #openttd.dev
14:11:32 *** ntoskrnl has joined #openttd.dev
15:31:11 *** LordAro has joined #openttd.dev
15:31:11 *** ChanServ sets mode: +v LordAro
16:07:48 *** Lord_Aro has joined #openttd.dev
16:14:16 *** Lord_Aro is now known as LordAro
16:44:36 *** Alberth has joined #openttd.dev
16:44:36 *** ChanServ sets mode: +v Alberth
17:25:54 *** frosch123 has joined #openttd.dev
17:25:54 *** ChanServ sets mode: +v frosch123
17:40:42 <Alberth> changes: 00 doxygen comment; 01 doxygen comment and removed a space after the cast; 02 no changes; 03 simplified the GetMatrixColumnCount, and prevent reduction in size
17:44:25 * Rubidium wonders whether the matrix handles the case where selected_object_index is out of bounds?
17:46:33 <Rubidium> doesn't look like it
17:46:54 <Rubidium> so things might go crashy when newgrfs are changed
17:52:18 <Alberth> in CanRestoreSelectedObject: if ((int)sel_objclass->GetSpecCount() < _selected_object_index) return false;
17:53:24 <planetmaker> in 02: + if (_selected_object_index != -1) matrix->SetClicked(_selected_object_index); <-- doesn't exist a named constant for the -1?
17:54:15 <Alberth> nope, -1 is used elsewhere too
17:54:39 <planetmaker> :-) I thought like MAX_OBJECT or so
17:54:59 <Rubidium> lets name it TWO_COMPLEMENT_SINGLE_BIT_SIGNED_ONE
17:57:29 <Alberth> it should mostly fix the problems of the eye candy players where the object window is reset each time you close+open it (eg for deleting a tile)
17:58:04 <planetmaker> that sounds desirable
18:28:22 <Alberth> hmm, should be <= for the object index
18:42:52 *** FLHerne has joined #openttd.dev
20:00:23 *** Ristovski has joined #openttd.dev
20:41:08 *** Alberth has left #openttd.dev
20:50:39 *** FLHerne_ has joined #openttd.dev
20:51:04 *** argonel_ has joined #openttd.dev
continue to next day ⏵