IRC logs for #openttd.dev on OFTC at 2013-05-18
⏴ go to previous day
07:28:05 *** Alberth has joined #openttd.dev
07:28:05 *** ChanServ sets mode: +v Alberth
09:10:56 *** ntoskrnl has joined #openttd.dev
09:36:58 *** FLHerne has joined #openttd.dev
10:14:47 *** Ristovski has joined #openttd.dev
11:31:27 *** Supercheese has joined #openttd.dev
14:13:36 *** argonel_ has joined #openttd.dev
14:18:58 *** ntoskrnl11 has joined #openttd.dev
14:32:15 <Alberth> didn't frosch suggest "private" instead of "hidden" yesterday?
14:32:32 <Alberth> seems a good change to me
14:33:07 <Alberth> string names are wrong too?
14:33:51 <Rubidium> sounds like we should introduce a "simplified English" translation ;)
14:34:07 <Rubidium> with the wrong words/meaning, but understandable by the noob
14:35:59 <Alberth> mentioning LAN and Internet together gives no real hint that the setting is, imho
14:36:36 <Rubidium> where are the times of the LAN parties ;)
14:37:34 <planetmaker> well, the difference is only the advertising in that setting. So that difference should be made clear
14:37:54 <planetmaker> It's not simplified imho. It's made clear what it does in the first place
14:38:51 <Alberth> LAN (not advertised) vs Internet (advertised) ?
14:39:14 <planetmaker> yes-ish. but the "not advertised" server is also reachable from the internet
14:39:18 <planetmaker> thus imho that doesn't cut it
14:40:24 <Alberth> depends on your router settings, but I see the point
14:41:50 <Alberth> Instead of "Connection" "Advertising", with values "Off" and "On" ?
14:47:37 <Alberth> time to look into dinner options
15:22:04 <planetmaker> mind if I commit the changes to bin/baseset ?
15:23:11 <planetmaker> Scotish Gaelic is missing and leaves... modified state after compilation
16:04:11 *** Ristovski has joined #openttd.dev
16:07:47 <Alberth> while you are at it, you may want to add some doxygen comments to the dropdown arrays
16:08:35 <Alberth> I am not sure rename is a good idea; the strings are really new
16:08:51 <Alberth> perhaps it is better to add new ones and delete the old ones?
16:09:52 <planetmaker> It doesn't really change... they only become clearer. And translators will see the need to revise it
16:10:01 <planetmaker> But I don't really mind either
16:10:11 <planetmaker> As easy to delete them as to sed ;-)
16:10:44 <Alberth> hmm, lots of "Yes" / "No" strings, but no generic ones :)
16:11:19 <planetmaker> You think we should fallback to generic yes/no? Generally I think separate strings are better usually
16:11:28 <planetmaker> allows for more individual interpretation
16:11:37 <planetmaker> especially to translators
16:12:09 <Alberth> no, I was just thinking perhaps we have generic strings for that purpose
16:12:31 <planetmaker> what purpose? yes/no?
16:13:03 <Alberth> purpose of answering a yes/no question :)
16:13:24 <Alberth> interestingly, the order of both dropdowns is reversed :)
16:14:22 <planetmaker> it's order of defaults: you want usually to search for public servers. But you usually don't want to create one
16:15:00 <Alberth> yeah, it looks correct
16:16:21 <Alberth> looking fine otherwise, imho
16:17:08 <planetmaker> hm, maybe server list should read 'advertised' instead of 'advertise'
16:19:26 <Alberth> Advertisement <-- that one?
16:19:46 <Alberth> I'd write "Advertising"
16:20:18 <planetmaker> I meant rather the naming of the strings than their text. But yes, that maybe, too
16:20:18 <Alberth> and perhaps s/shall/will/
16:21:16 <Alberth> {BLACK}Choose whether the server shall be advertised (recommended for an internet game) or not advertised (r.. <-- it says "advertised" already here
16:22:07 <Alberth> aka, I don't understand what you mean :p
16:22:11 <planetmaker> +STR_NETWORK_SERVER_LIST_ADVERTISEMENT_TOOLTIP -> +STR_NETWORK_SERVER_LIST_ADVERTISED
16:23:03 <planetmaker> and {BLACK}Advertisement -> {BLACK}Advertised
16:23:31 <planetmaker> of course keeping TOOLTIP
16:24:02 <Alberth> _ADVERTISED_ in the string name seems better indeed
16:24:12 <planetmaker> as that's the list (which shows whether those which are (not). And the other is the future of what you're going to do
16:25:35 <Alberth> (06:23:04 PM) planetmaker: and {BLACK}Advertisement -> {BLACK}Advertised <-- seems ok to me
16:26:43 <Alberth> the 2nd "advertised" in the tooltip seems a bit too much perhaps
16:27:07 <Alberth> ie "Choose whether ... advertised ( .. ) or not ( ..)"
16:28:04 <planetmaker> I had that first without th 2nd. Due to the long (...) I found it hard to follow what the 'not' referred to
16:33:33 <planetmaker> thanks Alberth :-)
16:34:52 <Alberth> this patch didn't explode much in size :)
16:35:53 <planetmaker> if you add all translation files: then it became 10-fold ;-)
16:36:13 <planetmaker> you're still for removal of strings, right?
16:41:44 <Alberth> it feels a bit more safe that way, but either way is acceptable to me
16:51:07 <planetmaker> seems like the last polishing is for tomorrow. Gotta leave in a few minutes.
16:52:06 <Alberth> bye, have a nice evenink :)
16:52:44 <planetmaker> thank you. And I wish the same to you :-)
17:42:48 *** FLHerne_ has joined #openttd.dev
18:27:22 *** FLHerne_ has left #openttd.dev
18:27:31 *** FLHerne has joined #openttd.dev
19:06:34 *** Alberth has left #openttd.dev
19:21:46 *** Zuu has joined #openttd.dev
continue to next day ⏵