IRC logs for #openttd.dev on OFTC at 2013-02-25
#openttd.dev / 2013 / 02 
            

03:27:52  *** Webster has quit IRC



03:29:10  *** Webster has joined #openttd.dev



03:29:10  *** ChanServ sets mode: +v Webster



03:30:46  *** Yexo has quit IRC



03:30:56  *** Yexo has joined #openttd.dev



04:01:46  *** Supercheese has quit IRC



04:02:15  *** Supercheese has joined #openttd.dev



08:42:44  *** Supercheese has quit IRC



08:58:44  *** fonsinchen has joined #openttd.dev



08:58:44  *** ChanServ sets mode: +v fonsinchen



11:34:55  <fonsinchen> What's the recommended thing to do if CanAllocateItem returns false?



11:35:39  <fonsinchen> In most cases we have to abort then, so I can basically always assert on that.



11:35:43  <fonsinchen> Right?



11:38:01  <fonsinchen> I should make sure the pool allows for enough items to be created of course.



12:19:11  *** ChanServ sets mode: +v Rubidium



12:19:17  <Rubidium> no, an assert on CanAllocateItem is bad



12:19:32  <Rubidium> asserts can be compile out of the source



12:19:53  <Rubidium> also, CanAllocateItem is often in the main code at places where you rather not crash (like commands)



12:20:33  <Rubidium> I've got no idea what the pool will be used for though, so I can't really give a sensible answer



12:28:36  <fonsinchen> I have a pool for link graphs and one for link graph jobs.



12:29:02  <fonsinchen> I'm making both large enough so that there can theoretically be 32 graphs and 32 jobs for each station.



12:29:38  <fonsinchen> It should always be able to allocate a link graph or a link graph job then if there's no mistake in the game logic.



12:31:01  <fonsinchen> Or rather: If I cannot allocate a link graph when I need one I'm out of luck and need to kill the game to avoid desyncs.



12:31:28  <Rubidium> then rather do if (!CanAllocate()) { /* Some comment explaining why it can't happen. */ NOT_REACHED(); }



12:39:39  <fonsinchen> fine



13:37:47  *** ntoskrnl has joined #openttd.dev



15:50:36  *** fonsinchen has quit IRC



17:11:14  *** LordAro has joined #openttd.dev



17:11:14  *** ChanServ sets mode: +v LordAro



17:46:41  *** frosch123 has joined #openttd.dev



17:46:41  *** ChanServ sets mode: +v frosch123



18:29:31  *** ntoskrnl has quit IRC



18:45:25  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25048 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"



19:24:06  *** Lord_Aro has joined #openttd.dev



19:24:06  *** LordAro is now known as Guest223



19:24:06  *** ChanServ sets mode: +v Lord_Aro



19:24:06  *** Lord_Aro is now known as LordAro



19:30:05  *** Guest223 has quit IRC



21:11:59  *** frosch123 has quit IRC



23:07:35  *** LordAro has quit IRC