IRC logs for #openttd.dev on OFTC at 2013-02-17
⏴ go to previous day
02:40:57 *** Supercheese has joined #openttd.dev
03:18:35 *** Supercheese has joined #openttd.dev
09:00:12 *** Alberth has joined #openttd.dev
09:00:12 *** ChanServ sets mode: +v Alberth
09:16:33 *** planetmaker is now known as planetifex
09:16:45 *** planetifex is now known as planetmaker
11:21:38 *** frosch123 has joined #openttd.dev
11:21:38 *** ChanServ sets mode: +v frosch123
11:31:36 *** ntoskrnl has joined #openttd.dev
11:40:32 *** Zuu has joined #openttd.dev
13:53:51 *** FLHerne has joined #openttd.dev
17:32:04 *** fonsinchen has joined #openttd.dev
17:32:04 *** ChanServ sets mode: +v fonsinchen
17:33:51 <fonsinchen> woohoo! You've merged the reservation thing.
17:36:11 <fonsinchen> Unfortunately you've also merged a bug I've just discovered this morning ... :/
17:37:30 <fonsinchen> The "waiting" figure in UpdateStationRating can actually be > ge->cargo.Count(). In that case we should not truncate. Otherwise we get an overflow and truncate to 0.
17:37:49 <fonsinchen> I'll open a report for that.
17:42:38 <Rubidium> well, I reckon people will find even more bugs in it (like they do in almost everything)
17:43:46 <fonsinchen> Yes, there are probably a few more bugs in there as it hasn't been tested for very long.
17:44:08 <fonsinchen> The later commits have been pretty stable for about a year. I don't think there are many bugs left in them.
17:47:59 <Rubidium> hmm... the SmallMapWindow refactor does a 'class' refactoring, and some other code changes. That's a pity
17:55:48 <fonsinchen> I needed to clean that up a bit to allow for the unified treatment of smallmap and viewport.
17:56:04 <fonsinchen> What exactly do you mean by 'class' refactoring?
17:56:34 <Rubidium> that you move the class to the header and unindent everything by 1 tab + add SmallWindow:: to the functions in the .cpp
17:57:00 <Rubidium> usually we do that in one patch, and in the other patch we'd do the remaining codechanges to unify it further
17:58:24 <fonsinchen> well, I need the class declaration in the header, obviously. I can split the patch in two like that, though.
17:58:58 <Rubidium> that'd be favourable; makes it easier to see the actual changes that are being made
18:05:30 <Rubidium> and you might also want to check the TODO you put in smallmap_gui.h
19:59:17 *** Supercheese has joined #openttd.dev
20:28:30 <fonsinchen> OK, there you go. The branch is called "cd25016" for now as I want the compile farm to build the hotfix on top of the previous "cd" branch tonight.
20:29:05 <fonsinchen> I've split up the smallmap refactoring into 3 parts and put it at the beginning of the patch queue
20:40:46 <Rubidium> a lovely easy to review 71k patch ;)
20:53:31 <Rubidium> if you would've let cd25016 to compile by the CF, I'd reckon it failed to make binaries
20:54:04 <Rubidium> though I could poke the CF to build cd now
20:54:20 <frosch123> isn't the cd farm failing for months?
20:54:28 <frosch123> i regulary get failures via rss
20:54:32 <fonsinchen> Yes, I've seen 25019 ... I missed that one.
20:54:40 <frosch123> it fails to resolve the repository or something like that
20:55:04 <fonsinchen> It has been working fine for the last couple of weeks after failing a lot before.
20:55:25 <frosch123> ah, indeed, i only get failures via rss, no fixes :)
21:00:04 <fonsinchen> If you poke the compile farm to build cd now, I'll rename cd25016 to cd after that. I promised that guy on the forums that tonights version will be savegame-compatible ...
21:00:51 <fonsinchen> (and I'll rebase again before that of course)
21:01:17 <Rubidium> did you already merge with the 180/service interval savegame bump?
21:02:18 <Rubidium> if so, you could keep cd savegame compatible by simply forcing the last 'patch' to emit the right savegame version
21:03:59 <fonsinchen> Uhm, actually both have 180
21:08:01 <Rubidium> the CF ought to be done in ~15 minutes
21:08:22 <Rubidium> though it might be busier at this time of day, so it's anybody's guess ;)
21:12:11 <fonsinchen> OK, then I don't start hacking around to preserve savegame compatibility now ... I'll instead rebase again.
21:23:19 <fonsinchen> I've rebased on 25021 and pushed to the usual "cd" branch.
21:23:41 <fonsinchen> Thanks for triggering the CF.
21:27:22 <Rubidium> that new version will build this night
21:31:14 *** LordAro has joined #openttd.dev
21:31:14 *** ChanServ sets mode: +v LordAro
21:39:42 *** FLHerne has joined #openttd.dev
21:40:10 <fonsinchen> I'll be back tomorrow around noon
22:06:52 *** Alberth has left #openttd.dev
continue to next day ⏵