IRC logs for #openttd.dev on OFTC at 2012-12-31
⏴ go to previous day
10:24:27 *** ntoskrnl has joined #openttd.dev
10:49:58 *** Alberth has joined #openttd.dev
10:49:58 *** ChanServ sets mode: +v Alberth
11:18:29 *** fonsinchen has joined #openttd.dev
11:18:30 *** ChanServ sets mode: +v fonsinchen
12:13:36 *** Rubidium has joined #openttd.dev
12:30:13 *** FLHerne has joined #openttd.dev
12:59:22 *** DorpsGek sets mode: +v Rubidium
12:59:34 <Terkhen> Alberth: you need to ask DorpsGek :)
13:00:32 <Alberth> I thought @ is enough, but not, apparently
13:47:18 <planetmaker> maybe you're not identified to dorpsgek :-)
14:01:29 <fonsinchen> Thanks, I'll have a look.
14:02:27 *** Sturmi has joined #openttd.dev
14:34:10 <Terkhen> I'm thinking about screenshot.cpp
14:34:53 <Terkhen> for the scenario format, I'm going to need to add a lot of ScreenshotCallback functions
14:35:01 <Terkhen> one for each layer type
14:36:34 <Terkhen> I think that I'm going to expose the screenshot functions and types that I need in screenshot.h and define the new callbacks at heightmap_layer.cpp, since they are functions that use the layers objects
14:36:51 * Terkhen gets confused as soon as he starts mixing C style code with objects and classes :P
14:45:20 <fonsinchen> Rubidium: I'll send the answers by PM
15:01:38 *** LordAro has joined #openttd.dev
15:02:18 <Alberth> Terkhen: would it make sense to turn things around? that is, construct a destination object, and give that to the routines that add a layer?
15:02:18 <Alberth> It may depend on how the image construction works though
15:02:53 <planetmaker> fonsinchen, wouldn't it be useful for everyone to see / read your answers?
15:02:53 *** LordAro has left #openttd.dev
15:02:57 *** LordAro has joined #openttd.dev
15:02:57 *** ChanServ sets mode: +v LordAro
15:04:37 <Terkhen> Alberth: my current approach is to initialize a WriteTar object and pass it to each layer to let it write itself... each layer class must define a ScreenshotCallback that extracts the information to write for it
15:05:30 <Terkhen> the actual code that adds a layer to the tar file is abstracted on the parent HeightLayer class, it only needs to change the callback
15:05:30 <Terkhen> I'm not sure yet if I'll be able to write it in the way I described, though :P
15:07:41 <Terkhen> I'm planning to change screenshot.cpp as little as possible :)
15:07:56 <Terkhen> the rework of heightmap.cpp was enough already
15:18:08 <fonsinchen> Maybe I'll make a new thread in the dev forum then. "Cargodist review"
15:45:30 <planetmaker> fonsinchen, "What if this next yields NULL? In the 'true' case you explicitly check for it": your reply implies that an assert pointer != NULL is in order
15:45:49 <planetmaker> as to catch the unthinkable :-)
15:47:17 <Rubidium> there's more review to review ;)
15:47:26 *** Sturmi has joined #openttd.dev
16:10:58 <fonsinchen> planetmaker: an assert can be done
16:11:29 <fonsinchen> in general, write your questions in the thread please. I'll be back next year
16:33:45 *** andythenorth has joined #openttd.dev
16:33:45 *** ChanServ sets mode: +v andythenorth
17:16:59 <Rubidium> pff... still 5354 of 14661 lines to go
17:29:03 *** andythenorth has joined #openttd.dev
17:29:03 *** ChanServ sets mode: +v andythenorth
17:57:30 *** andythenorth has joined #openttd.dev
17:57:31 *** ChanServ sets mode: +v andythenorth
18:44:25 *** andythenorth has joined #openttd.dev
18:44:25 *** ChanServ sets mode: +v andythenorth
20:03:07 *** andythenorth has joined #openttd.dev
20:03:07 *** ChanServ sets mode: +v andythenorth
20:15:14 *** FLHerne has joined #openttd.dev
22:40:01 *** FLHerne has joined #openttd.dev
23:41:20 *** vr6apparatus has joined #openttd.dev
continue to next day ⏵