IRC logs for #openttd.dev on OFTC at 2012-12-04
#openttd.dev / 2012 / 12 
            

00:44:35  *** Zuu has quit IRC



05:31:52  *** Supercheese has joined #openttd.dev



08:32:35  *** Zuu has joined #openttd.dev



08:32:35  *** ChanServ sets mode: +v Zuu



08:53:58  *** Zuu has quit IRC



12:30:57  *** Supercheese has quit IRC



12:31:28  *** Supercheese has joined #openttd.dev



14:35:45  <Belugas> hello



16:38:53  *** FLHerne has joined #openttd.dev



17:57:20  *** frosch123 has joined #openttd.dev



17:57:20  *** ChanServ sets mode: +v frosch123



18:19:01  *** Alberth has joined #openttd.dev



18:19:01  *** ChanServ sets mode: +v Alberth



18:33:25  *** ntoskrnl has joined #openttd.dev



18:45:13  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24783 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"



18:53:55  <frosch123> http://devs.openttd.org/~frosch/diffs/diffsettings/ <- repost from sunday



18:58:27  <Alberth> it's new for me :)



18:58:52  <frosch123> not all :) you already saw some strings



18:58:54  <Alberth> OSKA_DISABLED = 0,  <-- is "= 0" allowed according to the code style?



18:59:27  <Alberth> I'll skip those then :)



18:59:39  <frosch123> allowed wrt. what?



18:59:46  <frosch123> it must be 0 :)



19:00:37  <Alberth> it is by default, and we usually don't specify it afaik



19:00:56  <frosch123> ok, IndustryDensity doesn't thave it



19:01:45  <Alberth> last hunk  misc_gui.cpp (@@ -835,8 +844,11 @@)  doesn't look correct w.r.t. the code style



19:03:11  <Alberth> Mouse gesture with which the OSK can be triggered.  <-- Mouse gesture to trigger the OSK.     ? (I like the word 'gesture'; very modern :) )



19:04:44  <frosch123> ah, the work coding style disease again :/



19:04:45  <Alberth> 20  +HighScore _highscore_table[SP_HIGHSCORE_END][5]; // various difficulty-settings; top 5    <-- make it a ///<



19:05:19  <frosch123> eagle_rainbow used 'gesture' :)



19:05:38  <frosch123> oh, forgot credits :S



19:07:24  <Alberth> -/* Save the highscores in a network game when it has ended */  <-- was that not the description of "int8 SaveHighScoreValueNetwork()"? (not very complete, but nonetheless, a waste to delete imho



19:10:02  <frosch123> hmm, maybe :p



19:10:15  <frosch123> i'll make it a /** then



19:10:24  <Alberth> please do :)



19:13:37  <Alberth> +		memset(_highscore_table[SP_MULTIPLAYER], 0, sizeof(_highscore_table[SP_MULTIPLAYER]));  use MemSetT ?



19:15:06  <frosch123> iirc memsett fails with static arrays



19:15:31  <frosch123> it does an array-.>pointer cast, and then only clears sizeof(void*)



19:15:51  <Alberth> could be, better leave it then



19:19:31  <Alberth> in 20, you have symbolic constants in the ini data, in 10, you have numbers



19:20:25  <frosch123> yeah, the enum in 20 is used in many places, so it is in a header



19:20:43  <frosch123> in 10 it is only used in one place, and i don't want to dump all enums for some silly setting into settings_type.h



19:20:52  <Alberth> 25: !(this->save.conv & SLF_NO_NETWORK_SYNC)  <-- is this within code style?



19:21:01  <frosch123> i think so



19:21:04  <Alberth> fair enough about 10



19:26:54  <Alberth> 10 string values like STR_CONFIG_SETTING_OSK_ACTIVATION_DOUBLE_CLICK are in lower case, in 40 they start with an uppercase letter



19:31:04  <frosch123> hmm, let's see what other settings do



19:33:04  <Alberth> :o  you removed all difficulties!



19:33:10  <Alberth> great patch



19:33:47  <frosch123> ah, yeah, i didn't gave you the summary about the queue :)



19:33:56  <frosch123> so, it was a surprise :)



19:34:37  * Alberth is happy that you kept the easy bits :)



19:35:19  <frosch123> hmm, about the capitalisation... it looks like it is currently 50/50 with the other settings :p



19:35:26  <frosch123> so i am keeping that ratio :p



19:36:50  <Alberth> sounds good :)



19:37:22  <frosch123> it's after a ":" usually, so maybe we should go for upper case?



19:37:42  <frosch123> the bool values are also upper case



19:37:44  <Alberth> yeah, fine with me



20:25:19  *** ntoskrnl has quit IRC



21:18:36  *** Zuu has joined #openttd.dev



21:18:36  *** ChanServ sets mode: +v Zuu



21:44:59  *** Alberth has left #openttd.dev



22:29:11  *** frosch123 has quit IRC