IRC logs for #openttd.dev on OFTC at 2012-11-25
⏴ go to previous day
00:33:05 *** MinchinWeb_ has joined #openttd.dev
09:00:24 *** Alberth has joined #openttd.dev
09:00:24 *** ChanServ sets mode: +v Alberth
09:44:58 *** fonsinchen has joined #openttd.dev
09:44:58 *** ChanServ sets mode: +v fonsinchen
09:59:54 *** Sturmi has joined #openttd.dev
10:28:11 *** ntoskrnl has joined #openttd.dev
11:32:32 *** frosch123 has joined #openttd.dev
11:32:32 *** ChanServ sets mode: +v frosch123
11:39:41 *** MinchinWeb_ has joined #openttd.dev
11:41:36 *** andythenorth has joined #openttd.dev
11:41:36 *** ChanServ sets mode: +v andythenorth
11:44:26 * planetmaker goes give that patch a try
11:46:36 <frosch123> Alberth: in src/scrip/api run both generate_widget.sh and squirrel_export.sh :)
11:48:09 <frosch123> there is some function to get the cargos in sorted order
11:49:09 <frosch123> FOR_ALL_SORTED_CARGOSPECS
11:49:57 <frosch123> hmm, or FOR_ALL_SORTED_STANDARD_CARGOSPECS
11:50:05 <frosch123> there is no documentation about the difference :p
11:50:42 <frosch123> ah, it excludes stuff like "regearing"
11:50:51 <frosch123> so, i guess you need FOR_ALL_SORTED_STANDARD_CARGOSPECS then :)
11:51:25 <frosch123> how about a new menu item in the "industry" menu?
11:51:38 <frosch123> it feels weird to click some random industry, and then select whatever cargo
11:54:16 <frosch123> if you use ShowDropDownList instead of ShowDropDownMenu, you don't need "cargo_numbers". the dropdown can translate the strings into any id itself
11:55:19 <Alberth> I did run both, perhaps in the wrong order :)
11:59:24 <Alberth> from the menu, open with the first industry?
11:59:42 <frosch123> industry? you mean cargo?
12:00:21 <Alberth> the code doesn't support that currently, but that would be an alternative
12:00:22 <frosch123> first would be pax then, but i guess the is no correct choice
12:00:50 <frosch123> opening it for an industry imo only makes sense if there is also a dropdown for industrytype :p
12:02:09 <andythenorth> what's the feature?
12:02:33 <Alberth> cargo dropdown in the industry chain window
12:03:05 <frosch123> entering the chain window without having to find a industry which produced the stuff :)
12:03:49 <Alberth> While making coffee, I also pondered about an industry dropdown; could be useful
12:04:46 <frosch123> opening it for the first industry might be nicer then
12:05:09 <frosch123> while there is no right choice, pax is definitely second most useless :)
12:05:48 <Alberth> it also makes slightly more sense in an "industry" menu :)
12:06:29 <andythenorth> I always do chain window - link to minmap :P it's a nice feature
12:07:19 <Alberth> but doing that for a specific cargo, is a pain
12:07:27 <andythenorth> is a map overlay out of the question? Like another sign layer?
12:07:46 <frosch123> you mean like cargodist connections?
12:08:23 <andythenorth> not sure, havent' seen them. It's how railroad tycoon handles showing source / destinations for cargo
12:08:30 <andythenorth> directly on the map
12:08:38 <andythenorth> or we could do it on the minimap
12:08:38 <frosch123> well, showing all connections hardly makes sense :)
12:09:07 <frosch123> you would have to select a signle industry, and then only display the closest suppliers or destinations
12:09:12 <andythenorth> I was thinking the map shows points, with icon or label, and arrow for input / output
12:09:23 <andythenorth> I should mockup :P
12:09:32 <frosch123> so plus/minus icons?
12:10:19 <andythenorth> literally using the existing signs
12:12:13 <Alberth> that sort of means you'd merge the industry chain window into the minimap, imho
12:17:17 <andythenorth> I favour either small icons on the minimap (new view on the minimap, similar to industries, shows cargos, each cargo can be toggled on / off)
12:17:21 <andythenorth> or signs on the actual map
12:17:36 <andythenorth> minimap seems most in tune with rest of game
12:20:17 <frosch123> well, only a mockup can tell
12:20:26 <frosch123> i fear you won't find anything on the minmap anymore :p
12:21:19 <frosch123> independen of that, i might be useful to tell the chain window whether it shall only display the input or output industries on the minmap
12:22:04 <Alberth> I tried that, but I wasn't really happy with the interface, let me try to find the patch
12:34:44 *** MinchinWeb__ has joined #openttd.dev
14:35:26 *** ntoskrnl has joined #openttd.dev
14:52:24 <Alberth> added industry drop-down, and the other remarks
14:55:46 <frosch123> hmm, is it possible that there are no industry types at all? :p
14:56:13 <frosch123> maybe turn the assert into a return for that case
14:59:34 <Alberth> if (lst->size() == 0) break; then :)
14:59:54 <frosch123> maybe also use _sorted_industry_types in ShowIndustryCargoesWindow as well
15:00:07 <frosch123> Alberth: delete lst
15:00:44 <frosch123> if (lst->size() == 0) { delete lst; break; }
15:04:16 <Alberth> used the _sorted_industry_types in the Show function as well
15:04:59 <frosch123> is it necesary that ShowDropDownList gets a valid selected item?
15:05:19 <frosch123> "lst->front()->result" looks weird in game
15:05:49 <frosch123> or does that need catching in OnDropdownSelect ?
15:06:49 <Alberth> don't know, but not selecting may be better indeed
15:08:15 <Alberth> looks like it, DropdownWindow has nothing special for selected_index < 0
15:09:13 <Alberth> if (index < 0) return; added in OnDropdownSelect
15:10:00 <frosch123> assert(id < NUM_INDUSTRYTYPES); <- did you also replace that one with a return?
15:10:48 <Alberth> hmm, but it may thus crash for selecting a default industry :(
15:12:02 <frosch123> diff looks like a nice feature to me :)
15:12:36 <frosch123> hmm, was the window also resizeable before?
15:13:03 <frosch123> it feels weird that you can resize it horizontally, but the chain display is not centered
15:17:06 *** andythenorth has joined #openttd.dev
15:17:07 *** ChanServ sets mode: +v andythenorth
15:18:01 <Alberth> there is not much point in horizontal resize at all
15:18:29 <frosch123> yeah, forbidding that should also work
15:35:06 <Alberth> added the docs patch to my other doc string fixes
15:35:28 <andythenorth> +1 to the industry chain window changes
15:35:30 <andythenorth> just tested them
16:00:13 *** MinchinWeb_ has joined #openttd.dev
17:37:03 *** MinchinWeb has joined #openttd.dev
18:04:28 *** Alberth has left #openttd.dev
18:19:51 *** Sturmi has joined #openttd.dev
18:42:33 *** andythenorth has joined #openttd.dev
18:42:33 *** ChanServ sets mode: +v andythenorth
18:50:10 *** andythenorth has joined #openttd.dev
18:50:10 *** ChanServ sets mode: +v andythenorth
19:27:26 *** Belugas has joined #openttd.dev
19:27:26 *** ChanServ sets mode: +v Belugas
19:38:55 *** Supercheese has joined #openttd.dev
19:47:27 *** andythenorth has joined #openttd.dev
19:47:27 *** ChanServ sets mode: +v andythenorth
20:07:23 *** fonsinchen has joined #openttd.dev
20:07:24 *** ChanServ sets mode: +v fonsinchen
21:37:14 *** andythenorth has left #openttd.dev
21:41:03 *** Belugas has joined #openttd.dev
21:41:03 *** ChanServ sets mode: +v Belugas
22:22:28 *** Sturmi has joined #openttd.dev
continue to next day ⏵