IRC logs for #openttd.dev on OFTC at 2012-11-01
⏴ go to previous day
00:16:14 *** Supercheese has joined #openttd.dev
01:12:54 *** Knogle has joined #openttd.dev
03:27:22 *** Knogle has joined #openttd.dev
03:27:22 *** Supercheese has joined #openttd.dev
03:27:22 *** welshdragon has joined #openttd.dev
03:27:22 *** Belugas has joined #openttd.dev
03:27:22 *** SmatZ has joined #openttd.dev
03:27:22 *** Terkhen has joined #openttd.dev
03:27:22 *** Yexo has joined #openttd.dev
03:27:22 *** reticulum.oftc.net sets mode: +vvvv Belugas SmatZ Terkhen Yexo
03:27:22 *** michi_cc has joined #openttd.dev
03:27:22 *** orudge has joined #openttd.dev
03:27:22 *** reticulum.oftc.net sets mode: +vv michi_cc orudge
10:08:48 *** frosch123 has joined #openttd.dev
10:08:48 *** ChanServ sets mode: +v frosch123
14:01:25 *** LordAro has joined #openttd.dev
14:01:25 *** ChanServ sets mode: +v LordAro
15:26:44 *** FLHerne has joined #openttd.dev
16:01:14 *** Alberth has joined #openttd.dev
16:01:14 *** ChanServ sets mode: +v Alberth
17:33:15 *** Zuu has joined #openttd.dev
17:46:23 *** Knogle has joined #openttd.dev
19:16:05 *** andythenorth has joined #openttd.dev
19:16:05 *** ChanServ sets mode: +v andythenorth
21:19:23 *** Supercheese has joined #openttd.dev
22:08:58 *** Alberth has left #openttd.dev
22:14:39 <frosch123> hmm, naming is hard
22:14:52 <frosch123> we have IsCompanyBuildableVehicleType, which does something similar, but different :s
22:15:14 <LordAro> name looks fine to me (irrelevant opinion)
22:15:36 <frosch123> maybe IsVehicleTypeDisabled?
22:15:47 <frosch123> that could also check for ais, whether they may build such vehicles
22:16:05 <frosch123> (those ai vehicle type settings to disallow them building rv or rail and such)
22:16:08 <Yexo> so it'd need an extra parameter "bool ai"?
22:19:09 <Terkhen> I can' think of a better name for that function
22:20:17 *** andythenorth has left #openttd.dev
22:22:02 <frosch123> i like some name containing "disabled" more
22:22:15 <Yexo> also contains a proper check for AI companies
22:23:32 <Yexo> updated, now also compiles
22:24:22 <planetmaker> I think it should say in the comment "...introduction dialogue"
22:24:27 <planetmaker> (not introducing)
22:24:55 <frosch123> well, technically it is a preview dialog :)
22:25:00 <frosch123> not the introduction news
22:25:19 <planetmaker> ok. so preview dialogue :-)
22:25:25 <Yexo> changed to "preview dialog"
22:25:28 <planetmaker> or preview test dialogue
22:26:18 <planetmaker> looks fine to me otherwise
22:26:19 <frosch123> the spelling "dialogue" frightens me :p
22:26:24 <planetmaker> and I like the idea much
22:26:42 <planetmaker> but... it's correct?
22:26:53 <LordAro> frosch123: it frightens most people ;)
22:27:19 <frosch123> planetmaker: yeah, ottd settles for be
22:27:40 <planetmaker> tbh, I didn't notice the discrepancy there nor wanted to mention that s/dialog/dialogue/ needs be done :-)
22:27:57 <frosch123> but since dialog is a common term in various programming languages, and all of them use ae; dialogue really looks weird to me :)
22:28:18 <frosch123> anyway, diff looks fine
22:29:27 <frosch123> ais will still get previews, but skipping ais for previews feels incorrect, since bad-performing human companies would be offered the engine earlier
22:29:51 <Yexo> ^^ my reasoning exactly :)
22:30:57 <frosch123> though you can add the condition in front of
22:31:03 <frosch123> AI::NewEvent(best_company, new ScriptEventEnginePreview(i));
22:31:19 <frosch123> then ais won't notice that they have the preview
22:33:55 <Yexo> updated with that change and a comment there to explain it
22:34:35 <frosch123> are you sure that compiles? :)
22:57:57 *** FLHerne has joined #openttd.dev
23:07:50 <Yexo> devs.openttd.org/~yexo/BuildAndroid.sh
23:08:02 <Yexo> ^^ for anyone interested, will probably not continue much work on that in the short-term
23:09:31 <Yexo> several changes also appear in the android patch on FS, so I think it's safe to say those should be included no matter what
continue to next day ⏵