IRC logs for #opendune on OFTC at 2011-08-31
⏴ go to previous day
01:30:36 *** fjb is now known as Guest7920
09:04:14 *** fjb is now known as Guest7966
09:07:08 *** Xaroth has joined #openDune
10:13:51 <DorpsGek> SVN: truebrain (r2490) -Codechange: langStringID is a STR_ enum too
10:14:19 <DorpsGek> SVN: truebrain (r2491) -Codechange: replace some 0 for STR_NULL
10:22:56 <DorpsGek> SVN: truebrain (r2492) -Codechange: replace magic values with ACTION_ enum where required
10:26:58 <DorpsGek> SVN: truebrain (r2493) -Codechange: replace magic numbers with ICM_ICONGROUP enum where appropiate
10:31:45 <DorpsGek> SVN: truebrain (r2494) -Codechange: remove unused fields from FileInfo
11:17:31 <DorpsGek> SVN: truebrain (r2495) -Codechange: SelectionType variable_0[46] are bools (glx)
11:36:25 *** fjb is now known as Guest7978
11:48:09 <DorpsGek> SVN: truebrain (r2496) -Add: introducing SelectionType, an enum to name the magic numbers surrounding SelectionTypes
11:50:28 <DorpsGek> SVN: truebrain (r2497) -Codechange: more removing of magic stringIDs
11:51:59 <DorpsGek> SVN: truebrain (r2498) -Codechange: resolved some more magic numbers related to selectionTypes
11:55:44 <DorpsGek> SVN: truebrain (r2499) -Codechange: having full names for variables but ?? as doxygen comment is silly
11:58:56 <DorpsGek> SVN: truebrain (r2500) -Codechange: remove unused WSA related flags
11:59:03 * TrueBrain parties for revision 2500
11:59:24 <DorpsGek> SVN: truebrain (r2501) -Codechange: missing doxygen comment
12:26:19 *** Xaroth has joined #openDune
12:29:27 <DorpsGek> SVN: truebrain (r2502) -Add: named two variables
12:47:17 <TrueBrain> glx: today again I found clear code that indicates there was an ingame scenario editor
12:47:20 <TrueBrain> also posted it on the forum
12:47:26 <TrueBrain> as I can't find if the real code is there ...
12:47:38 <TrueBrain> from SelectionType I know that widget 12 .. 17 are part of this
12:47:57 <TrueBrain> but I can't find if they are defined anywhere in the code (even if it is hidden)
12:48:11 <TrueBrain> I looked in all other executables I have, but I can't find anything about it; you any ideas?
12:48:29 <TrueBrain> yeah, it is not decompiled for sure :)
12:48:51 <TrueBrain> I wonder if we can make an overview of which parts of Dune2.exe we have decompiled, and which might still contain code ...
12:49:24 <TrueBrain> but maybe you can poke around a bit ...
12:49:28 <TrueBrain> table/selectiontype.c
12:49:37 <TrueBrain> are debugs, where 5 is the scenario editor
12:50:20 <planetmaker> so the SE which was never shipped?
12:50:20 <glx> I should be able to find stuff in the exe, if I know what to search :)
12:50:43 <glx> planetmaker: knowing dune2, it should be in the exe but disabled
12:50:54 <TrueBrain> planetmaker: all over the place we find references to the editor
12:50:57 <glx> dune2.exe is full of dead code
12:51:01 <TrueBrain> if statements, parts of structs
12:51:08 <TrueBrain> but if we enable the editor, nothing shows up
12:51:09 <Xaroth|Work> for those who missed it
12:51:22 <planetmaker> oh... well, you'll figure it out :-)
12:51:38 <TrueBrain> planetmaker: well, I can't find any image or reference online about such editor
12:51:42 <TrueBrain> so I am not sure if it ever got published
12:53:02 <TrueBrain> which in fact is what I try to figure out ... is it in the binary, or did they remove that part (which would be weird given the rest of the shit that is there)
12:56:56 <planetmaker> TrueBrain: I never remember having heart of it or seen it either
12:57:09 <planetmaker> Maybe just for their own development things
12:57:15 <planetmaker> and left in - as usual
12:57:25 <TrueBrain> but then I still wonder: is the editor itself also in there
12:57:32 <TrueBrain> and if not, why remove only that part?
12:59:52 <planetmaker> maybe it was a separate module and saved a lot compile time?
13:00:14 <planetmaker> like ./configure --without-se --without-network --without-bullshit --enable-static --enable-money
13:02:59 <planetmaker> do you know how their build system looked like?
13:03:15 <planetmaker> and which #ifdef they had in the code?
13:06:44 <TrueBrain> I doubt they had a build system ;)
13:06:54 <TrueBrain> IDEs were mostly non-existing back then
13:07:08 <TrueBrain> and as it was designed on DOS, I am also sure there was no configure :P
13:07:19 <TrueBrain> but #ifdefs would be possible, just why didn't they #ifdef more? Why so selective?
13:07:24 <TrueBrain> which makes me wonder if they did ;)
13:08:08 <glx> if only I could find from where it is called
13:10:07 <TrueBrain> in table/selectiontype.c (from 2E6B:0) there is a table with default widgets
13:10:12 <TrueBrain> euh, table/widgetinfo.c
13:10:26 <TrueBrain> table/selectiontype.c suggests widget 12 .. 18 should also be in there
13:12:24 <TrueBrain> and it would make sense we can't find an other entry, as those widgets alone can be all the entries you need
13:14:30 <TrueBrain> ranges are btw: 12 - 17 + 26 - 29 for one editor and 18 - 28 for the other
13:14:32 <TrueBrain> there is overlap there
13:14:46 <TrueBrain> also, 16 and 17 are defined for mentat too, which also suggests some kind of reusage
13:15:18 <glx> maybe extra widgets are added manually
17:31:20 <TrueBrain> right, enough toying around with movies :D
17:35:15 <TrueBrain> so how, if, are we going to find out of this SE is in the executable ....
17:36:38 <TrueBrain> no clue why that happened
17:39:18 <TrueBrain> I once did write a script that detect holes in our TXT files
17:39:28 <TrueBrain> but ... isolating them one by one will be SLOW
17:44:12 <TrueBrain> looking over the strings, I have to conclude there are no editor related strings
17:44:19 <TrueBrain> but of course they could have used hardcoded strings
17:46:42 <TrueBrain> meh; I guess we just have to conclude there is no such things :(
18:07:09 <DorpsGek> SVN: truebrain (r2503) -Codechange: we now know what fields in profile.ini/combat mean what
18:09:50 <DorpsGek> SVN: truebrain (r2504) -Codechange: keep a comment up-to-date
18:18:55 <DorpsGek> SVN: truebrain (r2505) -Codechange: named some stuff, made some other stuff more pretty
18:37:26 <DorpsGek> SVN: truebrain (r2506) -Add: named all HouseAnimation variables
18:47:58 <DorpsGek> SVN: truebrain (r2507) -Fix (r2506): also update comments
18:57:35 <DorpsGek> SVN: truebrain (r2508) -Add: named last variables in Widget and removed unneeded variables where possible
19:00:53 <DorpsGek> SVN: truebrain (r2509) -Add: some final variable_ entries named or removed
19:00:58 <TrueBrain> right ... I am kinda out of variable_ entries now :P
19:03:42 <DorpsGek> SVN: truebrain (r2510) -Add: named another Unit function
19:09:40 <DorpsGek> SVN: truebrain (r2511) -Add: moar random naming
19:15:44 <DorpsGek> SVN: truebrain (r2512) -Add: named another Unit Script function
19:15:53 <TrueBrain> there are like 6 functions left to name in scripts ... and 1 in opendune.c
19:15:55 <TrueBrain> I think I have the rest
19:15:57 <TrueBrain> including variables
19:16:04 <TrueBrain> my searches at least come back dry
19:16:11 <TrueBrain> so it seems we are 99% done with naming :D:D:D:D:D
continue to next day ⏵