IRC logs for #opendune on OFTC at 2011-07-02
⏴ go to previous day
07:34:34 *** Alberth has joined #openDune
07:34:34 *** ChanServ sets mode: +o Alberth
08:40:29 <Alberth> TrueBrain: any non-zero chance of getting the semantics of variables you added, documented?
08:40:36 <Alberth> I would really like that
09:45:03 <TrueBrain> I love how you talk in riddles, but I have no idea what you mean :D
09:51:53 <TrueBrain> Alberth: in generally, seriously, please ask more to the point :) I have a hard time trying to figure out what you mean :) Just be concrete, example or something :) 'variables you added' .. I have no clue :) Tnx ;)
09:53:18 <Alberth> src/gui/widget.c contains a lot of global variables without any form of documentation, but with a name, so you know what they mean
09:53:48 <TrueBrain> ugh, most are temp names, or too-obvious-to-comment :P
09:54:10 <TrueBrain> why you want those documented?
09:55:35 <Alberth> a description is more than a single word. You get a second description that is easier to get the idea across
09:56:19 <TrueBrain> ah; well, most of those vars I guessed, and some are obvious wrong
09:56:24 <Alberth> eg I know what I mean with WidgetProperties, but my idea may be way off w.r.t. your idea of it. The text can unify that more easily
09:57:10 <TrueBrain> but in the future I will try to remember to doxygen comment vars a bit more
09:57:16 <Alberth> and trivial stuff is by definition also trivial to describe :p
09:57:41 <TrueBrain> WidgetLinkedListTail - the tail of the linked list of widgets
09:57:49 <TrueBrain> I hate those descriptions, really :) As they do not add any value
09:57:57 <TrueBrain> but meh, will try to remember to add them when I make them
09:58:52 <Alberth> a higher level description would be nice, of course, eg what linked list could be interesting to explain
09:59:03 <TrueBrain> and that requires knowing that :D
09:59:04 <Alberth> but it may not always be known
09:59:35 <TrueBrain> but yeah, please tell me when I forget doxygens, as I will forget it often ;)
09:59:40 <Alberth> guessing would be fine too, otherwise we'll never get any progress
09:59:41 <TrueBrain> just remind me, and I will try to add them :)
10:00:50 <Alberth> the trouble with them is that they are boring to do, so if you wait until you have a bunch, it is really dumb work and you get low quality comments
10:01:51 <Alberth> you got stuck with the conversion, or were you distracted by real life?
10:02:29 <TrueBrain> I only name variables at the last moment, so it is dumb work at any stage for me :D
10:04:02 <Alberth> the global data contains way too many variables, even just moving them is boring
10:04:53 <TrueBrain> that is why you do a few of them, and then some other stuff , hence and repeat :D
10:05:23 <Alberth> currently converting variable_4062[22][8] to an array of struct
10:06:18 <Alberth> and then you find interesting stuff like variable_4062[21 + arg06] :)
10:07:43 <Alberth> uint16, but only called with literal value 0
10:11:01 <TrueBrain> that happens a lot btw ... that all vars are called with same value
10:11:08 <TrueBrain> if I can't figure out the meaning, or don't like it, I just remove it ...
10:11:17 <TrueBrain> WSA had 3 extra parameters that were never used ... byebye! :P
10:12:32 <Alberth> it was on my list already :)
11:42:22 <DorpsGek> SVN: alberth (r2003) -Add: Remove variable_4062 from global data.
12:03:02 <Alberth> is there a list of texts with index number somewhere?
13:08:08 *** ChanServ sets mode: +v Yexo
17:46:16 <Alberth> note that I still have to merge src/unknown/emu_07AE.c to src/gui/widget.c
18:48:24 <Alberth> 'current' or 'active' ? :)
19:06:59 <DorpsGek> SVN: alberth (r2004) -Add: Added the 'current widget' concept for removing globals 6D59 6D5B 6D5D 992B 992D 992F 9931. Also, byebye unknown/emu_07AE.c
19:18:13 <glx> Alberth: alphabetic order is strange on your PC
19:18:52 <glx> dot should be before underscore
19:18:52 <Alberth> it's 'ls' order, isn't it?
19:22:09 <Alberth> I briefly looked whether I could fix it with some sort option for ls, but I didn't find one
19:22:32 <Alberth> VS doesn't like the order?
19:24:09 <Alberth> ls u* | sort <-- even that gives u_ and then u.
19:26:58 * Alberth blames the intelligent 'human readable' sort extensions used nowadays
19:56:29 <glx> yeah I hate "intelligent" sorting when my files have hex numbers
20:56:21 *** Tomaz^ has joined #openDune
continue to next day ⏵