IRC logs for #opendune on OFTC at 2011-06-28
⏴ go to previous day
09:55:06 *** ChanServ sets mode: +o Xaroth|Work
09:57:11 *** Xaroth|Work sets mode: +o TrueBrain
09:57:21 <Xaroth|Work> DorpsGek doesn't want to listen :P
12:19:45 *** TrueBrain has joined #openDune
12:50:48 <Xaroth|Work> HAPPY CAPS-LOCK DAY!
12:54:29 *** ChanServ sets mode: +v Xaroth|Work
18:22:47 *** Alberth has joined #openDune
18:22:47 *** ChanServ sets mode: +o Alberth
20:21:26 <DorpsGek> SVN: alberth (r1996) -Add: Removed several unused global variables.
20:23:00 <Alberth> for people loving a puzzle: memcpy(g_global->variable_81C6, g_global->variable_81BA, 12); is crucial to the animation of the arrows on scenario selection, despite never reading 81C6.
20:23:23 <TrueBrain> mapped over another pointer? :D
20:23:43 <TrueBrain> I ahd that issue with palette animation of Hall Of Fame
20:23:52 <TrueBrain> 1 pointer mapped to a position in the palette to do the animation in
20:24:16 <Alberth> something like that :)
20:27:30 <Alberth> one problem with removing unused variables is that more used variables remain to be done :p
20:32:06 * Alberth finds loads of undocumented global/static variables in gui.c :(
20:40:09 <glx> memcpy(g_palette1 + 251 * 3, g_global->variable_81BA + g_global->variable_2B10 * 3, 4 * 3); <-- that's arrow animation
20:42:55 <glx> so of course the memcpy is vital :)
20:43:08 <Alberth> yeah, I was reading that code too, but the last 3 bytes are not used thus :)
20:43:35 <glx> and it's easier to just copy the whole stuff
20:43:49 <Alberth> otherwise you'd have to compute the size, probably
20:44:42 <Alberth> ie 4*3 becomes 3*3 for the last case
20:46:53 <glx> yes the memcpy could copy only 9 bytes
20:47:09 <glx> but 12 is a better for aligning ;)
20:49:45 <Alberth> I doubt that mattered in those days :p
20:57:57 <Alberth> use of variable_2B0C at lines 2982 and lines 2994 is also wrong :p the while loop never waits
21:00:40 <DorpsGek> SVN: alberth (r1997) -Add: Removed global variables 2B10 and 81B6.
21:01:49 *** Xaroth has joined #openDune
21:01:49 *** ChanServ sets mode: +o Xaroth
21:15:11 <DorpsGek> SVN: alberth (r1998) -Fix: Global variable 81C6 == 81BA + 0C.
21:31:49 *** Xaroth has joined #openDune
21:31:49 *** ChanServ sets mode: +o Xaroth
21:44:08 *** Xaroth_ has joined #openDune
21:52:04 *** Xaroth has joined #openDune
21:52:04 *** ChanServ sets mode: +o Xaroth
22:05:33 *** Xaroth_ has joined #openDune
22:48:48 *** Xaroth has joined #openDune
22:48:48 *** ChanServ sets mode: +o Xaroth
continue to next day ⏵