IRC logs for #opendune on OFTC at 2011-06-13
⏴ go to previous day
01:14:49 *** fjb is now known as Guest4401
06:53:43 *** Alberth has joined #openDune
07:32:21 * Alberth ponders what to do with the patch queue
08:51:01 <Xaroth> Test, Verify, Commit? :P
08:57:24 <Alberth> verify seems to be a problem atm
08:57:33 <Alberth> everybody is too busy
12:49:08 <Alberth> mostly, the forum is still on vacation :)
12:52:00 <TrueBrain> in the same timeframe as openttd was down
12:52:36 <TrueBrain> that is how I read it :)
12:54:25 <glx> Alberth: so you said there was a bug somewhere ?
12:55:02 <Alberth> (20:14:47) Alberth: let's try to find the graphic glitch in trunk :)
12:55:02 <Alberth> (22:18:40) Alberth: r1629 introduced the arrow glitch in the region selection map
12:55:11 <Alberth> is what I said yesterday
12:55:29 <glx> lazy to search in the logs
12:56:14 <glx> I think I fixed it already
12:57:15 <Alberth> not at my machine, yesterday
12:57:33 <glx> I fixed something in GUI_Mouse_Hide or show
12:57:52 <Alberth> yeah, the GUI_*_safe() were different from that revision
12:58:18 <Alberth> so perhaps it is a OS-specific issue
12:58:56 <Alberth> do you have plans to look at my patch queue ?
12:59:04 <glx> show and hide inverted cs and ip in copy[From|To]Buffer calls
13:00:32 <TrueBrain> Alberth: in History_Clear, is the cli() required?
13:01:36 <Alberth> history* vars are modified in the interrupt handlers
13:02:26 <TrueBrain> but interrupts can not hit inside that function
13:02:35 <TrueBrain> so does it do anything?
13:03:35 <TrueBrain> 16_, can you make that label go away? I really dislike labels :D
13:03:52 <Alberth> I don't know, you are much better informed about the underlying engine.
13:04:10 <TrueBrain> well, cli holds out interrupts, not?
13:04:42 * Alberth thinks that's what cli does
13:04:57 <Alberth> I can copy those 3 lines to remove the label
13:05:04 <TrueBrain> there is no way that an interrupt can hit in that function, because of the way we do interrupts
13:05:19 <glx> External interrupts are not recognized at the end of the CLI instruction or from that point on until the interrupt flag is set.
13:05:28 <TrueBrain> for example in 20_, cli() is needed, as it calls some functions that might cause interrupt calls
13:05:50 <TrueBrain> although it hsould work if you put them only around File_ I guess :)
13:06:00 <TrueBrain> the reason I start about it, is that I want as few emu_ calls as possible :D
13:06:11 <TrueBrain> then again, we can keep it and clean it later :p
13:08:32 <Alberth> in history clear, the pushf/popf are then also not needed, right?
13:08:52 <TrueBrain> if the cli is not needed, yes
13:08:56 <TrueBrain> which is why I started about it :D
13:08:58 <glx> if there's no emu_cmp or things like that
13:09:16 <TrueBrain> but okay, I see you left them in many other cases
13:09:26 <TrueBrain> so I guess we can remove them later
13:09:47 <TrueBrain> Alberth: and this all works?
13:10:10 <Alberth> it did at my machine, before the modifications I just did :p
13:10:54 <Alberth> it is about 3 weekends of work, I think :)
13:11:57 <Alberth> I have left the top-level things with dos interrupts in the original files
13:15:21 <Alberth> also removed the emu_{popf,pushf,cli} from 10
14:00:43 <Alberth> is someone doing tests, or planing to do them?
14:04:05 <TrueBrain> just commit them one by one
14:04:14 <TrueBrain> and we will get feedback sooner or later :D
14:04:25 <Alberth> probably sooner than later :D
14:07:55 <glx> if you say it works it's enough for me :)
14:22:17 <DorpsGek> SVN: alberth (r1760) -Add: Give several Input functions a name.
14:23:59 <DorpsGek> SVN: alberth (r1761) -Add: C-ified Input_History_Clear.
14:24:59 <DorpsGek> SVN: alberth (r1762) -Add: C-ified Input_ReadHistory.
14:25:54 <DorpsGek> SVN: alberth (r1763) -Add: C-ified Input_Keyboard_Translate.
14:26:16 <DorpsGek> SVN: alberth (r1764) -Add: C-ified Input_History_Add.
14:26:34 <DorpsGek> SVN: alberth (r1765) -Add: C-ified Input_AddHistory.
14:27:28 <DorpsGek> SVN: alberth (r1766) -Add: C-ified Mouse_CheckButtons.
14:27:45 <DorpsGek> SVN: alberth (r1767) -Add: C-ified Mouse_CheckMovement.
14:28:25 <DorpsGek> SVN: alberth (r1768) -Add: C-ified Input_HandleInput.
14:28:42 <DorpsGek> SVN: alberth (r1769) -Add: C-ified Input_HandleMovement.
14:31:36 <DorpsGek> SVN: alberth (r1770) -Add: Refactored emu_Mouse_EventHandler.
14:32:22 <DorpsGek> SVN: alberth (r1771) -Add: C-ified Mouse_HandleMovementIfMoved.
14:33:08 <DorpsGek> SVN: alberth (r1772) -Add: C-ified Input_ReadInputFromFile.
14:33:31 <DorpsGek> SVN: alberth (r1773) -Add: C-ified Input_IsInputAvailable.
14:34:00 <DorpsGek> SVN: alberth (r1774) -Add: C-ified Input_Wait.
14:34:15 <DorpsGek> SVN: alberth (r1775) -Add: C-ified Input_Test.
14:34:50 <DorpsGek> SVN: alberth (r1776) -Add: C-ified Mouse_InsideRegion.
14:35:17 <DorpsGek> SVN: alberth (r1777) -Add: C-ified Input_Keyboard_HandleKeys.
14:35:33 <DorpsGek> SVN: alberth (r1778) -Add: C-ified Input_WaitForValidInput.
14:35:53 <DorpsGek> SVN: alberth (r1779) -Add: C-ified Input_Keyboard_NextKey.
14:37:56 <Alberth> revision count matches, so this is it :)
14:39:19 <DorpsGek> SVN: truebrain (r1780) -Fix: clean up function_names.txt
14:40:09 <DorpsGek> SVN: truebrain (r1781) -Add: remove unused emu_ functions
14:40:23 <TrueBrain> 89% converted, 93% named
14:40:38 <TrueBrain> most is in sound drivers
15:02:28 * glx is removing stuff from g_global
15:42:39 <glx> grr someone forgot something again ;)
15:45:33 <TrueBrain> ugh, do it yourself :D
15:45:36 <TrueBrain> stupid windows users
15:45:47 <DorpsGek> SVN: truebrain (r1782) -Fix (r1781): stupid windows users
15:49:05 <glx> btw trunk doesn't compile for me ;)
16:08:58 <glx> variable names conflicting with type names
16:11:16 <DorpsGek> SVN: glx (r1783) -Fix: MSVC errors and warnings
16:11:19 <TrueBrain> trying to see if we can attach the buildbot to OpenDUNE too
16:15:20 <glx> ouch, runtime check failure
16:15:43 <glx> The variable 'saveSize' is being used without being initialized.
16:21:47 <DorpsGek> SVN: glx (r1784) -Fix (r1768): uninitialised variable
16:21:58 <glx> and no compiler warned about it
16:33:14 <DorpsGek> SVN: glx (r1785) -Add: removed some g_global variables
16:42:41 <Alberth> saveSize is a false positive
16:43:22 <glx> it's a real uninitialised one
16:43:51 <glx> I got a runtime check failure on it
16:45:47 <Alberth> saveSize += 2; is a non-interesting calculation in that case, FileWrite() is the only real use, which can only be reached if g_global->mouseMode == 1, in which case the var is initialized to 4
16:46:13 <glx> right but the += is still done :)
16:48:34 <glx> oh and we have an enum for mouseMode ;)
17:18:30 <DorpsGek> SVN: alberth (r1786) -Codechange: Use enum constants for mouseMode.
18:19:30 *** Osai^2 has joined #openDune
19:11:42 <DorpsGek> SVN: alberth (r1787) -Add: Remove use of emulator registers in getting the icon.
19:25:07 <DorpsGek> SVN: alberth (r1788) -Fix (r1067): Random generator is also used for fremen orientation.
continue to next day ⏵