IRC Logs | #opendune

00:52:29 <DorpsGek> SVN: glx (r1684) -Add: C-ified GUI_HallOfFame_DrawBackground()

01:22:30 *** fjb has quit IRC

01:28:29 <DorpsGek> SVN: glx (r1685) -Add: C-ified GUI_HallOfFame_GetRand(), GUI_HallOfFame_DrawRank() and GUI_EndStats_Sleep(). This ends B518.

01:45:12 <DorpsGek> SVN: glx (r1686) -Cleanup: remove useless statements and uneeded declarations

01:47:43 *** fjb has joined #openDune

02:28:29 *** glx has quit IRC

12:14:07 *** glx has joined #openDune

12:14:07 *** ChanServ sets mode: +o glx

12:16:02 <glx> hello

12:23:41 <TrueBrain> 72% :D

12:23:59 <glx> now I'll try to remove overlay related code

12:24:31 <TrueBrain> overlay no longer used?

12:24:43 <glx> at least not in src

12:25:05 <TrueBrain> and in decompiled?

12:25:16 <TrueBrain> (and that is fucking epic :D)

12:25:39 <glx> there are still in decompiled

12:25:43 <Xaroth|Work> :o

12:25:50 <Xaroth|Work> going fast!

12:26:12 <glx> but B53X are used by overlay code IIRC

12:27:21 <glx> 1 in 01F7, 1 in 23E1 and 1 in 261F

12:27:42 <glx> 01F7 and 23E1 are calls to converted functions

12:27:54 <glx> Main and PrepareEnd

12:28:22 <glx> 261F is the overlay interrupt

12:28:43 <TrueBrain> so try it :D

12:48:56 <DorpsGek> SVN: glx (r1687) -Cleanup: bye bye overlay() and it's callees

12:49:24 <glx> hmm ' should not be there

12:51:33 <glx> \o/ Tools_Malloc() and Tools_Free() are only in src \o/

12:59:12 <TrueBrain> :D:D:D:D

12:59:14 <TrueBrain> NICE!!

12:59:19 <TrueBrain> this also removes all overlay stuff?

12:59:25 <TrueBrain> as in: decompiled/BNNN

12:59:29 <glx> yup

12:59:54 <glx> doing some cleanup now

13:08:16 <TrueBrain> awesome :D

13:08:33 <TrueBrain> 73% done .. I expected more from such commit tbh :p

13:37:54 <DorpsGek> SVN: glx (r1688) -Cleanup: remove useless emu_ wrappers

13:40:27 <TrueBrain> still 330 functions to go, it says :)

13:42:46 <glx> maybe you can run your unused function detector

13:44:00 <TrueBrain> sure

13:44:32 <TrueBrain> not that many

13:44:46 <TrueBrain> src/unknown/emu_B53B.c: emu_Unknown_B53B_0000 no longer used

13:44:47 <TrueBrain> src/unknown/emu_07AE.c: emu_Unknown_07AE_0000 no longer used

13:44:49 <TrueBrain> src/unknown/emu_07AE.c: emu_Unknown_07AE_00E4 no longer used

13:44:50 <TrueBrain> src/unknown/emu_07AE.c: emu_Unknown_07AE_0103 no longer used

13:44:52 <TrueBrain> src/unknown/emu_252E.c: emu_Screen_GetSegment_ByIndex_1 no longer used

13:44:53 <TrueBrain> src/unknown/emu_252E.c: emu_Screen_GetSegment_ByIndex_2 no longer used

13:44:55 <TrueBrain> src/unknown/emu_2903.c: emu_Unknown_2903_00CA no longer used

13:44:56 <TrueBrain> src/unknown/emu_07D4.c: emu_Unknown_07D4_0000 no longer used

13:44:58 <TrueBrain> src/unknown/emu_07D4.c: emu_Unknown_07D4_159A no longer used

13:44:59 <TrueBrain> src/unknown/emu_07D4.c: emu_Unknown_07D4_02F8 no longer used

13:45:01 <TrueBrain> src/unknown/emu_B4B8.c: emu_Unknown_B4B8_110D no longer used

13:45:02 <TrueBrain> src/unknown/emu_259E.c: emu_Unknown_259E_0006 no longer used

13:45:04 <TrueBrain> and MPU, Drivers and the likes

13:45:33 <glx> hmm does it check if they are used in decompiled ?

13:45:44 <TrueBrain> possible

13:47:27 <glx> emu_Unknown_07D4_0000() is used for me

13:48:00 <glx> 159A too

13:54:57 <TrueBrain> yeah, I Think it makes the assumption emu_ is only used in decompiled/

13:55:03 <TrueBrain> euh, no, it doesn't .. euh ..

13:55:08 <TrueBrain> there were some corner cases anyway :)

13:55:13 <TrueBrain> but the rest is all okay, it says

14:47:50 <DorpsGek> SVN: glx (r1689) -Cleanup: removed useless wrappers, and C-ified all functions in unknown

15:03:17 <TrueBrain> only sound shit warnings left from my scripts :D

15:05:14 <glx> I guess next step will be to remove csip32 args

15:05:27 <TrueBrain> where possible, yes

15:05:41 <TrueBrain> can;t you remove 217E?

15:06:12 <glx> called from 01F7

15:08:33 * glx follows calls from emu_EntryPoint

15:09:06 <TrueBrain> k, I am trying something here ....

15:09:08 <TrueBrain> should work, I hope :D

15:10:29 <TrueBrain> ugh, no ...

15:10:30 <TrueBrain> it is mangled

15:10:48 <TrueBrain> removing the overlay won't be easy :p

15:10:58 * glx tried replacing emu_EntryPoint hardjump

15:11:05 <glx> :)

15:11:07 <glx> failed

15:19:36 <glx> after resolving some jumps: Insufficient memory by 594000 bytes.

15:19:58 <glx> so emu_EntryPoint does useful things

15:25:25 <TrueBrain> yeah, overlay stuff too .. meh ...

15:53:40 <glx> maybe Unknown_1DB6_0004() needs a diet

15:54:21 <glx> seems it installs interrupt 3F handler

16:25:14 <glx> hmm when running trunk in my ubuntu VM I get segfault

16:27:26 <TrueBrain> same here

16:27:38 <glx> in loadvoices ?

16:27:54 <TrueBrain> #0 0x080bf3b4 in Voice_LoadVoices (voiceSet=1) at src/sound.c:309

16:27:55 <TrueBrain> #1 0x080ae53f in Game_Prepare () at src/opendune.c:3097

16:27:57 <TrueBrain> #2 0x080a87d2 in LoadFile (

16:27:58 <TrueBrain> filename=0x81d2840 "FHJKMNPQSUVWYZ]ak\203\264\346\367\366\366\366\365\365\365\365\364\364\363\363\363\362\362\357\332\252qA237=Kl\242\325\362\362\361\361\360\360\357\357\355\354\353\351\347\345\344\341\337\336\333\331\330\325\323\322\320\316\314\313\310\307\305\303\302\300\275\262\231h3!\"", '#' <repeats 21 times>, "&(*,.02468:<=?ACDGLYt\250\335\366\365\364\364\364\363\363\363\362\362\361\361\360\357\355\353\351\343\325\266\202K$\"#$,>f\235\320\355\

16:28:00 <TrueBrain> 356\354\352\351\347\344\343\341\336\335\333\331\327\326\323\321\320\316\314\313\311\276\234h2!#########"...) at src/load.c:272

16:28:01 <TrueBrain> #3 0x080a2dfd in GUI_Widget_SaveLoad_Click (save=0 '\000')

16:28:21 <glx> voiceset is 0xFFFF for me

16:29:02 <TrueBrain> something is wrong ;)

16:29:37 <TrueBrain> can't really trace it atm :(

16:33:32 <glx> btw it warns about vsnprintf when compiling

16:35:03 <TrueBrain> yup

16:35:06 <TrueBrain> ignored it for a LONG time :D

16:36:27 <TrueBrain> 309 char *str = (char *)emu_get_memorycsip(g_global->voices[voice].string);

16:36:29 <TrueBrain> (gdb) bt

16:36:30 <TrueBrain> #0 0x080bf3b4 in Voice_LoadVoices (voiceSet=5) at src/sound.c:309

16:36:39 <TrueBrain> #1 0x080b32ac in Gameloop_IntroMenu () at src/opendune.c:2268

16:36:39 <TrueBrain> another trace (newgame)

16:37:07 <glx> that's what I get when just launching opendune

16:37:19 <glx> hmm ha no it's different

16:37:20 <TrueBrain> buffer overflow of some kind

16:47:24 <glx> r1674 is ok

17:11:48 <glx> seems to be r1688

17:51:14 <glx> hmm weird g_global doesn't seem to point to the right memory

19:34:17 <glx> ok the problem is emu_b483.c:173

19:34:55 <glx> calling emu_get_memorycsip() on XMS doesn't work very well

20:26:27 *** Xaroth|W1rk has joined #openDune

20:26:46 *** Xaroth|Work has quit IRC

20:37:28 <DorpsGek> SVN: glx (r1690) -Fix (r1688): emu_get_memorycsip() doesn't work for memory allocated in XMS

20:54:47 <TrueBrain> haha

20:54:51 <TrueBrain> nice one glx :)

20:54:55 <TrueBrain> we should go to non16bit memory soon :)

20:55:11 <glx> there's a bug in r1645 too

20:55:30 <glx> intro is full of explosions

20:55:44 <glx> (instead usual speak)

20:56:18 <glx> btw I added an assert in emu_get_memory_csip :)

20:58:19 <TrueBrain> yeah; smart

21:02:57 *** TinoDid|znc has joined #openDune

21:04:21 *** TinoDidriksen has quit IRC

21:04:21 *** TinoDid|znc is now known as TinoDidriksen

21:11:42 <glx> ok all voices play blowup2.voc

21:11:51 <TrueBrain> :D

21:11:53 <glx> (rhe latest in the list

21:11:58 <glx> *the

21:12:10 <glx> so all voices are loaded at the same place

21:12:17 <glx> looks like allocation is bugged

21:14:06 <glx> or memmove

21:44:20 <glx> I see nothing obvious in the diff :(

21:53:59 <glx> allocation seems right

22:14:01 <glx> hmm count = 353F7B86, that is very strange :)

22:33:53 <glx> hmm a memmove fails (INVALID SOURCE OFFSET)

22:34:05 <glx> this never happened before

22:56:35 <glx> lol I think I found it

23:09:04 <DorpsGek> SVN: glx (r1691) -Fix (r1645): wrong values passed to XMS handler

23:09:13 <glx> it was too obvious :)

continue to next day ⏵