IRC logs for #opendune on OFTC at 2011-02-26
⏴ go to previous day
00:10:08 <TrueBrain> glx: assembly of B483:0107 .. any chance you can get that from somewhere? :D
00:15:05 <TrueBrain> hmm, only 120 items fit in dat range, that is odd ...
00:20:09 <TrueBrain> was just 1 line, lol
00:20:31 <TrueBrain> and a very silly line for that ...
00:20:43 <TrueBrain> basically: if we don't know the length, take the maximal length
00:20:46 <TrueBrain> lucky, it was never called :p
00:21:21 <TrueBrain> lol, voices are played according to distance on the tile it happens
00:21:40 <TrueBrain> Voice_PlayByDistance?
00:22:57 <TrueBrain> From sounds weird ...
00:23:46 <glx> if distance is > some value it doesn't play ?
00:24:45 <TrueBrain> no, it has a minimum
00:24:55 <glx> btw it's used in intro too (with NULL tile)
00:27:05 <TrueBrain> guessing pushing a tile32 * is easier
00:27:07 <TrueBrain> as that can be NULL
00:27:10 <TrueBrain> now you have to make a temp var ...
00:27:45 <TrueBrain> or maybe make a Voice_Play, which wraps it
00:28:47 <TrueBrain> Voice_Play in sound.c, or in voice.c?
00:39:06 <TrueBrain> whoho, this cleans up a lot of files with emu_ calls :D
00:48:35 <TrueBrain> seems something is wrong, or it was always broken :D
00:49:40 <TrueBrain> no, I really fucked up soemthing ...
00:56:17 <TrueBrain> pfew, just one if :)
00:57:38 <DorpsGek> SVN: truebrain (r1400) -Add: C-ified Voice_PlayAtTile() and renamed some functions
00:59:48 *** Xaroth|Work has joined #openDune
00:59:48 *** TinoDidriksen has joined #openDune
00:59:48 *** planetmaker has joined #openDune
00:59:48 *** reticulum.oftc.net sets mode: +ovvo Xaroth|Work Xaroth|Work planetmaker glx
00:59:48 *** Xaroth has joined #openDune
00:59:48 *** TrueBrain has joined #openDune
00:59:48 *** reticulum.oftc.net sets mode: +o Xaroth
01:01:09 *** ChanServ sets mode: +v Xaroth
01:03:07 <DorpsGek> SVN: truebrain (r1401) -Fix: remove unused emulator functions. Could even remove emu_tile.c :D
01:03:12 <TrueBrain> PROGRESSSSSsszzzz :D
01:03:17 <TrueBrain> this is really nice :)
01:03:26 <TrueBrain> 600 functions done!!!
01:03:53 <TrueBrain> glx: please let me know if there are MSVC problems :D
01:06:03 <glx> stupid MSVC didn't notice the files changed
01:07:32 <glx> and of course svn failed to merge correctly opendune.c
01:52:40 <DorpsGek> SVN: glx (r1402) -Add: C-ified GameLoop_B4ED_0AA5()
02:45:39 <DorpsGek> SVN: glx (r1403) -Fix: more C-ification in emu_B483.c, so we don't have to call the emulator layer all the time
03:44:00 *** glevans2 has joined #openDune
11:11:05 <DorpsGek> SVN: truebrain (r1404) -Fix (r1402, #57): missing os/math.h include
11:11:31 <TrueBrain> how is that for response time
11:15:09 <TrueBrain> opendune: src/gui/widget.c:182: GUI_Widget_Draw: Assertion `drawMode < DRAW_MODE_MAX' failed.
11:27:23 <DorpsGek> SVN: truebrain (r1405) -Fix (r1397): forgetting to pop cs:ip from stack can never result in anything good ..
11:27:33 <TrueBrain> pfew, it was an easy oversight :D (from me)
12:41:14 *** fjb is now known as Guest2732
14:03:09 <glx> I like "This is not spam..." in PM
14:05:59 <glx> about #57 I could not notice it by myself
14:06:46 <Xaroth|Work> heh, he only joined right before you, so that explains why nobody noticed
14:08:31 <TrueBrain> stack always will be annoying :D
14:09:19 <glx> I tried to install win7 SP1, already failed twice
14:09:59 <glx> I download the full package now
14:29:45 <TrueBrain> clicking a unit with voices on often results in an infinite loop
14:30:29 <DorpsGek> SVN: truebrain (r1406) -Fix: remove a lot of externs when they are no longer required
14:31:19 <TrueBrain> many files are without emu_ calls now
14:33:55 <TrueBrain> going to attack B511 now
14:34:22 <TrueBrain> (just to fix a few WSA calls ... if those are out the emulator layer, it can be fixed nicely :)
15:33:43 <TrueBrain> finally found why the hints keep bugging us
15:33:51 <TrueBrain> explicitly it says that for the first 5 scenarios, you see them
15:34:01 <TrueBrain> only after that it doesn't show them anymore if you haven't already
15:36:01 <TrueBrain> owh, it filters on ScenarioID ... even more odd tbfh :p
15:48:18 <TrueBrain> hmm .. I ahve a consistent crash with HEAD
15:48:44 <TrueBrain> strangely enough, it did work this morning
15:50:59 <TrueBrain> right, it does work on one machine, it doesn't on the other :p
15:55:28 <DorpsGek> SVN: truebrain (r1407) -Fix: some cleanup of sound.c
15:57:31 <TrueBrain> r1403 is to blame ..
16:04:46 <TrueBrain> I can't find anything wrong, but something corrupts the stack
16:34:07 <TrueBrain> I know where it breaks (after a lot of tracing), but not why :s
16:42:53 <DorpsGek> SVN: truebrain (r1408) -Fix: don't 'fake' CS:IP. The more stuff is converted, the further down the line illegal CS:IP is used, causing weird problems
16:49:32 <DorpsGek> SVN: truebrain (r1409) -Add: C-ified a few functions in B511. Converted functions start with d_; this commit is to allow easier bug-tracing if it turns out to be required
18:00:57 <DorpsGek> SVN: truebrain (r1410) -Add: C-ified a few more B511 functions.
18:05:45 <TrueBrain> glx: B48B:001E .. can you do your magic? Disassemble, in this case :)
18:13:34 <glx> I can guess it's return NULL ;)
18:13:43 <TrueBrain> I think it is return var06
18:19:31 <glx> 3ff1:001e 42bbe: 8b 56 08 mov dx,WORD PTR [bp+0x8]
18:19:32 <glx> 3ff1:0021 42bc1: 8b 46 06 mov ax,WORD PTR [bp+0x6]
18:19:32 <glx> 3ff1:0024 42bc4: eb 5e jmp 0x42c24
18:25:08 <DorpsGek> SVN: truebrain (r1411) -Add: C-ified GUI_Widget_Link()
18:25:24 <DorpsGek> SVN: truebrain (r1412) -Fix (r1410): second widget needs to be index 2, not 1 silly
18:26:00 <TrueBrain> stuff starts to feel usable :)
18:26:38 <glx> using my script is faster than creating crash.bin ;)
18:26:45 <DorpsGek> SVN: truebrain (r1413) -Fix: minor coding style
18:27:13 <glx> the only problem with my script is the calls
18:27:39 <TrueBrain> you can't have it all :D
18:27:55 <glx> normal calls just need +0x1F7
18:28:27 <TrueBrain> I wonder how to call this B511 stuff
18:28:33 <TrueBrain> it seems to do the mentat screens
18:29:21 <glx> it seems related to mission objectives
18:29:34 <TrueBrain> it displays the screens and buttons
18:29:37 <TrueBrain> and handles their input
18:30:37 <TrueBrain> well, I just first convert the stuff
18:38:51 <TrueBrain> I only decided to commit it in a non-perfect way ... but I really love to be able to use svn-update to find errors :D
18:41:45 <TrueBrain> glx: one more request: B511:0251, disassembling
18:43:53 <TrueBrain> owh, yes, thatone too
18:51:42 <TrueBrain> LOL! Line reads: if s->countDown == 1: s->countDown = 1, else s->countDown = s->countDown
18:53:10 <TrueBrain> and before that: != 0
18:53:25 <TrueBrain> it does a signed check, but the variable is unsigned
18:53:35 <TrueBrain> which suggests it correct for problems of old or broken savegames :p
18:53:57 <TrueBrain> so: if countdown != 0: countdown = max(countdown, 1)
18:54:01 <TrueBrain> which is ....... silly :p
18:54:18 <TrueBrain> I have some issues with a code a bit lower too ...
18:54:24 <TrueBrain> palacePosition is set by non-palace?
18:55:49 <Xaroth|Work> construction yard?
18:56:04 <TrueBrain> lets randomly name structures \o/
18:56:32 <Xaroth|Work> I'd expect the building responsible for building buildings to be responsible for telling the system where it built the palace
18:57:13 <TrueBrain> euhm ... I am very happy you try to contribute, but ....
18:57:32 <Xaroth|Work> i'm just rambling
19:02:58 <TrueBrain> seems we never made a savegame while a structure was selected? Lol
19:15:32 <TrueBrain> + if (s->o.type == STRUCTURE_PALACE) {
19:15:34 <TrueBrain> + House_Get_ByIndex(s->o.houseID)->palacePosition = s->o.position;
19:15:38 <TrueBrain> + if (House_Get_ByIndex(s->o.houseID)->palacePosition.tile != 0) continue;
19:15:40 <TrueBrain> + House_Get_ByIndex(s->o.houseID)->palacePosition = s->o.position;
19:24:37 <DorpsGek> SVN: truebrain (r1414) -Fix: some renaming and moving of variables / functions
19:24:51 <DorpsGek> SVN: truebrain (r1415) -Add: C-ified some more of B511
19:40:46 <DorpsGek> SVN: truebrain (r1416) -Add: C-ified one more function in B511
19:47:12 <TrueBrain> I am not going crazy, am I? It really reads that, right?
20:10:51 <DorpsGek> SVN: truebrain (r1417) -Add: C-ified the last of B511
20:12:17 <TrueBrain> where to put these functions .....
20:32:17 <DorpsGek> SVN: truebrain (r1418) -Add: moved C-ified B511 functions to correct places and wrapped it all up nicely. Bye B511.
20:35:44 <TrueBrain> and how many MSVC problems did I make? :D
20:36:29 <DorpsGek> SVN: truebrain (r1419) -Fix (r1418): commit all dirs ..
20:36:47 <DorpsGek> SVN: truebrain (r1420) -Fix: remove a bit of Dune2 crazyness and make it more sane
20:44:28 <TrueBrain> blegh, I tried emu_Scenario_Load again ... but an annoying function :p
20:44:39 <TrueBrain> one of the first functions I did, so a lot of old-style C-ification
20:45:01 <TrueBrain> but I really need to C-ify the Ini routines for it ... don't feel like doing that :D
20:45:15 <TrueBrain> owh, just 7 .. that aint too bat :D
20:46:27 <DorpsGek> SVN: glx (r1421) -Fix: MSVC warnings
20:48:29 <TrueBrain> B4D4 and B495 left with WSA calls
20:50:15 <TrueBrain> bah; huge functions
20:50:34 <glx> f__B4ED_0BD4_001B_FFBA() can be inlined I think
20:50:52 <glx> I mean replace the call with memcpy
20:53:31 <TrueBrain> there; enough C-ifying for me for one day :D Haha :)
20:53:35 * TrueBrain is happy with result :)
21:51:24 *** Xaroth_ has joined #openDune
23:03:41 <DorpsGek> SVN: glx (r1422) -Add: C-ified GameLoop_B4ED_0BF4() and inlined other B4ED functions. Bye B4ED.
continue to next day ⏵