IRC logs for #opendune on OFTC at 2011-02-24
#opendune / 2011 / 02 
            

00:09:04  <DorpsGek> SVN: glx (r1386) -Add: C-ified GameLoop_B4AB_0000()



00:11:17  <glx> now B4ED is doable :)



00:11:56  <glx> but that's 1924 lines in 9 functions



02:11:20  <glx> http://svn.opendune.org/~glx/temp.patch <-- 2 B4ED functions C-ified (there's still an array on emu stack in B4ED_0000)



05:16:11  *** glx has quit IRC



12:40:59  *** fjb is now known as Guest2493



12:41:00  *** fjb has joined #openDune



12:48:06  *** Guest2493 has quit IRC



12:59:33  *** glx has joined #openDune



12:59:33  *** ChanServ sets mode: +o glx



13:00:03  <glx> hello



13:03:56  <Xaroth|Work> o/



14:39:20  <TrueBrain> morning :)



14:39:26  <TrueBrain> glx: just please do not commit those 9 functions as 1 commit



14:39:31  <TrueBrain> history has shown that is very bad for bug-tracing



14:53:58  <glx> of course :)



15:07:12  <TrueBrain> src/unknown/emu_B483.c: emu_String_Get_ByIndex still in used. Suggest replacing



15:07:14  <TrueBrain> src/gui/widget_draw.c: emu_GUI_DrawText_Wrapper still in used. Suggest replacing



15:07:15  <TrueBrain> src/gui/emu_gui.c: emu_GUI_DisplayHint still in used. Suggest replacing



15:07:17  <TrueBrain> src/opendune.c: emu_Font_Select still in used. Suggest replacing



15:07:18  <TrueBrain> src/gui/emu_widget.c: emu_GUI_Widget_HandleEvents still in used. Suggest replacing



15:07:20  <TrueBrain> I extended my script after reading your patch :)



15:07:41  <Xaroth|Work> still in used? :P



15:07:51  <DorpsGek> SVN: glx (r1387) -Add: C-ified GameLoop_B4ED_0184()



15:13:05  <glx> Xaroth|Work: means a direct replacement exists and we should not use wrappers



15:13:29  <TrueBrain> I think he was trying to be 'funny' by making fun of my english



15:13:44  <glx> ha yes the extra "d"



15:13:49  <TrueBrain> something about cattle, and black ....



15:14:29  <glx> are you replacing now ?



15:14:32  <TrueBrain> well, extra "in " tbh :p



15:14:48  <TrueBrain> no, I had to adjust my script a bit



15:14:56  <TrueBrain> 3 out of 5 were in emu_ wrappers



15:15:00  <TrueBrain> I don't care about those :p



15:15:23  <glx> ok let's do that now then



15:15:38  <TrueBrain> src/gui/widget_draw.c: emu_GUI_DrawText_Wrapper still used. Replace with GUI_DrawText_Wrapper



15:15:39  <TrueBrain> src/opendune.c: emu_Font_Select still used. Replace with Font_Select



15:15:41  <TrueBrain> src/house.c: emu_Driver_Voice_01EB still used. Replace with Driver_Voice_01EB



15:15:42  <TrueBrain> src/driver.c: emu_MPU_SetData still used. Replace with MPU_SetData



15:15:44  <TrueBrain> src/driver.c: emu_MPU_Play still used. Replace with MPU_Play



15:15:45  <TrueBrain> src/driver.c: emu_MPU_Stop still used. Replace with MPU_Stop



15:15:47  <TrueBrain> src/driver.c: emu_MPU_GetDataSize still used. Replace with MPU_GetDataSize



15:15:48  <TrueBrain> src/driver.c: emu_MPU_GetUnknownSize still used. Replace with MPU_GetUnknownSize



15:15:50  <TrueBrain> if you like, please do fix them :)



15:15:56  <glx> could your script show the line numbers too ?



15:16:02  <TrueBrain> nope



15:16:13  <TrueBrain> but nothing a simple search won't show you :)



15:18:25  <Xaroth|Work> TrueBrain: mooo :p



15:18:51  <Xaroth|Work> but yeh, it was a poor attempt at being funny



15:18:55  <glx> http://svn.opendune.org/~glx/temp.diff <-- do we want this ?



15:19:14  <TrueBrain> so is the 'moo', but I hope the 'mistake' was intended and stuff



15:19:58  <TrueBrain> glx: I dunno ... on one hand it can be useful, on the other .. it doesn't really help



15:20:08  <TrueBrain> so I think we can better not do it, and keep the emu layer (whichd oes it for us)



15:20:19  <TrueBrain> just for clarity ... knowing what we still need to fix etc :p



15:20:42  <TrueBrain> I am btw surprised we didn't miss more emu_ stuff



15:20:45  <TrueBrain> very nice job on that :D



15:22:20  <glx> now I now why there's still an emu_GUI_DrawText_Wrapper-) ;)



15:23:13  <TrueBrain> wasn't it the annoying one? :p



15:23:23  <glx> it's because the emu_GUI_String_Get_ByIndex() before it



15:23:35  <TrueBrain> thatone is not converted yet?



15:24:16  <glx> yup, and it's a 120 lines function



15:24:34  <TrueBrain> :(



15:24:39  <glx> with a switch(emu_ip)



15:32:10  <glx> and emu_MPU are all in Drivers_CallFunction()



15:32:58  <TrueBrain> the script just reports :)



15:39:24  <DorpsGek> SVN: glx (r1388) -Fix: don't use wrappers when converted function exists



15:40:04  <glx> oups mistake



15:42:42  <DorpsGek> SVN: glx (r1389) -Fix (r1388): when you replace wrapper with direct call, do it right



15:43:16  <glx> yes a stupid one



15:44:22  <glx> included the sleep(0) just in case



15:44:51  <glx> though it should not be needed



16:03:01  <TrueBrain> butter safe than sorry :D



16:03:23  <TrueBrain> why does Font_Select take a csip32, not a void * or something?



16:05:26  <glx> because it contains many g_global->xxx = font_csip



16:05:44  <TrueBrain> ah :D



16:40:47  <DorpsGek> SVN: glx (r1390) -Add: C-ified GameLoop_B4ED_0000()



16:43:24  <glx> http://svn.opendune.org/~glx/temp.patch <-- good idea ?



16:44:38  <TrueBrain> sure; go for it



16:48:18  <DorpsGek> SVN: glx (r1391) -Fix: replace emu_Terminate_Normal() with exit()



16:48:58  <glx> src/opendune.c:257:95: warning: unused parameter 'arg14' <-- of course dune2 is silly ;)



16:50:09  <TrueBrain> VARIABLE_NOT_USED(arg14)



16:53:13  <DorpsGek> SVN: glx (r1392) -Fix (r1390): gcc warning



17:05:52  <TrueBrain> well, or remove the variable of course, if opssible :p



17:06:10  <glx> it's possible to remove it yes



17:06:38  <TrueBrain> VARIABLE_NOT_USED I had to use in those script stuff :D



19:49:20  <TrueBrain> 48% btw :D



19:52:03  *** Xaroth_ has quit IRC



21:15:16  *** Xaroth has joined #openDune



21:35:40  *** Xaroth has quit IRC



21:43:53  *** Xaroth has joined #openDune



22:13:28  *** Xaroth has quit IRC



23:15:46  <glx> ok all B4ED is related to animations (intro, ...)