IRC logs for #opendune on OFTC at 2011-02-22
⏴ go to previous day
00:38:54 <DorpsGek> SVN: glx (r1356) -Add: C-ified Map_CreateLandscape()
01:09:36 <DorpsGek> SVN: glx (r1357) -Fix (r1356): forgot to add some comments
04:36:34 <DorpsGek> SVN: glx (r1358) -Add: Renamed Tile_GetDirection() to Tile_DirectionPacked(). C-ified Tile_MoveByRandom() and Tile_GetDirection() (bye bye 0F3F). Removed unused emulator functions.
04:37:31 <DorpsGek> SVN: glx (r1359) -Fix: typo in emu_Tools_PrintString()
09:51:40 <DorpsGek> SVN: truebrain (r1360) -Fix: remove some unused emulator layers
12:41:13 *** fjb is now known as Guest2212
14:50:57 <TrueBrain> discovering some nice things :D
15:08:05 <TrueBrain> in what file to put Animate ....
15:08:23 <TrueBrain> maybe in its own file
15:08:36 <TrueBrain> so long ago I made a new file :D
15:11:50 <TrueBrain> seems there can be only 112 animations on the map
15:22:41 <DorpsGek> SVN: truebrain (r1361) -Add: C-ified Animation_Add()
15:23:20 <DorpsGek> SVN: truebrain (r1362) -Fix (r1361): add before commit
15:23:31 <TrueBrain> I am REALLY good in getting the revision up fast :D
15:28:33 <glx> hmm maybe I should check for DEBUG too
15:29:26 <glx> or I need to find a way to determine if it created a console window
15:29:45 <glx> because that's the only reason for the redirect
15:47:17 <glx> hmm for mingw it can be useful too (no need to "2>&1 | less" to prevent hang at start)
15:54:03 <DorpsGek> SVN: truebrain (r1363) -Add: C-ified Animation_Stop_ByTile()
15:55:14 <DorpsGek> SVN: truebrain (r1364) -Fix: rename Animation_Add to Animation_Start, more consistent
16:22:36 <Xaroth|Work> planetmaker: 400mb worth of titlegame SCREENSHOTS?!?!?!?
16:22:53 <Xaroth|Work> that's 100mb per mb of games o_O
16:28:14 <planetmaker> the huge ones are really big ;-)
16:28:50 <planetmaker> and then one per base set, doubles it again
17:20:27 <TrueBrain> if that works glx, go for it :)
17:20:32 <TrueBrain> I don't have Windows, so I have no clue :p
17:21:05 <glx> now it always start first time when ran from cmd :)
17:26:07 <DorpsGek> SVN: glx (r1365) -Change: redirect stderr and stdout to output.log and error.log for win32, and don't keep the console window (for now it's still a console app though)
17:56:50 <TrueBrain> bah, 1 animation function is not decompiled
17:57:02 <TrueBrain> owh, very short one
17:59:49 <TrueBrain> hahahahahaha @ code ... for() { if (proc != 0) { <long if> } if (proc == 0) continue; }
17:59:59 <TrueBrain> lovely useless jump there ... how about switching statements? No?
18:00:16 <TrueBrain> hmm .. maybe it becomes zero in that if
18:13:16 <DorpsGek> SVN: truebrain (r1366) -Add: C-ified Animation_Tick()
18:15:21 <DorpsGek> SVN: truebrain (r1367) -Fix: rename animate.[ch] to animation.[ch], to be more consistent
18:47:13 <DorpsGek> SVN: truebrain (r1368) -Add: C-ified Animation_Func_Stop() (which was aliased by another function, which got replaced by Stop() now)
18:53:10 <DorpsGek> SVN: truebrain (r1369) -Add: C-ified Animation_Func_Unknown7()
18:55:19 <DorpsGek> SVN: truebrain (r1370) -Add: C-ified Animation_Func_Unknown4()
18:55:38 <TrueBrain> every time I think: this is the last small function
18:55:40 <TrueBrain> and I find another one :)
18:55:43 <TrueBrain> right, really the last one :)
18:58:15 <glx> Avertissement 1 warning C4244: '=' : conversion de 'int16' en 'uint8', perte possible de données d:\developpement\opendune\trunk\src\animation.c 79
18:59:04 <TrueBrain> sigh, stupid blabla always
18:59:23 <TrueBrain> you don't get the warning at line 69?
18:59:51 <TrueBrain> well, I guess thatone is okay
19:00:39 <DorpsGek> SVN: truebrain (r1371) -Fix (r1366): make MSVC happy
19:03:32 <TrueBrain> hmm .. can't convert 1 function
19:03:40 <TrueBrain> B483_0000 needs converting
19:04:16 <glx> I have a B4B8 ready to go (just waiting for mingw)
19:04:39 <Xaroth|Work> holy shit things go fast now :P
19:04:49 <TrueBrain> nah, just many commits
19:05:00 <DorpsGek> SVN: glx (r1372) -Add: C-ified Map_AddSpiceToTile()
19:05:54 <TrueBrain> right, first going to do the rest of 151A
19:05:59 <TrueBrain> then I might tackle B483 ....
19:06:12 <TrueBrain> not any time soon :D
19:10:00 <DorpsGek> SVN: truebrain (r1373) -Add: C-ified Animation_Func_Abort()
19:14:15 <DorpsGek> SVN: truebrain (r1374) -Add: C-ified Animation_Func_Pause()
19:15:13 <TrueBrain> didn't expect to find scripting in the animation stuff tbh :)
19:16:58 <planetmaker> what would life be without surprises? ;-)
19:17:24 <Xaroth|Work> it'd be a lot easier to write a bot to do all my work that's for sure
19:17:40 <planetmaker> or you'd be the bot
19:17:57 <TrueBrain> well, tbh, most of this C-ification can be automated
19:18:02 <TrueBrain> would be one hell of a projec to do
19:18:07 <TrueBrain> but most likely takes the same amount of time ;)
19:24:48 <DorpsGek> SVN: truebrain (r1375) -Add: C-ified Animation_Func_SetOverlay()
19:47:07 <TrueBrain> hmm ... there is some weird special case in animation
19:47:09 <TrueBrain> now I ened to trigger it :(
19:51:55 <TrueBrain> oeh, bug in repair facility
19:51:59 <TrueBrain> gives weird % values :D
19:52:07 * TrueBrain puts it on its TODO to forget
19:55:09 <TrueBrain> something to do with turrets ...
19:57:10 <planetmaker> especially when used as offensive weapon :-)
19:57:11 <TrueBrain> only what possible animation can they have/
20:04:09 <TrueBrain> bah, building a normal turret no longer works :'(
20:13:12 <TrueBrain> the good news is that it isn't my current patch
20:13:45 <DorpsGek> SVN: truebrain (r1376) -Add: C-ified Animation_Func_SetGroundSprite(), and named most of the other functions correctly
20:13:56 <DorpsGek> SVN: truebrain (r1377) -Fix (r1376): some minor spacing
20:18:27 <TrueBrain> very happy I made so many small commits out of it :D
20:24:15 <TrueBrain> right ... r1360, problem still there
20:26:04 <glx> my next stuff will be B4AE
20:27:30 <TrueBrain> between r1350 and r1360 ...
20:30:12 <glx> fog of war looked strange in A1 too
20:34:26 <TrueBrain> why didn't you say earlier? :d :p :p
20:43:18 <DorpsGek> SVN: truebrain (r1378) -Fix: some minor styling
20:44:28 <TrueBrain> and I really can't find a mistake :(
20:45:32 <glx> yes I don't see anything wrong
20:48:50 <glx> hmm neighbourVeiled = 15; maybe
20:49:30 <TrueBrain> no; I inverted the testcase a bit
20:50:53 <TrueBrain> lol, GetPackedX can never return any value bigger than 63 :p
20:54:42 <glx> if (g_global->variable_38BC != 0) return;
20:55:47 <TrueBrain> if that statement holds, it goes to 13E2, which goes to 145E ... hmm .. that is not 14C4 ...
20:57:46 <DorpsGek> SVN: truebrain (r1379) -Fix (r1352): fix a nasty bug (difficults ifs are HARD), and made some code a bit more clean .. GetPackedX never returns values below 64, so checking on > 63 is silly.
20:57:52 <TrueBrain> there, two birds one stone
20:59:35 <TrueBrain> yeah... was not the first hard-if I had around there
20:59:58 <glx> I had them more than once
21:01:08 <glx> hmm many packed > 4096 check can be replaced too
21:01:50 <DorpsGek> SVN: truebrain (r1380) -Fix: removed some more unused emulator wrappers
21:01:54 <TrueBrain> are a few nice one in there btw
21:02:38 <TrueBrain> yes, indeed, they can replaced with this wrapper now :)
21:04:00 <DorpsGek> SVN: truebrain (r1381) -Fix: replaced one packed != 0xF000 with Tile_IsOutOfMap()
21:04:11 <TrueBrain> I leave the 4096 for you or for another day :) I need to do something else now :D
21:06:09 <glx> we can still clean things later
21:06:39 <TrueBrain> yeah, but it is good to do those things when you remember them :D
21:08:11 <glx> oh I have some MSVC warnings (I should full recompile more often)
21:16:44 <DorpsGek> SVN: glx (r1382) -Fix: replaced packed >= 4096 with Tile_IsOutOfMap() (and make MSVC happy)
21:27:30 <TrueBrain> the first in src/map.c is useless anyway :)
21:27:40 <TrueBrain> also make x and y unsigned please :D
21:27:45 <glx> and you can see how consistent the checks were
21:27:50 <TrueBrain> but yeah, looks good :)
21:30:51 <TrueBrain> there btw are still huge problems with corner tiles
21:30:55 <TrueBrain> most likely why they only show 62x62
21:31:03 <TrueBrain> when you are on X=63, and you do +1
21:32:50 <TrueBrain> you understand what I mean :p
21:32:54 <TrueBrain> no need to be picky :p
21:33:30 <glx> yes, it will get the Y+1 0 instead
21:33:31 <TrueBrain> but I guess they couldn't get that fixed in their code all over the place .. so they just hide the corner tiles :D
21:35:33 <glx> better keep the 64 checks for now
21:35:41 <TrueBrain> no, your patch is very good
21:36:11 <TrueBrain> remember you can't use border tiles ;)
21:36:45 <TrueBrain> well, maybe you are right .. the first one of map.c is something to commit in either case
21:36:50 <TrueBrain> up to you if you do the rest or not :)
21:37:01 <glx> no with my patch it accepts (7, 66)
21:38:11 <TrueBrain> 1061 if (x < 0 || x > 64 || y < 0 || y > 64) {
21:38:12 <TrueBrain> 1061 if (Tile_IsOutOfMap(curPacked)) {
21:38:14 <TrueBrain> as that one is silly anyway
21:38:21 <TrueBrain> (GetPackedX enver returns < 0 or > 64)
21:38:27 <TrueBrain> funny btw, > 64 .. should be > 63 :p
21:42:08 <glx> g_global->variable_255E indeed contains -64; 1; 64; -1
21:43:10 <TrueBrain> you sound surprised :p
21:45:04 <TrueBrain> no matter what that var contained, it is ok :)
21:45:09 <DorpsGek> SVN: glx (r1383) -Fix: one more Tile_IsOutOfMap() usage
21:45:11 <TrueBrain> as that if() never happens in this case :)
21:45:17 <TrueBrain> never ever ever ever ever
21:45:24 <TrueBrain> now at least can be triggered :D
21:46:42 <glx> I think all possible replacements are done
21:48:18 <glx> I searched 4096, 64 and 63
21:49:01 <glx> there are still the x > 16384 and y > 16384
21:49:15 <glx> but they are pixel related I think
21:53:09 <glx> ha no they are the same but for s.x and s.y
21:53:34 <glx> uint32 ox:8; uint32 px:6; uint32 ux:2;
21:53:34 <glx> uint32 oy:8; uint32 py:6; uint32 uy:2;
21:54:08 <glx> similar to d.px > 64 and d.py > 64 indeed
21:57:04 <TrueBrain> yeah, but those are different :)
continue to next day ⏵