IRC logs for #opendune on OFTC at 2011-02-17
⏴ go to previous day
07:34:14 *** Xaroth_ has joined #openDune
09:33:40 <Xaroth_> AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
09:34:38 *** Xaroth_ is now known as Xaroth
09:35:22 <SmatZ> I didn't know you are crazy :)
11:51:47 *** TrueBrain has joined #openDune
12:09:46 *** TrueBrain has joined #openDune
12:09:46 *** planetmaker has joined #openDune
12:09:46 *** Xaroth|Work has joined #openDune
12:09:46 *** TinoDidriksen has joined #openDune
12:09:46 *** charon.oftc.net sets mode: +vov planetmaker Xaroth|Work Xaroth|Work
12:13:45 *** glevans2 has joined #openDune
12:14:02 *** Xaroth has joined #openDune
12:14:02 *** coulomb.oftc.net sets mode: +v Yexo
12:14:08 *** ChanServ sets mode: +o Xaroth
12:40:11 *** fjb is now known as Guest1704
12:54:54 <DorpsGek> SVN: truebrain (r1298) -Add: introduce Language enum, to identify languages by name, not number
12:55:13 <DorpsGek> SVN: truebrain (r1299) -Add: C-ified another piece of this huge function
13:48:23 <glx> buttons array init is not done
13:49:33 <glx> and emu_bp - 0x50 accesses can be removed ;)
13:50:39 <TrueBrain> in all cases of usage, it is initialized
13:50:53 <TrueBrain> and cleanup of those entries is something for another time :)
13:50:55 <TrueBrain> conversion has prio :)
13:51:09 <TrueBrain> it is initliazed with actionType != 0, and used with actionType > 1
13:52:25 <glx> isNotPlayerOwned = (g_global->playerHouseID == Unit_GetHouseID(u)) ? false : true; <-- you could have used != ;)
13:52:36 <glx> but I know cleanup is for later
13:52:40 <TrueBrain> the variable is weird anyway
13:52:46 <TrueBrain> but yeah, don't waste your time atm :)
13:53:04 <TrueBrain> and besides, I am always defining true/false explicit
13:53:17 <TrueBrain> even with !=, it would have been ? true : false
13:56:10 <Xaroth|Work> as in: isNotPlayerOwned = !(g_global->playerHouseID == Unit_GetHouseID(u))
13:57:30 <TrueBrain> Xaroth|Work: wtf are you talking about?
13:57:36 <TrueBrain> you really do not give enough english words to make any sense of
13:57:54 <Xaroth|Work> isNotPlayerOwned = (g_global->playerHouseID == Unit_GetHouseID(u)) ? false : true;
13:58:00 <TrueBrain> blegh, audio-drivers tends to crash from time to time :(
13:58:01 <Xaroth|Work> isNotPlayerOwned = !(g_global->playerHouseID == Unit_GetHouseID(u));
13:58:18 <TrueBrain> Xaroth|Work: that would be very weird, but something similar is what glx said, yes
13:58:51 <glx> better use != in this case
14:06:15 <TrueBrain> lol, you can never make structure which store more than 1000 credits
14:06:19 <TrueBrain> it is hardcapped in the code :p
14:08:37 <TrueBrain> thank you for that contribution :D
14:08:51 <Xaroth|Work> in the starports the max price is also 999
14:08:55 <planetmaker> and nice to see some progress again here :-)
14:11:05 <TrueBrain> owh, that is not true: it can contain more, but the GUI says only 1000
14:11:13 <TrueBrain> that is why a Refinery has 1005 in it, while only storing 1000 :p
14:12:35 <DorpsGek> SVN: truebrain (r1300) -Add: C-ified last pieces of this huge function
14:12:50 <TrueBrain> now it is time to give this function a bit of sanity ...
14:13:23 <TrueBrain> I think a seperate function for each actionType ...
14:15:25 <glx> to uint16->uint8 warnings
14:15:43 <TrueBrain> can you fix them now?
14:15:48 <TrueBrain> then I hold off any further modifications :D
14:16:12 <DorpsGek> SVN: truebrain (r1301) -Fix: wrong \n in C-ified function ;)
14:17:46 <DorpsGek> SVN: glx (r1302) -Fix (r1300): MSVC uint16 to uint8 warnings
14:18:26 <TrueBrain> think I C-ify a few functions first, as else it will remain unreadable :p
14:27:40 <TrueBrain> right ... how to convert a Widget * to a csip32 ....
14:41:49 <DorpsGek> SVN: truebrain (r1303) -Add: C-ified GUI_Widget_Get_ByIndex()
14:56:15 <TrueBrain> how do you call it when a widget handles an action and doesn't send it to its parent?
15:02:42 <TrueBrain> (names are, but true vs false ..)
15:12:58 <DorpsGek> SVN: truebrain (r1304) -Add: make Widget.flags in a struct, to ease up lookups
15:15:12 <TrueBrain> sigh, deeper and deeper in the rabbithole to fix up stuff easier :D
15:39:33 <TrueBrain> Cascade, was the word I was looking for :D
15:40:36 <DorpsGek> SVN: truebrain (r1305) -Add: C-ified GUI_Widget_MakeInvisible(), and some cascading cleanup resulting from it
15:46:22 <DorpsGek> SVN: truebrain (r1306) -Add: C-ified GUI_Widget_MakeVisible()
16:22:29 <DorpsGek> SVN: truebrain (r1307) -Add: C-ified GUI_Widget_MakeSelected(), renamed GUI_Widget_Update to GUI_Widget_MakeNormal (as that is what it does), replaced emu_ calls where possible, and removed csip parameters where possible
16:22:40 <TrueBrain> that cleans it up a lot already :)
16:26:17 <TrueBrain> lol, instead of memset, they used a memcpy which is always 0 :p
16:45:29 <DorpsGek> SVN: truebrain (r1308) -Add: C-ified GUI_Widget_ActionPanel_Draw(). Finally, the long function is done ;)
16:45:42 <TrueBrain> I was too lazy to write emu_ functions, so I did something nasty
16:45:49 <TrueBrain> we can no longer rerun the decompiler :p
16:47:21 <TrueBrain> maybe this will bite us in the ass later on, but I didn't see the use of making an emulator function for this :p
16:47:29 <TrueBrain> we will see ... sorry in advance :D
16:52:53 <DorpsGek> SVN: truebrain (r1309) -Fix (r1308): don't be lazy, and just make an emulator function
16:53:03 <TrueBrain> *sigh*, decided it could bite back hard .... *sigh*
17:04:18 <DorpsGek> SVN: truebrain (r1310) -Fix: remove a shitload of unused emu_ functions. BE GONE!
17:04:44 <TrueBrain> I love doing that :D
17:27:53 <glx> you have a script to find them I guess
17:30:22 <TrueBrain> gives me a nice list :p
17:30:30 <TrueBrain> still a few in them, but those are in Audio and MPU
17:30:34 <TrueBrain> I don't dare to touch them :D
17:30:56 <TrueBrain> but a few I removed makes me really happy
17:31:02 <TrueBrain> Unit_Allocate, Unit_Create ...
17:31:16 <TrueBrain> slowly, we are getting there :)
continue to next day ⏵