⏴ go to previous day
02:04:58 *** Osai has quit IRC
02:04:58 *** planetmaker has quit IRC
02:04:58 *** SmatZ has quit IRC
02:04:58 *** Yexo has quit IRC
02:04:58 *** tneo has quit IRC
02:13:01 *** Osai has joined #openDune
02:14:01 *** SmatZ has joined #openDune
02:16:13 *** Yexo has joined #openDune
02:16:13 *** ChanServ sets mode: +v Yexo
02:18:15 *** planetmaker has joined #openDune
02:18:15 *** ChanServ sets mode: +v planetmaker
02:18:21 *** Xaroth has quit IRC
02:19:02 *** tneo has joined #openDune
03:26:46 *** glx has quit IRC
07:39:37 *** Xaroth has joined #openDune
07:39:37 *** ChanServ sets mode: +o Xaroth
09:03:36 *** tneo has quit IRC
09:04:11 *** Osai has quit IRC
09:05:23 *** SmatZ has quit IRC
09:06:01 *** planetmaker has quit IRC
09:06:20 *** Yexo has quit IRC
10:56:05 *** fjb is now known as Guest1074
10:56:06 *** fjb has joined #openDune
11:02:53 *** Guest1074 has quit IRC
12:23:37 *** planetmaker has joined #openDune
12:24:15 *** planetmaker is now known as Guest1080
12:24:46 *** Guest1080 is now known as planetmaker
13:18:31 *** glx has joined #openDune
13:18:31 *** ChanServ sets mode: +o glx
13:19:24 <glx> hello
16:59:52 *** Yexo has joined #openDune
16:59:52 *** ChanServ sets mode: +v Yexo
17:18:11 *** planetmaker is now known as Guest1120
18:05:33 <DorpsGek> Bugs: http://bugs.opendune.org/view.php?id=45 :: Bug Created :: taking over structures is not possible
18:07:30 <Xaroth> :o with patch included
18:07:32 <Xaroth> how nice
18:08:03 <glx> seems right :)
18:08:48 <glx> oh it's my code
18:09:47 <Xaroth> shhh :P
18:13:36 <TrueBrain> bad glx :p
18:14:01 <DorpsGek> SVN: glx (r1189) -Fix (r1044, #45): taking over structures was impossible
18:14:45 <DorpsGek> Bugs: http://bugs.opendune.org/view.php?id=45 :: New Status: resolved (fixed)
18:14:56 <TrueBrain> you didn't give credit :O
18:15:11 <TrueBrain> hihi, nice catch...
18:16:30 <glx> hmm wrong status
18:18:46 <DorpsGek> Bugs: http://bugs.opendune.org/view.php?id=45 :: New Status: feedback (reopened)
18:18:59 <DorpsGek> Bugs: http://bugs.opendune.org/view.php?id=45 :: New Status: closed (fixed)
18:19:17 <glx> stupid bug tracker ;)
18:41:15 <DorpsGek> Bugs: http://bugs.opendune.org/view.php?id=46 :: Bug Created :: documentation and renaming for function Unit_Unknown3014
18:46:51 <Xaroth> ooo
18:46:53 <Xaroth> and another patch
18:46:57 <Xaroth> guess we got a fan :)
18:47:13 * glx likes this guy
18:47:29 <Xaroth> he should get on irc.
18:48:25 <glx> he even named the variables
18:49:54 <glx> + si->flags.s.conquerable = 1; <-- not sure about this line
18:52:10 <Xaroth> heh
18:52:17 <Xaroth> he wanted everything conquerable
18:52:25 <Xaroth> so i guess that 'did the trick'
19:21:55 <TrueBrain> IRC would reduce pointless bugreports, yes :p
19:22:06 <TrueBrain> too bad the bug tracker wants to download the patch, instead of show it ..
19:22:08 * TrueBrain looks at Xaroth
19:22:19 <Xaroth> er
19:22:23 <Xaroth> there's a link
19:22:34 <Xaroth> like, right next to it
19:22:36 <Xaroth> 'show content'
19:22:48 <TrueBrain> owh, fuck me
19:22:49 <TrueBrain> lol
19:22:51 <TrueBrain> cheers :)
19:22:54 <Xaroth> no thanks
19:22:55 <Xaroth> :)
19:23:02 <TrueBrain> 80 char comments ...
19:24:07 <TrueBrain> Not sure
19:24:11 <TrueBrain> best comment ever :D
19:24:20 <TrueBrain> requires TODO of course
19:24:25 <TrueBrain> to avoid that comment sitting there FOR EVER
19:24:37 <TrueBrain> and I love the printf :D
19:24:56 <TrueBrain> nice patch
19:25:10 <TrueBrain> very minor coding errors ... you don'ts ee that a lot in these times ..
19:25:20 <TrueBrain> coding = coding style
19:25:21 <Xaroth> apart from the debugging code left in, very nice indeed
19:25:50 <TrueBrain> at least someone who bothered looking at the rest of the code, before starting to pinch keys
19:26:56 <Xaroth> yeh
19:28:58 <TrueBrain> not even an OpenTTD user
19:29:04 <Xaroth> ?
19:29:13 <TrueBrain> owh, I abused some power and matched it against tt-forums.net :p
19:29:18 <Xaroth> haha
19:29:41 <TrueBrain> glx: just make sure to credit him this time ;) :D
19:46:55 <glx> [20:22:38] <@Xaroth> 'show content' <-- not intuitive enough for me :)
19:47:04 <Xaroth> wasn't for me either
19:47:11 <Xaroth> but i like to click random links from time to time :P
19:47:18 <glx> as I said "stupid bug tracker"
19:47:23 <TrueBrain> it is :)
20:01:50 <glx> oh I didn't spot the printf :)
20:05:26 <glx> [20:25:12] <@TrueBrain> very minor coding style errors ... you don'ts ee that a lot in these times .. <-- where ?
20:08:56 <TrueBrain> coding style
20:09:03 <TrueBrain> all the things I mentioned
20:09:11 <TrueBrain> "Not sure"
20:09:13 <TrueBrain> bad comment ..
20:09:16 <TrueBrain> at least: TODO -- Not sure
20:09:19 <TrueBrain> else it will be there for ever
20:09:30 <TrueBrain> /* (..)\n(..)\n*/
20:09:33 <TrueBrain> one too many \n
20:09:48 <TrueBrain> I don't like OK in comments .. but alternatives are hard
20:10:20 <TrueBrain> = 1 <- should be = true
20:11:17 <TrueBrain> return Unit_IsValidMovementIntoStructure(u2, s) ? 1 : 0; <- maybe that should be: return Unit_IsValidMovementIntoStructure(u2, s) > 0 ? 1 : 0;
20:11:23 <TrueBrain> as the return is no boolean :)
20:11:34 <TrueBrain> /*!< bitfield determining <- 'Bitfield'
20:11:35 <TrueBrain> (MINOR :p)
20:18:29 <glx> OK can be replaced with allowed I think
20:19:09 <glx> or "valid movement"
20:20:13 <glx> and the "= 1" line should not be there ;)
20:22:39 <TrueBrain> lol, true :D
20:22:44 <TrueBrain> together, we spot all errors :D
20:23:27 <glx> checking compilation with mingw, and I'll diff to double check before commit
20:45:25 <glx> http://svn.opendune.org/~glx/temp.patch <-- please check before commit
20:47:20 <TrueBrain> fine by me
20:53:04 <DorpsGek> SVN: glx (r1190) -Fix (r1044, #46): name and comment Unit_Unknown3014() (theBohemian)
20:53:17 <glx> credit included ;)
20:53:23 <TrueBrain> :D
20:54:05 <DorpsGek> Bugs: http://bugs.opendune.org/view.php?id=46 :: New Status: closed (fixed)
23:40:10 <DorpsGek> Bugs: http://bugs.opendune.org/view.php?id=47 :: Bug Created :: security question response may end game
23:44:11 *** Osai has joined #openDune
23:45:03 *** SmatZ has joined #openDune
23:47:45 *** Yexo- has joined #openDune
23:49:41 *** planetmaker has joined #openDune
23:49:41 *** ChanServ sets mode: +v planetmaker
23:50:11 *** tneo has joined #openDune
continue to next day ⏵