IRC logs for #opendune on OFTC at 2009-12-13
⏴ go to previous day
01:50:54 <DorpsGek> SVN: glx (r752) -Add: C-ified Unit_Get_ByPackedTile()
01:52:10 <DorpsGek> SVN: glx (r753) -Fix (r752): forgot to update function_names.txt
13:56:11 *** proyvind has joined #openDune
20:10:59 <DorpsGek> SVN: truebrain (r754) -Add: named another function
20:11:08 <TrueBrain> the commit messages get silly :p
20:20:51 <glx> I have a bug in a converted function, but I can't find it
20:21:14 <DorpsGek> SVN: truebrain (r755) -Add: named two more GUI functions
20:22:41 <glx> emu_Unknown_0F78_0008 doesn't work like it should
20:24:03 <TrueBrain> I think 3A0A is btw 'selectionObject'
20:24:07 <TrueBrain> as I believe it can also be a structure
20:25:09 <TrueBrain> if (g_global->selectionType == 0x1) return; <- please just use '1', '2', as they are mode-values
20:25:47 <glx> emu_Unknown_0F78_0008 is related to rectangle in smallmap
20:27:16 <TrueBrain> + enable = emu_get_memory16(emu_ss, emu_sp, 0x2) != 0; <- please add (), or even ? true : false
20:27:19 <TrueBrain> as this reads weird :p
20:33:17 <TrueBrain> + if (packed != 0xFFFF && packed != g_global->variable_3564 && unknown) { <- is wrong
20:33:30 <TrueBrain> - if (emu_si != emu_get_memory16(emu_ds, 0x00, 0x3564)) goto l__00AB;
20:33:32 <TrueBrain> - emu_orw(&emu_di, emu_di);
20:33:33 <TrueBrain> - if (emu_di != 0) goto l__00AB;
20:33:50 <TrueBrain> if (packed != 0xFFFF && (packed != 3564 || unknown))
20:35:03 <TrueBrain> so in the radar, 1 bit is 1 pixel
20:35:36 <Xaroth> then how does it do the colours :o
20:36:05 <TrueBrain> I don't know what it does with the array in the first place
20:36:25 <glx> I don't know the array(s) usage either
20:36:51 <TrueBrain> it can be a bit to indicate redraw
20:36:52 <glx> 93E5 and 95E5 are accessed it a similar way
20:36:53 <TrueBrain> or something like that
20:37:42 <TrueBrain> glx: does the above fix your problem?
20:38:10 <TrueBrain> then I am not going to check your var06 and stuff :p
20:38:25 <glx> I checked them with asserts :)
20:39:19 <TrueBrain> I think 95E5 is indication for the main map to redraw a tile
20:39:34 <TrueBrain> given 01FF .. as that appears to invalidate all tiles inside the selection
20:40:18 <glx> 95E5 for map, and 93E5 for minimap
20:41:06 <TrueBrain> and 01B4 invalidates the old selection
20:41:17 <TrueBrain> so that is like: ChangeSelection, or SetSelection, or what ever :p
20:41:39 <TrueBrain> but .. that does only work if selectionHeight and selectionWidth are equal
20:41:42 <TrueBrain> so that is a bit wierd
20:42:33 <glx> anyway var06, var08, ... are left, right, top, bottom I think
20:42:59 <TrueBrain> and I guess that function makes a rectangle
20:43:09 <TrueBrain> GUI_DrawRectangle is a filled rectangle ;)
20:43:33 <glx> it calls a function in the array :)
20:43:45 <TrueBrain> Map_SetSelectionSize uses emu_ax, which is never set in that scope
20:44:11 <TrueBrain> same for Map_SetSelection
20:44:23 <glx> return value of the previous call
20:44:25 <TrueBrain> but it is a violation of C
20:44:45 <TrueBrain> maybe store in a variable
20:44:52 <TrueBrain> makes later conversion easier ...
20:45:25 <TrueBrain> but so, yes, 01B4 disables current selection, and actives the new given one, keeping the current width/height
20:45:54 <TrueBrain> so a good name would be .. euuh ... EnableSelection(uint16 packed, bool enable)?
20:46:31 <TrueBrain> 01FF is like: InvalidateSelection
20:46:46 <glx> for Map_SetSelection it is stored in a variable immediately, but I agree for Map_SetSelectionSize, it's not clear
20:46:46 <TrueBrain> a good name for 01B4 .. pff ...
20:47:04 <TrueBrain> indeed, SetSelection is fine, SetSelectionSize made me say: HUH?! :p
20:47:21 <TrueBrain> ChangeSelection(uint16 packed)?
20:48:53 <TrueBrain> and yes, 0008 looks like minimap 'ChangePosition' or what ever :p Easy to verify I guess :)
20:53:38 <TrueBrain> lot of 22A6 show clear violation of function frames
20:53:52 <TrueBrain> so they are optimized by something else then the Borland C++ compiler :p
20:58:50 <TrueBrain> f__251B_0000_001E_7202 draws 4 lines :p
21:01:42 <TrueBrain> but it shows it was not inside the library :p
21:02:11 <glx> maybe it was, but some functions in the library are never called
21:02:20 <TrueBrain> I don't think it was
21:02:25 <TrueBrain> most graphical libraries don't have it :p
21:09:44 <DorpsGek> SVN: truebrain (r756) -Add: named more GUI functions
21:09:51 <TrueBrain> this will collide with your patch; sorry about that
21:26:53 <Xaroth> past month bugs. went down a bit in popularity, rest went up by quite a bit tho :)
21:30:51 * Xaroth slaps boekabart with Ozzy Osbourne
21:31:25 <Xaroth> I don't get any google ads :)
21:31:33 <Xaroth> seeing they all get filtered out for me
21:34:33 <TrueBrain> I do mind unfair ways of commercial
21:34:40 <Xaroth> then -just- block google ads :)
21:34:51 <TrueBrain> which is the ad market
21:40:35 <TrueBrain> so Xaroth, when can we expect the new function of your hand?
21:41:00 <Xaroth> I already comitted stuff before the weekend
21:41:06 <Xaroth> been spending most of this weekend with the missus
21:41:45 <TrueBrain> there are tons of named small functions waiting for you :p
21:44:17 <TrueBrain> lot of small Unit_ functions:)
21:44:44 <TrueBrain> wtf? WebSVN doesn't show past r727 :s
21:45:04 <TrueBrain> FUCKING RETARDED WEBSVN!
21:45:38 <TrueBrain> while on the left is: From Rev 756 to Rev 1
21:46:24 <Xaroth> by default it limits to max 30 listing results
21:46:36 <TrueBrain> so .... it limits the result to 30, fine
21:46:43 <TrueBrain> then why display 25, and give a Next Prev?
21:46:45 <TrueBrain> that is just stupid
21:47:09 <TrueBrain> the Next should of course walk everything
21:47:13 <TrueBrain> with 'max revs' per page
21:47:16 <TrueBrain> that would make sense
21:47:26 <Xaroth> i'll see if I can change it
21:47:35 <TrueBrain> try hitting the 'Compare with Previous' button
21:47:43 <TrueBrain> which is there in the middle of the screen waiting for you to press it
21:48:00 <TrueBrain> WebSVN is broken ....
21:48:14 <TrueBrain> so broken by design :p
21:48:20 <Xaroth> yet it's one of the best available :/
21:48:30 <Xaroth> (which sais a lot about the rest, really)
21:48:31 <TrueBrain> if this is one of the best, I feel sorry for this market
21:48:41 <TrueBrain> "You are the best of the worst"
21:49:06 <Xaroth> hg serve isn't for svn :P
21:49:25 <glx> but it's included in all hg clients
21:50:35 <glx> as you need to launch svnserve anyway
21:51:56 <Xaroth> default svn serve thing sucks anyhow :/
21:52:17 <TrueBrain> I have NO clue how 22A6 does what it does
21:52:24 <TrueBrain> the DrawLine is making my head spin
21:52:59 <glx> funny I can start 2 hg serve on the same port, one for ipv6, one for ipv4
21:53:38 <glx> direct video memory accesses?
21:53:50 <TrueBrain> or at least funny ways of accessing :p
21:54:41 <TrueBrain> but I have zero issues disabling functions and see what effect that has :p
21:56:08 <glx> another way to find names
21:56:38 <TrueBrain> f__22A6_101C_004B_D9F3 does something like: CopyMemory
21:58:40 <TrueBrain> only used for the mouse
22:01:55 <TrueBrain> okay, this approach is not leading anywhere too ...
22:01:58 <TrueBrain> I am going to bed :p
22:40:36 <Xaroth> chora (alternative) is built upon horde, which is shit
22:40:51 <Xaroth> svn:web is some kind of dodgy rails app
23:00:33 <Xaroth> TrueBrain/glx: added a 'default' max amount to show, and set that to 100
23:00:36 <Xaroth> can be changed, obviously
23:00:48 <Xaroth> but I think 100 should be enough
23:02:47 <Xaroth> change last line in include/config.php .. it's a define() so should be self-explaining
continue to next day ⏵