IRC logs for #opendune on OFTC at 2009-12-09
⏴ go to previous day
00:18:55 <Xaroth> will fix that tomorrow
01:48:54 *** PeterT has joined #openDune
02:53:23 *** PeterT has joined #openDune
02:56:49 *** PeterT has joined #openDune
03:41:20 <DorpsGek> SVN: glx (r709) -Add: C-ified String_Get_ByIndex() and String_GetFromBuffer_ByIndex()
08:06:11 *** TrueBrain_ has joined #openDune
09:58:56 *** ChanServ sets mode: +v Yexo
10:00:34 <Xaroth> going to go really funky, and install lighttpd as well as pdns
10:06:05 *** TrueBrain_ is now known as TrueBrain
10:21:17 <Xaroth> apt-get install apache2 libapache2-php5 would have done the trick >:(
10:22:52 *** Xaroth sets mode: +o TrueBrain
11:50:37 <Xaroth> TrueBrain: need anything from evo? :P
12:39:22 <TrueBrain> "+ * Adds the specified unit to the specified." <- nice Xaroth :p
12:39:50 <TrueBrain> Xaroth: variable_08 is 'team size' or how ever you want to call the variable
12:40:45 <TrueBrain> the 0x0 glx mentioned
13:34:45 <TrueBrain> some functions are just wrong .. first fetch some data based on a pointer, then heck if that pointer is NULL
13:34:51 <TrueBrain> wrong ... wrong .. wrnog ....
13:38:23 <TrueBrain> amount of spice divided by 32 is what is spread around on the map when it is a harvester
13:42:00 <TrueBrain> if the unit is of an AI, and when campaign 4+, on destruction, it does something ...
13:42:27 <TrueBrain> oh, no, not when destroyed
13:43:22 <TrueBrain> ah, no, when desotryed :p Haha :)
13:43:24 <TrueBrain> hard to read right :p
13:45:33 <TrueBrain> I believe it says 'unit destroyed'
13:47:33 <TrueBrain> some special code which puts a unit which is on ambush to 'attack' when being attacked
13:47:45 <TrueBrain> funny enough, exception code to exlcude harvesters
13:47:50 <TrueBrain> a harvester on 'ambush'?!
13:48:28 <TrueBrain> a sandworm indeed dies when at 50% of hp
13:49:58 <TrueBrain> when squads go to single units, ther eis a chance it retreats
14:04:23 <DorpsGek> SVN: truebrain (r710) -Fix: found more flag .. no clue what it does :p
14:05:49 <DorpsGek> SVN: truebrain (r711) -Add: figured out the name of a function
14:06:13 <TrueBrain> glx: snprintf is not C89 ...
14:08:17 <TrueBrain> nevertheless it works on both tcc and gcc (just gcc warns)
14:10:02 <TrueBrain> #if defined __USE_BSD || defined __USE_ISOC99 || defined __USE_UNIX98
14:10:04 <TrueBrain> __BEGIN_NAMESPACE_C99
14:10:05 <TrueBrain> /* Maximum chars of output to write in MAXLEN. */
14:10:07 <TrueBrain> extern int snprintf
14:12:59 <DorpsGek> SVN: truebrain (r712) -Fix (r709): snprintf is stricly seen not C89, so GCC warns. We break C89 here, as we find snprintf important enough to add as dep. Platforms not supporting snprintf should be implemented as custom function
14:13:31 <TrueBrain> k, got to go; bye all :)
14:15:38 <glx> hmm and now gcc fails for me
15:07:09 <Xaroth> TrueBrain: The login system at the front desk is.. you guessed it.. broken again
15:07:18 <Xaroth> took me 10 minutes to get my passes to go inside :/
16:48:11 <Xaroth> GRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR
16:48:18 <Xaroth> one of our LBs died :/
17:29:27 *** TrueBrain has joined #openDune
17:29:27 *** charon.oftc.net sets mode: +oovv glx TrueBrain SmatZ tneo
17:29:27 *** planetmaker has joined #openDune
17:29:27 *** blathijs has joined #openDune
17:29:27 *** boekabart has joined #openDune
17:29:27 *** Xaroth has joined #openDune
17:29:27 *** charon.oftc.net sets mode: +vvvo planetmaker blathijs boekabart Xaroth
17:29:27 *** TinoDidriksen has joined #openDune
17:29:27 *** proyvind has joined #openDune
17:29:27 *** charon.oftc.net sets mode: +vvv Xaroth TinoDidriksen proyvind
18:05:05 <SmatZ> doesn't it matter src is modified too?
18:05:20 <SmatZ> so when it's called several times with the same source, it will have different results?
18:06:01 * SmatZ reads the decompiled code
18:06:59 <SmatZ> I think the original code doesn't modify source
18:07:20 <SmatZ> - emu_al = emu_get_memory8(emu_es, emu_bx, 0x0);
18:07:22 <SmatZ> - emu_addb(&emu_al, 0x7F);
18:08:10 <SmatZ> - emu_get_memory8(emu_es, emu_bx, 0x0) = emu_al;
18:08:41 <SmatZ> it's after changing es:bx to dst ;)
18:08:56 <glx> yes but source = dest for all calls ;)
18:09:07 <glx> so it's not a big problem, but can be
18:10:09 <SmatZ> maybe you can add assert(dst == src)?
18:14:55 <glx> refreshed, better do exactly the same as original :)
18:28:25 <glx> but I'm still not sure about the naming :)
19:42:27 *** ChanServ sets mode: +v Yexo
19:51:46 *** ChanServ sets mode: +v Yexo
20:17:45 *** boekabart has joined #openDune
20:17:45 *** solenoid.oftc.net sets mode: +ovvv glx SmatZ tneo boekabart
20:17:45 *** proyvind has joined #openDune
20:17:45 *** solenoid.oftc.net sets mode: +v proyvind
20:25:47 *** TrueBrain has joined #openDune
20:25:47 *** planetmaker has joined #openDune
20:25:47 *** blathijs has joined #openDune
20:25:47 *** Xaroth has joined #openDune
20:25:47 *** synthon.oftc.net sets mode: +ovvo TrueBrain planetmaker blathijs Xaroth
20:25:47 *** TinoDidriksen has joined #openDune
20:25:47 *** synthon.oftc.net sets mode: +vv Xaroth TinoDidriksen
20:36:45 <Xaroth> in our network, quite critical systems.. we have them in a redundant setup, but still. if one dies they have to be fixed asap
21:12:13 <TrueBrain> glx: c = 0x7F + *source++; <- suggest to put () around it :p
21:12:17 <TrueBrain> btw, fixed your gcc problem?
21:17:31 <glx> just added a !defined(__MINGW32__) before defined(__GNUC__)
21:20:18 <TrueBrain> that is fine I guess
21:20:20 <TrueBrain> if that compiles ;)
21:20:27 <TrueBrain> did you commit that?
21:21:54 <TrueBrain> please do, in a not too distant future :)
21:23:48 *** PeterT has joined #openDune
21:25:45 <Xaroth> TrueBrain: empty cs__ files == remove right?
21:25:50 <Xaroth> or do they need to exist for some odd reason
21:27:27 <DorpsGek> SVN: glx (r713) -Fix (r712): broken mingw compilation
21:30:51 <Xaroth> right, time to read through this patch before i commit it
21:44:58 <TrueBrain> then it is fine by me
21:46:15 <TrueBrain> I wonder why things are stored like that ..
21:46:51 <TrueBrain> in theory this can cause a buffer overrun
21:47:00 <TrueBrain> when there is a 0x1B at the end of the line
21:47:26 <TrueBrain> but this function will be gone sooner or later, so no biggy :)
21:47:47 <glx> I guess the 0x1B trick is because the compression stuff
21:48:09 <TrueBrain> then it should have been part of the compression :)
21:49:32 <TrueBrain> a do-me-once against a do-me-often
21:49:52 <DorpsGek> SVN: xaroth (r714) -Add: C-ified some Team functions and moved them to the Unit section
21:49:59 <TrueBrain> but okay, given translation is added later, that could have been the issue
21:50:37 <TrueBrain> Xaroth: didn't I ask you to name variable_08?
21:50:51 <glx> hmm if I looked correctly translate is called after decompress, and only after decompress :)
21:51:08 <TrueBrain> Xaroth: then make very sure not to forget to update your comments
21:51:21 <TrueBrain> (it is bad to refer to 'variable_NN' in comments, as you will forget those)
21:51:50 <Xaroth> er, small question tho
21:51:55 <Xaroth> if variable_08 is team_size
21:52:04 <Xaroth> and it returns team_size - members count
21:52:21 <TrueBrain> team_size would be a violation of coding style ;)
21:52:29 <Xaroth> shouldn't that give the same 0 result if both are equal?
21:52:40 <Xaroth> which, appears to be a failure result
21:52:42 <TrueBrain> 'the same 0 result' .. what?
21:53:45 <Xaroth> if unit or team are null, it returns 0, indicating nothing happened
21:53:59 <TrueBrain> indicating the team no longer requires any more units, I say
21:54:15 <TrueBrain> remember that they are protections, the checks for NULL
21:54:19 <TrueBrain> things that should never happen
21:54:22 <TrueBrain> in fact, they can be made asserts
21:54:35 <TrueBrain> for 'Remove' of course not
21:54:59 <TrueBrain> and we already know that currently the return value of Remove is completely unused
21:55:12 <Xaroth> and with remove it can't end up as returning 0 anyhow
21:55:28 <Xaroth> well, unless there are more members than there is size
21:55:28 <glx> I can do the translation in decompress, and make translate do nothing
21:55:32 <TrueBrain> in fact, one can debate to move the return value to the emulator layer only
21:55:47 <TrueBrain> glx: lets do that in a later iteration, I say
21:56:34 <glx> with an explicit emu_String_DoNothing() for translate ;)
21:56:53 <Xaroth> TrueBrain: Team->size or Team->teamSize ?
21:56:59 <glx> but indeed that can wait for a later step
21:57:30 <TrueBrain> teamSize might be redundant .. but 'size' suggests something else
21:57:52 <TrueBrain> euh .. maxMembers? membersMax? groupSize? planetmaker, where are you? :p
21:58:03 <Xaroth> as it's obviously a maximum
21:59:16 <Xaroth> also, Team struct comments have mixed Team and team, any reason?
21:59:25 <Xaroth> aka, should they all be renamed to Team/team ?
21:59:35 <TrueBrain> with capital it explicitly references to the struct
21:59:41 <TrueBrain> but it is not always as consistant as one might want
21:59:51 <TrueBrain> k, return value of AddToTeam is used for in scripts
22:00:27 <glx> ,...,...,...if (*source == '\0') return; <-- I can add that before the 0x7F + (*source++)
22:00:31 <TrueBrain> I think AddToTeam and RemoveFromTeam should not return any value, and that there should be an extra call to get the current amount
22:00:36 <TrueBrain> glx: don't worry about it
22:01:07 <Xaroth> TrueBrain: I'll leave that change up for debate after naming var 08
22:01:48 <glx> especially when return value is never checked ;)
22:02:08 <glx> mainly for RemoveFromTeam
22:02:09 <TrueBrain> it is more that I don't think it is in the function of such functions to return how many can still go in the team
22:02:12 <TrueBrain> it is just a bit abusing
22:02:43 <glx> for AddToTeam I don't know, it's the result of the script function
22:02:57 <TrueBrain> tha tI just said, didn't I? :p
22:03:15 <TrueBrain> still, AddToTeam should only add the unit to the team, not return some value :p
22:03:28 <TrueBrain> Team_GetAmountOfMembersStillNeeded() :p
22:03:32 <glx> like decompress should translate ,)
22:03:46 <TrueBrain> but oaky ... lets write those things down
22:03:49 <TrueBrain> and do it in a later iteration
22:03:57 <TrueBrain> as I am very sure, we will find many more :)
22:04:38 <TrueBrain> @mode +b *!*@c-76-19-211-40.hsd1.ma.comcast.net
22:04:38 *** DorpsGek sets mode: +b *!*@c-76-19-211-40.hsd1.ma.comcast.net
22:04:47 <Xaroth> I was waiting for it :P
22:05:08 <Xaroth> *!*@c-76-19-*-40.hsd1.ma.comcast.net :P
22:05:20 *** TrueBrain sets mode: -b *!~Peter@c-76-19-168-104.hsd1.ma.comcast.net
22:05:21 *** TrueBrain sets mode: -b *!*@c-76-19-211-40.hsd1.ma.comcast.net
22:05:39 <Xaroth> *!*@c-76-19-*.hsd1.ma.comcast.net :P
22:05:49 *** TrueBrain sets mode: +b *!~Peter@*.hsd1.ma.comcast.net
22:05:59 <Xaroth> even more efficient :P
22:10:28 <DorpsGek> SVN: glx (r715) -Add: named and C-ified String_TranslateSpecial()
22:10:59 <Xaroth> TrueBrain: refer to r714 for updating it's comments for the rename of var_08
22:11:10 <Xaroth> or no need for such elaborate stuff
22:11:39 <TrueBrain> once again, you delute me in your speech, and I hav eno clue what you try to say, or if you try to ask something :p
22:11:54 <Xaroth> the commit message for the naming of var_08
22:12:27 <TrueBrain> essential part of the message you try to bring ;)
22:12:41 <TrueBrain> and no need :p We just name variables :p
22:15:03 <DorpsGek> SVN: xaroth (r716) -Add: Named one variable
22:16:57 <TrueBrain> f__1A34_15F4_0026_EDA4 finds the highest value of f__1A34_14E6_001F_FB1E, but I hav eno clue what f__1A34_14E6_001F_FB1E does :p
22:27:19 <TrueBrain> cool, you can make a unit attack itself
22:27:22 <TrueBrain> no idea what that does
22:27:53 <TrueBrain> something is broken in HEAD
22:28:13 <TrueBrain> in certain conditions, attack completely fails
22:28:20 <TrueBrain> starts shooting in random directions :p
22:28:26 <TrueBrain> might be TCC though ..
22:31:42 <DorpsGek> SVN: truebrain (r717) -Add: named one more function
22:31:57 <TrueBrain> Xaroth: next time, do not forget to remove translated functions from function_names.txt
22:32:25 <TrueBrain> and now, I wish you all a very very good night
23:44:10 <Xaroth> #define G15_WIDGET_NAME L"Mumble G15 Display" <<< what's that L for anyhow?
continue to next day ⏵