IRC logs for #openttd on OFTC at 2019-01-22
            
00:00:43 <glx> because I don't think an AI will explicitely need the bridge name
00:02:08 <glx> but as the data is available to human players via inspection tool, I agree it could be available to AI writers
00:03:04 <Samu> https://paste.openttdcoop.org/pj212urmk hmm, didn't become that much better
00:04:32 <LordAro> it's not worse
00:04:42 <LordAro> i'd get rid of the AIVehicle prefix, it's unnecessary
00:04:53 <Samu> ok
00:06:41 *** Wolf01 has quit IRC
00:07:49 *** snail_UES_ has joined #openttd
00:08:01 <Samu> https://paste.openttdcoop.org/pzhxcbdxc
00:08:17 <Samu> added some spacing, good or bad idea?
00:08:49 <LordAro> should be aligned with everything else
00:09:15 <Samu> ok
00:09:36 <Samu> both? or just those to the right?
00:09:48 <glx> the results
00:10:45 <Samu> oh it's not a loop
00:11:11 <Samu> it's...
00:11:13 <Samu> print(" GetName():");
00:11:13 <Samu> print(" VT_RAIL: " + AIBridge.GetName(i, AIVehicle.VT_RAIL));
00:11:13 <Samu> print(" VT_ROAD: " + AIBridge.GetName(i, AIVehicle.VT_ROAD));
00:11:13 <Samu> print(" VT_WATER: " + AIBridge.GetName(i, AIVehicle.VT_WATER));
00:11:13 <Samu> print(" VT_AIR: " + AIBridge.GetName(i, AIVehicle.VT_AIR));
00:11:30 <glx> it's inside the bridge loop
00:19:30 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick dismissed a review for pull request #6988: Change: AI/GS ScriptBridge::GetName takes one extra parameter to refer the vehicle type https://git.io/fh4oD
00:19:31 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6988: Change: AI/GS ScriptBridge::GetName takes one extra parameter to refer the vehicle type https://git.io/fhfaC
00:25:25 *** dvim has quit IRC
00:33:35 *** snail_UES_ has quit IRC
00:34:12 *** snail_UES_ has joined #openttd
00:42:21 *** Flygon has joined #openttd
01:12:16 *** Mahjong1 has joined #openttd
01:19:09 *** Mahjong has quit IRC
01:26:49 *** snail_UES_ has quit IRC
01:30:31 *** snail_UES_ has joined #openttd
01:38:47 *** guru3 has quit IRC
01:39:24 *** Samu has quit IRC
01:39:24 *** DorpsGek_II has quit IRC
01:39:28 *** Samu has joined #openttd
01:41:07 <Samu> LordAro https://paste.openttdcoop.org/prho3dkro
01:41:17 <Samu> more tight
01:42:24 *** guru3 has joined #openttd
01:44:23 <Samu> description could be improved
01:45:47 <Samu> https://paste.openttdcoop.org/pceswwkbb
01:48:08 <Samu> push with force?
01:48:20 <Samu> for me it looks too tight
02:09:31 *** Thedarkb-X40 has joined #openttd
02:13:43 <Samu> i fail at rebases
02:16:37 *** Thedarkb1-T60 has quit IRC
02:16:38 <Samu> nop, DorpsGek_II isn't talking, something's fishy going on
02:38:19 *** snail_UES_ has quit IRC
02:40:34 <Gustavo6046> hehehe
02:57:03 *** snail_UES_ has joined #openttd
02:57:11 <Samu> uhm... terraforming tunnels has gone through too many changes
02:57:33 <Samu> some old patch I got here can't be patched t.t
02:57:38 <Samu> https://github.com/OpenTTD/OpenTTD/blame/41d47926b17984228c084578767312c3db6845f8/src/tunnelbridge_cmd.cpp#L682
02:58:34 <Samu> MakeClearedObjectArea no longer exists
02:58:37 <Samu> :|
02:58:57 <Samu> or maybe it never existed, hmm
03:01:10 <Samu> nevermind, it never existed
03:01:20 <Samu> it was something Alberth teached me
03:02:02 <Samu> I remember now
03:12:34 <Samu> Do I have to copy paste this huge comment around for my patch? https://github.com/OpenTTD/OpenTTD/blob/master/src/tunnelbridge_cmd.cpp#L693
03:12:48 <Samu> I'm gonna use it in 2 places
03:13:00 <Samu> anyone?
03:27:17 *** supermop has quit IRC
04:08:43 *** Wormnest has quit IRC
04:08:49 *** Thedarkb-X40 has quit IRC
04:11:21 *** snail_UES_ has quit IRC
04:31:30 <Gustavo6046> hi Samu
04:32:12 <Gustavo6046> wait
04:32:20 <Gustavo6046> aren't you the brazilian ambulance service thing?
04:35:11 <Samu> ye
04:35:26 <Gustavo6046> like, 190
04:35:28 <Samu> or french
04:35:31 <Gustavo6046> (phone number)
04:35:31 <Gustavo6046> something like that
04:35:52 <Samu> i got a trailling whitespace stuff error on my last pr
04:35:53 *** triolus has joined #openttd
04:36:03 <Samu> never forgiv
04:42:07 *** triolus has quit IRC
04:52:30 *** Samu has quit IRC
04:53:12 *** D-HUND has joined #openttd
04:56:32 *** debdog has quit IRC
05:20:32 *** glx has quit IRC
06:20:02 *** sla_ro|master has joined #openttd
06:33:14 *** Gustavo6046 has quit IRC
07:35:01 *** andythenorth has joined #openttd
07:57:54 *** sla_ro|master has quit IRC
08:18:15 *** andythenorth has quit IRC
08:21:08 *** andythenorth has joined #openttd
08:45:20 <andythenorth> moin
08:48:17 <peter1138> Yes
09:10:41 <andythenorth> merge peter1138? ;) https://github.com/OpenTTD/OpenTTD/pull/7065
09:18:34 <peter1138> Is it a good feature?
09:21:03 <andythenorth> very BAD
09:22:44 <peter1138> Oh, okay. I'll close it then.
09:25:19 <andythenorth> 'closed by merging'
09:56:52 <LordAro> peter1138: i like it
09:57:50 <andythenorth> I like it a lot
10:13:51 <peter1138> Damn, 50g of fruit cake is tiny :/
10:25:10 <andythenorth> morsels
10:28:51 *** tokai has joined #openttd
10:28:51 *** ChanServ sets mode: +v tokai
10:35:27 *** tokai|noir has quit IRC
10:51:22 *** Borg has joined #openttd
13:05:52 *** Speedy` has quit IRC
13:08:19 *** Speedy` has joined #openttd
13:14:29 <peter1138> Where did DorpsGek_II go?
13:14:59 <andythenorth> holidays
13:15:21 <peter1138> TrueBrain, who gave our bot a passport?!
13:16:09 <andythenorth> leaving before brexit
13:16:17 <peter1138> Who wouldn't?
13:29:37 *** MasseR has quit IRC
13:33:59 <LordAro> netsplit, probably
13:39:15 *** MasseR has joined #openttd
13:41:55 <peter1138> 00:39 -!- DorpsGek_II [~DorpsGek_@spam.openttd.org] has quit [Remote host closed the connection]
13:42:03 <peter1138> It broked.
13:42:25 <LordAro> F
13:46:00 <peter1138> Erm, I mean, it went on holiday.
13:46:19 <Eddi|zuHause> Dorxit
13:46:54 <peter1138> Mmm, salad
13:47:13 <andythenorth> the best
13:47:29 <peter1138> I have a ham roll as well, and stuffs, not just salad.
13:47:46 <andythenorth> salad is valid alone
13:47:48 <peter1138> Salad appetiser means my lunch lasts longer than 3 minutes.
13:47:49 * andythenorth often has salad
13:48:46 <peter1138> Me too. I keep being told I should be getting bored of it, or that I'm anorexic.
13:49:42 <peter1138> Feature: Raise a corner of land automatically when building aqueducts #7078
13:49:59 <peter1138> Hmm, without any context, I'm wondering how that is a good feature.
13:51:01 <andythenorth> I think it's supposed to offer consistency with other bridges
13:51:05 <andythenorth> but eh, I'm pure guessing
13:52:48 <peter1138> Hmm
13:52:59 <peter1138> So in my ham ciabatta roll, there is also... more salad.
13:54:31 *** Flygon has quit IRC
14:01:30 <Eddi|zuHause> so... my car decided "-1°C? nah, you're not getting me out there"
14:02:03 *** Samu has joined #openttd
14:02:14 <andythenorth> block heater
14:02:16 <andythenorth> like canada
14:02:46 <andythenorth> why is Horse so damn slow to compile :(
14:03:07 <Samu> hi
14:04:49 <Samu> Azure Pipeliner dude didn't build my stuff :|
14:05:26 *** sla_ro|master has joined #openttd
14:08:33 <Samu> andythenorth, I made some tweaks to https://github.com/OpenTTD/OpenTTD/pull/7073, can u check if it's still building disasterous rivers?
14:08:55 <Samu> but the azure didn't build it
14:12:09 <Samu> the only way to make rivers to always connect to the sea is by disabling lakes completely. I didn't do that
14:12:47 <Samu> but i made some tweaks to how lakes are generated
14:13:59 <andythenorth> Samu: still extensive rivers that don't connect to sea
14:14:17 <andythenorth> have you force pushed?
14:14:59 <peter1138> Hmm, I'm not seeing the excess performance hit of PerformanceAccumulator any more. I wonder if I was using a debug build o_O
14:16:15 <Samu> i think I didn't force push
14:16:20 <Samu> let me do that
14:16:39 <peter1138> Don't think he needs to, he's just adding commits on top. (This is fine.)
14:17:59 <Samu> eh, too late
14:18:06 <Samu> just force pushed
14:18:23 <Samu> btw, DorpsGek hasn't been announcing for a while
14:19:20 <Samu> In progress — This check has started...
14:19:21 <Samu> nice
14:24:47 <andythenorth> Samu: did you test the change? o_O
14:27:29 <Samu> yes-ish
14:27:42 <Samu> there are less ugly lakes
14:28:48 <andythenorth> many rivers are not connecting
14:29:09 <andythenorth> are you testing on a mountainous map?
14:29:38 <Samu> mountainous is too hard to create rivers
14:30:11 <Samu> with the slopes I am required for locks, it's a miracle if any is created
14:35:38 <peter1138> rivers connecting to sea should be preferred over easy lock placing.
14:36:27 <Samu> by sea, do you mean sea or lakes? or really only sea?
14:37:10 <andythenorth> I mean any water body with coast tiles
14:37:26 <andythenorth> lakes are what rivers build if they fail to reach the sea, iirc
14:37:58 <peter1138> ^ this
14:38:16 <Samu> hmm well... hmm
14:38:35 <Samu> that's basically saying... this patch isn't needed
14:39:10 <Samu> can't see a way that accomodates both
14:39:29 <andythenorth> 1 tile locks :P
14:39:31 <andythenorth> 2 tile locks :P
14:39:37 <andythenorth> rivers that terraform :P
14:39:54 <andythenorth> build rivers from coast tiles inland :P
14:40:58 <Samu> rivers that terraform was one of my ideas, but i have no idea how to do this
14:41:17 <Samu> no plan
14:41:35 <Samu> unsure where i'm starting to edit
14:42:00 <andythenorth> ok so it's a learning phase
14:42:17 <andythenorth> it's pretty common to start out by 'which code can I edit'
14:42:31 <andythenorth> but good features come from 'what do I want to achieve' :)
14:53:46 *** sushibear has quit IRC
14:53:55 *** sushibear has joined #openttd
14:55:42 *** sushibear has quit IRC
14:55:48 *** sushibear has joined #openttd
14:59:28 <Samu> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=413&view=logs&jobId=4a3434b8-8791-51e7-989a-90d44cb4c0c6&taskId=0a2eebfc-e253-58ad-0639-c8f2ae2e7bcd&lineStart=576&lineEnd=577&colStart=1&colEnd=1
14:59:39 <Samu> visual studio never warns me about this
15:00:58 <peter1138> It's useful to know it.
15:01:10 <peter1138> If you mix && and ||, always use parenthesis.
15:08:53 *** sushibear has quit IRC
15:10:45 <Samu> is there a way to make visual studio warn me of it?
15:13:08 <peter1138> I don't know but you could try just looking at the code you've written.
15:13:32 <andythenorth> trains very https://dev.openttdcoop.org/attachments/download/9250/high-speed-pax-3.png
15:13:35 <andythenorth> https://dev.openttdcoop.org/attachments/download/9251/high-speed-pax-4.png
15:13:42 <andythenorth> no supermop? :P
15:13:51 <peter1138> Very nice. Is it shipped?
15:14:02 <peter1138> It's 4x zoom? :D
15:15:07 <andythenorth> not shipped
15:15:18 <andythenorth> it's 28x zoom
15:15:19 <andythenorth> better
15:15:46 <andythenorth> what it really needs is arbitrary liveries
15:15:53 <peter1138> Hmmmmm
15:16:06 <andythenorth> 8 company colours? o_O
15:16:50 <Eddi|zuHause> pop up a draw screen on each vehicle purchase so the player can customize the livery
15:17:02 <andythenorth> voxels
15:17:20 <Eddi|zuHause> cubicles
15:18:22 <peter1138> Eddi|zuHause, not customize. Purchase.
15:18:33 <peter1138> DLC :D
15:18:36 <Eddi|zuHause> microtransactions!
15:18:45 <peter1138> Fuck you Elite Dangerous :(
15:19:50 <andythenorth> embed a pixel editor, recompile the grf?
15:19:58 *** supermop_work has joined #openttd
15:20:07 <supermop_work> yo
15:20:10 <andythenorth> too late supermop_work
15:20:15 <andythenorth> you missed my train picturees
15:20:24 <supermop_work> :(
15:20:41 <andythenorth> https://dev.openttdcoop.org/attachments/download/9250/high-speed-pax-3.png
15:20:45 <andythenorth> https://dev.openttdcoop.org/attachments/download/9251/high-speed-pax-4.png
15:21:25 <Samu> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=413&view=logs&jobId=a5e52b91-c83f-5429-4a68-c246fc63a4f7&taskId=bde16fc7-7659-5b1c-12aa-0110866d993c&lineStart=180&lineEnd=181&colStart=1&colEnd=1
15:21:31 <Samu> I didn't touch that code
15:21:39 <Samu> what is that warning?
15:21:52 <Eddi|zuHause> i'm probably biased but i like the blue ones more
15:22:25 <peter1138> Samu, what line number?
15:22:34 <Samu> holy crap, too many cocoa warnings below
15:22:44 <andythenorth> Eddi|zuHause: you can repaint them to your choice, when we add the pixel editor...
15:22:46 <Samu> line 180
15:22:50 <peter1138> If it's not your warning, don't worry about it.
15:23:05 <andythenorth> did we add that ctrl-click counter yet?
15:23:09 <Samu> 2019-01-22T13:20:27.0702790Z /Users/vsts/agent/2.144.0/work/1/s/src/fontcache.cpp:30:18: warning: unused variable 'MAX_FONT_SIZE' [-Wunused-const-variable]
15:23:09 <Samu> 2019-01-22T13:20:27.0703140Z static const int MAX_FONT_SIZE = 72; ///< Maximum font size.
15:23:37 <peter1138> andythenorth, no, we added lock icons.
15:23:46 <andythenorth> ok
15:23:55 <andythenorth> one var, byte-sized
15:23:57 <peter1138> And no, we never will.
15:24:13 * andythenorth forks :|
15:24:26 <andythenorth> NorthPP
15:25:32 <andythenorth> byte holds how many times vehicle was ctrl-clicked
15:25:43 <andythenorth> flipped is mod(2) of the byte
15:25:53 <andythenorth> rolls over to 0 after 16 clicks
15:25:54 <supermop_work> nice trains
15:25:58 <Samu> pushed
15:26:51 <Samu> hmmm nop, didn't start building my stuff
15:27:00 <andythenorth> so...200mph mail cars for the pretendelino?
15:28:04 <Samu> gona try push --force
15:28:36 <andythenorth> https://railcolornews.com/2018/10/29/it-video-mercialia-fast-inside-italys-new-high-speed-freight-train/
15:29:31 <Eddi|zuHause> so, first paid DLC should be earrings?
15:29:54 <Eddi|zuHause> that would make for a good release post?
15:30:16 <peter1138> Eddi|zuHause, hahaha
15:30:49 <Samu> doesn't build
15:31:00 <peter1138> andythenorth, clearly we need separate IDs but related vehicles? :p
15:31:07 <Samu> the azure guy isn't reliable :|
15:31:19 <Samu> nvm, just started
15:32:51 <andythenorth> peter1138: can we cycle through multiple IDs on ctrl-click? :P
15:33:16 <peter1138> Well...
15:33:44 <andythenorth> seems a bit weird :D
15:35:29 <peter1138> No.
15:36:41 <andythenorth> so my original intent was to group related, and force, e.g. intro dates
15:36:51 <andythenorth> and group them in buy menu
15:37:18 <andythenorth> do we also want to allow cycling between group members? o-O
15:37:49 <Eddi|zuHause> no
15:37:57 <Samu> are you talking about fixing vehicle IDs for autorenew/autoreplace?
15:38:10 <Eddi|zuHause> once you purchase a vehicle, you're stuck with it
15:39:32 <andythenorth> autoreplace
15:39:39 <Eddi|zuHause> yes
15:41:38 <Samu> that would help AIs
15:41:56 <Samu> azure doesn't build my stuff
15:42:06 <Samu> tantalizing
15:42:36 <Samu> well, it just built the generate lock, but not the terraform aqueduct one
15:43:09 <Samu> gonna try again git fetch upstream
15:43:18 <Samu> git rebase upstream/master
15:43:21 <Samu> git push --force
15:44:09 <Samu> nop, everything up to date
15:44:12 <Samu> boo
15:45:23 <peter1138> Why is cake so bad? :(
15:45:43 <Samu> why can't I make azure dude like me?
15:45:56 <Eddi|zuHause> *mampf*wab bo bou meam?*mampf*
15:46:54 <Samu> https://github.com/OpenTTD/OpenTTD/pull/7078#partial-pull-merging OpenTTD CI Expected — Waiting for status to be reported
15:46:58 <Samu> but it doesn't start
15:48:35 <Samu> the old guy was better
15:48:37 <Samu> Jenkin
15:48:45 <Samu> Jekils, or something
15:55:20 <Samu> #6926, #6988 and #7078 - my stuff that wasn't build
15:55:29 <Samu> can u help ?
15:57:53 <peter1138> Woe!
15:58:01 <peter1138> Just got handed a blueberry muffin.
16:01:47 <Samu> aqueducts cost a leg and an arm
16:01:50 <Samu> :|
16:04:41 *** nielsm has joined #openttd
16:05:17 *** Gja has joined #openttd
16:08:08 <peter1138> I guess a blueberry muffin is a cake.
16:09:15 <peter1138> So that's cake no. 2 today :/
16:11:07 <peter1138> AND it's snowing.
16:13:19 <andythenorth> chuf
16:15:14 <peter1138> We should have a meet up, drink some beer, eat some cake, and not release anything.
16:16:45 <andythenorth> very english
16:16:58 <andythenorth> isn't that how all English engineering proceeds?
16:20:29 *** Wormnest has joined #openttd
16:20:32 <Samu> review my code if you're not doing anything :p
16:21:42 <Samu> got some code repetition but unsure how to proceed in this case
16:22:01 * andythenorth bbl
16:22:04 *** andythenorth has left #openttd
16:22:35 <Samu> because... it got a huge comment about a bug fix
16:23:04 <Samu> now the huge comment is repeated in 3 places
16:23:35 <Samu> 2 for my patch (my code), 1 for it's original place (not my code)
16:24:08 <Samu> https://github.com/OpenTTD/OpenTTD/pull/7078/files
16:27:10 <Samu> the original https://github.com/OpenTTD/OpenTTD/blob/master/src/tunnelbridge_cmd.cpp#L693
16:33:54 *** snail_UES_ has joined #openttd
16:46:02 <peter1138> Have you heard about functions?
16:49:46 <nnyby> >_<
16:59:05 *** andythenorth has joined #openttd
16:59:14 <andythenorth> but how fast should they go?
17:00:14 *** Gja has quit IRC
17:00:59 <LordAro> andythenorth: some
17:02:09 <andythenorth> 200?
17:02:11 <andythenorth> or 186?
17:02:51 <LordAro> 193
17:05:49 *** stefino has joined #openttd
17:06:39 <stefino> hi, is possible "hide" light signals before selected year?
17:07:01 <stefino> ...in railtypes
17:10:30 <peter1138> I don't think so.
17:11:49 <stefino> I thougt that player can't buy signals before year XY and can buy only semaphore
17:20:44 <andythenorth> Samu: just allow canals to have foundations
17:20:55 <andythenorth> then build the aqueduct like normal bridges
17:21:11 <andythenorth> foundations for canals are super realism https://beaconparkboats.com/media/W1siZiIsIjIwMTYvMTIvMjIvMjBfMDdfMzVfMzA1ODUzLzUwMF9QYWdlXzI2LmpwZyJdLFsicCIsInRodW1iIiwiOTQweDI5NCMiXV0/Page-26.jpg
17:22:09 <andythenorth> https://beaconparkboats.com/assets/carousel/carousel_9.jpg
17:23:07 *** andythenorth has quit IRC
17:24:32 <peter1138> Well, this is going to be an interesting ride home.
17:25:04 <peter1138> Yeah, canal foundations.
17:26:35 *** HerzogDeXtEr has joined #openttd
17:27:00 <peter1138> Hmm, maybe I can make the matrix/scrollbar/resizebox disappear depending on which pane I'm showing.
17:27:16 <Samu> foundations too hard for me
17:29:21 *** DorpsGek_II has joined #openttd
17:29:21 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on issue #30: Validation issues https://git.io/fh20k
17:33:17 *** Gustavo6046 has joined #openttd
17:34:31 *** Progman has joined #openttd
17:56:42 *** snail_UES_ has quit IRC
17:56:46 <Samu> aqueducts don't have foundations
17:57:26 <Samu> foundations too hard for me + aqueducts don't have foundations = nothing to do
17:57:30 <Samu> :)
18:31:20 <peter1138> Well, I made it.
18:34:49 <Samu> aqueducts don't have foundations
18:42:24 <nielsm> aqueducts also appear to have no thickness :)
18:45:07 <Samu> back
18:45:23 <Samu> wow, I swear I didn't type that last line, must have been my cat
18:45:35 <Samu> he walk all over keyboard
18:45:45 *** gelignite has joined #openttd
18:45:59 <Samu> pressed up arrow key and enter? plausible
19:00:28 <Samu> needs triage - something I must do?
19:06:15 *** Wormnest has quit IRC
19:08:26 *** Wolf01 has joined #openttd
19:08:51 <Wolf01> o/
19:09:07 <Samu> : the assigning of priority order to projects on the basis of where funds and other resources can be best used, are most needed, or are most likely to achieve success
19:10:44 <Samu> doesn't look like something I must do
19:12:25 <nielsm> Samu: the "needs triage" tag for pull requests means "we're not sure this is actually a good idea at all"
19:16:29 *** Laedek_ has joined #openttd
19:18:04 *** sushibear has joined #openttd
19:19:39 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7077: Change: Always build baseset metadata, instead of including it in the repo. https://git.io/fh2ow
19:21:19 *** Laedek has quit IRC
19:23:00 *** synchris has joined #openttd
19:27:01 <peter1138> nielsm, I noticed even the makefile version doesn't depend on them.
19:29:35 <nielsm> basically just "touch languages.updated" whenever a language file is rebuilt, and depend the rest on that, should be simple :D
19:31:30 *** andythenorth has joined #openttd
19:33:36 <Samu> anybody knows why #6926, #6988 and #7078 - my stuff that wasn't build?
19:33:52 <peter1138> *built
19:34:17 <andythenorth> because azure
19:37:35 <Samu> is there a force build command?
19:39:29 <andythenorth> on azure?
19:39:53 <Samu> on github or something
19:40:11 <Samu> git push --forcebuild?
19:40:11 <andythenorth> no
19:40:12 <LordAro> not that you can use
19:40:19 <Samu> ok
19:40:24 <andythenorth> you just have to wait
19:40:25 <LordAro> nor anyone except TB, i think
19:40:51 <LordAro> probably orudge as well
19:41:09 <andythenorth> peter1138: how do these groups work then?
19:41:24 <peter1138> zilch has been coded
19:41:47 <andythenorth> so I thought about inheritance, but kinda deleted the idea
19:42:17 <andythenorth> being a newgrf developer kind of sucks unless you know how to write your own compile
19:42:42 <andythenorth> they'll have to repeat all the vehicle properties, just to get a different livery
19:42:53 <andythenorth> and they'll probably be doing all that hand-coded
19:43:10 <andythenorth> and they probably won't know they can reuse the action 2 / varaction 2 chains
19:43:46 <andythenorth> wondered about a parent vehicle, and the properties cascade to child vehicles, unless over-ridden
19:43:56 <andythenorth> "probably just a pointer, right?" :P
19:43:59 <andythenorth> but no
19:44:10 <peter1138> Well, yeah, it's possible we can do that.
19:44:16 <andythenorth> well yeah but no
19:44:39 <andythenorth> I couldn't think of a way to make it work, except loads of string
19:45:15 <andythenorth> do it in the nml side :P
20:00:56 <peter1138> It's possible to put it in the NewGRF spec to inherit properties.
20:04:24 <andythenorth> we'd just inherit them when purchasing the vehicle, then they're static after that?
20:04:46 <peter1138> Wot?
20:04:59 <Eddi|zuHause> no, we inherit them on newgrf loading
20:05:06 <peter1138> Yeah
20:05:09 <andythenorth> ok
20:05:30 <andythenorth> I am trying to imagine the worst thing a newgrf author could do, and then what would break
20:05:42 <andythenorth> or does that not really matter?
20:05:50 <peter1138> Why would anything break?
20:06:05 <andythenorth> I don't know, it's imaginary :P
20:06:20 <andythenorth> action 6 / 7?
20:06:22 <andythenorth> probably not
20:06:31 <peter1138> Nothing to do with it.
20:06:51 <peter1138> It's just an Engine (as OpenTTD calls them)
20:07:13 <peter1138> May or may not have its properties preset from another engine's.
20:07:19 <andythenorth> ok
20:07:27 <peter1138> May or may not appear in the purchase list differently.
20:07:46 <peter1138> But when actually in game it's just a separate engine.
20:08:47 <peter1138> NewGRF authors could make them totally different, we don't care, it doesn't matter.
20:10:08 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison opened pull request #7081: Change: [Linkgraph] Pause the game when linkgraph jobs lag (#6470) https://git.io/fh2Pg
20:10:24 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison opened pull request #7083: Codechange: [Linkgraph GUI] Replace line visibility detection algorithm https://git.io/fh2PV
20:10:47 <andythenorth> so if people just want to do livery crap
20:10:52 <andythenorth> inheritance would simplify that a lot
20:11:07 <andythenorth> just provide different sprites, don't provide much action 0
20:12:17 <peter1138> Where did 7082 go?
20:12:33 *** frosch123 has joined #openttd
20:12:41 <peter1138> Evening.
20:14:13 <TrueBrain> https://github.com/OpenTTD/binaries-proxy/pull/1 <- anyone mind giving this a looksy? (while I setup the rest of the stuff for it)
20:14:23 <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/7082
20:14:36 <peter1138> andythenorth, yeah I know it's there, but DorpsGek_II missed it.
20:15:18 <andythenorth> it's on holiday still
20:15:20 <andythenorth> slacking
20:16:42 <peter1138> TrueBrain, sorry I don't know enough about the docker and yml stuff to comment.
20:17:05 <peter1138> The nginx config looks 'sane' I guess thouhg :p
20:23:02 <TrueBrain> tnx :)
20:23:13 <TrueBrain> ugh, it is a bit busy on the farm .. lol
20:24:14 <peter1138> Compiling 200 PRs from Samu? :p
20:24:15 <LordAro> moo
20:25:34 <andythenorth> https://www.youtube.com/watch?v=iExvDFkBHIQ
20:26:29 <TrueBrain> lets see how flexible the new k8s stuff is ...
20:26:59 *** stefino has quit IRC
20:27:36 <TrueBrain> `An agent is ready for the job`
20:27:40 <TrueBrain> so you have been saying for a while now
20:31:04 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain merged pull request #1: Add: initial version of a simple proxy https://git.io/fh2Pp
20:31:47 *** Thedarkb1-T60 has joined #openttd
20:33:54 <TrueBrain> https://proxy.binaries.staging.openttd.org/openttd-nighlies/latest.txt <- AUTOMAGIC
20:34:44 <nielsm> <Code>AccessDenied</Code>
20:34:48 <nielsm> magic
20:34:55 <TrueBrain> https://proxy.binaries.staging.openttd.org/openttd-nightlies/latest.txt
20:35:00 <TrueBrain> but yeah, it autolaunched
20:35:05 <TrueBrain> which was the main thing to get done :D
20:35:10 <LordAro> shiny
20:35:26 <TrueBrain> over IPv4 it redirects you to a close edge-cache
20:35:27 <peter1138> Ah yeah "404 not found" -> AccessDenied :(
20:35:32 <TrueBrain> over IPv6 it serves it directly
20:35:40 <TrueBrain> so IPv6 most likely has slower throughput
20:35:48 <peter1138> Better than no throughput
20:35:53 <TrueBrain> exactly!
20:36:19 <TrueBrain> I am very happy with the automation .. that is a lot easier to maintain
20:36:28 *** WWacko1976-work has quit IRC
20:36:38 <TrueBrain> right .. this means we are really nearly done to launch the new website :D
20:36:52 <TrueBrain> I "just" need to add the code to go from staging to production, I guess :P
20:36:54 <andythenorth> :o
20:36:58 <andythenorth> press the big red button?
20:37:08 <TrueBrain> 2 minor things left to fix :)
20:37:26 <andythenorth> supermop_work: yo
20:39:16 <supermop_work> yo
20:39:35 <TrueBrain> lol; the binaries proxy consumes 2 MiB of RAM :)
20:39:37 <TrueBrain> I love nginx :)
20:39:51 <peter1138> Wait til it gets some load.
20:40:39 <TrueBrain> the IPv6 bypass I had to create consumes 100 MiB of RAM :P
20:41:35 <andythenorth> supermop_work: tell me about city economies :P
20:41:41 <TrueBrain> annotated tags or not .. hmm.. guess it is better to do with
20:41:48 <TrueBrain> can you make a PR based on an annotated tag ..
20:41:58 <andythenorth> I tried city economy for FIRS 4, but I deleted it :P
20:42:59 <Wolf01> Wtf? FIRS 4? I thought you were working on the 2
20:43:21 <andythenorth> FIRS 2 is old :P
20:45:09 <Samu> I'd like to create a Pull Request of this https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:max_no_competitors-=-15-v33-r27931.patch
20:45:18 <Samu> but... it's too big
20:45:37 <Samu> it was one of my initial code
20:46:59 <Samu> it has many stuff patched together, which should have been separate
20:47:16 <Samu> how am I gonna decouple
20:49:13 <peter1138> Bah, I really need to make sure I commit with the right email :/
20:50:12 <peter1138> I even thought I had :/
20:52:00 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison updated pull request #7082: Blitter line drawing improvements https://git.io/fh2Ds
20:52:21 *** WWacko1976-work has joined #openttd
20:52:24 <Samu> must organize myself first, to know what to decouple first
20:52:30 *** WWacko1976-work has quit IRC
20:56:39 <peter1138> You could check it out, then reset to the previous revision. Then you can do partial commits, on separate branches.
20:57:10 <peter1138> git gui allows you to pick individual chunks or lines rather than whole files.
20:59:50 <nielsm> you can do that too with cmdline, it's just really annoying :P
21:00:48 *** glx has joined #openttd
21:00:48 *** ChanServ sets mode: +v glx
21:00:57 *** HerzogDeXtEr has quit IRC
21:01:04 * andythenorth learns about HP vs torque
21:01:56 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain opened pull request #2: -Release: 1.0.0 https://git.io/fh2Dh
21:04:36 <TrueBrain> hmm ... empty release commits, or just tags
21:04:41 <TrueBrain> do we have any preference?
21:06:06 <TrueBrain> guess OpenTTD itself needs a commit to get things in the correct order etc
21:07:10 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain closed pull request #2: -Release: 1.0.0 https://git.io/fh2Dh
21:07:35 <Eddi|zuHause> don't releases need some trivial changes anyway?
21:07:59 <TrueBrain> what I just said :D So yeah ..
21:08:01 <peter1138> What's an "empty release commit"?
21:08:14 <TrueBrain> git commit --allow-empty -m "-Release: 1.0.0"
21:08:23 <TrueBrain> for some git repositories we will need that
21:08:28 <TrueBrain> as they have no internal version number
21:08:38 <peter1138> Shouldn't we use tags?
21:08:45 <glx> but release commit was not empty, usually some fixed stuff in rev.cpp
21:08:46 <TrueBrain> tags cannot contain changes
21:08:58 <peter1138> So?
21:09:06 <glx> to indicate it's a release
21:09:07 <peter1138> Commit changes, then tag it.
21:09:34 <TrueBrain> glx: in case of binaries-proxy, it will be an empty commit
21:09:47 <TrueBrain> but I guess it is more verbose (and consistent) if we just make a commit for a release in all repositories
21:11:42 <peter1138> JGR having fun with C++11 in the OS X stuff.
21:13:56 <glx> our OSX stuff works ;)
21:14:04 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain opened pull request #3: Add: [AzurePipelines] also build when creating a tag https://git.io/fh2yS
21:15:16 <TrueBrain> Azure is a bit slow today
21:16:09 <DorpsGek_II> [OpenTTD/binaries-proxy] glx22 approved pull request #3: Add: [AzurePipelines] also build when creating a tag https://git.io/fh2yF
21:16:11 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain merged pull request #3: Add: [AzurePipelines] also build when creating a tag https://git.io/fh2yS
21:16:14 <TrueBrain> tnx glx :)
21:16:22 <glx> wow fast
21:16:51 <glx> page refresh wasn't even complete
21:17:05 <TrueBrain> that might be because I already hit 'merge' with admin powers :D
21:17:13 <TrueBrain> I was not expecting a review :( Sorry :D
21:17:21 <TrueBrain> but I really do appreciate it :)
21:17:28 <glx> it was quick to review
21:17:54 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain opened pull request #4: -Release: 1.0.0 https://git.io/fh2yj
21:17:57 <TrueBrain> another one that is REALLY quick :P
21:18:39 <supermop_work> andy, building materials, some goods, no ensp or fmsp
21:18:41 <TrueBrain> this will be fun to see if this "just works"
21:18:54 <supermop_work> food, maybe different types
21:19:20 <DorpsGek_II> [OpenTTD/binaries-proxy] glx22 approved pull request #4: -Release: 1.0.0 https://git.io/fh2ST
21:19:31 <glx> was hard to read ;)
21:19:52 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain merged pull request #4: -Release: 1.0.0 https://git.io/fh2yj
21:20:07 <TrueBrain> shit
21:20:07 <TrueBrain> lol
21:20:11 <TrueBrain> okay, that was a big fail :D
21:20:28 <TrueBrain> stupid GitHub :D
21:20:42 <TrueBrain> GitHub doesn't like empty commits AT ALL :D
21:21:05 <glx> rebase ;)
21:21:16 <glx> (silly idea I know)
21:21:34 <TrueBrain> that is the issue: I rebased :P
21:21:40 <TrueBrain> rebase and squash both won't work, I guess
21:22:48 <glx> I meant rebase manually in master, the worst thing to ever think about
21:23:13 <TrueBrain> you mean, outside a pull request?
21:23:46 <glx> yes something that should never happen
21:24:10 <TrueBrain> let me try one more time to do this the proper way :P
21:24:20 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain opened pull request #5: Release: 1.0.0 https://git.io/fh2S4
21:24:35 <DorpsGek_II> [OpenTTD/binaries-proxy] TrueBrain merged pull request #5: Release: 1.0.0 https://git.io/fh2S4
21:24:42 <TrueBrain> squashing does work :D
21:25:13 *** Progman has quit IRC
21:25:15 <glx> oh no I was too late to approve
21:25:25 <TrueBrain> sorry :P Even the CI was! :D
21:25:28 <glx> Can only approve open pull requests
21:25:40 <glx> nice error message :)
21:26:53 <glx> not surprising squashing works as it's just a new commit on top of master
21:27:08 <TrueBrain> I could imagine that it didnt allow empty commits either
21:27:10 <TrueBrain> but it does :D
21:27:28 <TrueBrain> okay .. first production deployment ...
21:27:33 <TrueBrain> lets see if that works as expected :D
21:27:35 <TrueBrain> it does :D
21:27:36 <TrueBrain> sweet!
21:29:18 <andythenorth> release balloons
21:30:57 <TrueBrain> some DNS issues .. lol .. oops :D
21:31:04 <TrueBrain> forgot to delegate :D
21:33:57 *** synchris has quit IRC
21:35:47 <TrueBrain> I hate it when DNS cache negative results too long :(
21:39:04 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #31: Fix: use proxy.binaries instead of direct CDN URL https://git.io/fh292
21:41:08 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7081: Change: [Linkgraph] Pause the game when linkgraph jobs lag (#6470) https://git.io/fh29D
21:41:50 <TrueBrain> right .. that should now work .. I think :D
21:42:48 *** Borg has quit IRC
21:44:57 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #32: Add: [AzurePipelines] also build when creating a tag https://git.io/fh2Hm
21:46:47 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7081: Change: [Linkgraph] Pause the game when linkgraph jobs lag (#6470) https://git.io/fh2HE
21:47:17 <TrueBrain> okay .. after those 2, I just have one minor thing left, which is to auto-trigger a new website build when a nightly is done, so it shows up on the website
21:47:22 <TrueBrain> which sounds like a useful thing
21:47:34 <TrueBrain> otherwise ... this might be able to go live this weekend, as far as my checklist goes :P
21:50:10 <TrueBrain> after that, I can start moving more of the old infrastructure into the new :) but .. baby steps :)
21:50:54 <DorpsGek_II> [OpenTTD/website] TrueBrain closed issue #21: Staging doesn't support IPv6 https://git.io/fhESR
21:50:55 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #31: Fix: use proxy.binaries instead of direct CDN URL https://git.io/fh292
21:51:16 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #32: Add: [AzurePipelines] also build when creating a tag https://git.io/fh2Hm
21:53:13 <TrueBrain> andythenorth: 100 commits in website repository :D
21:53:20 <andythenorth> more than 9000
21:58:48 <TrueBrain> @all: please check out https://www.staging.openttd.org/, see if you can find anything wrong
21:58:56 <TrueBrain> you have .. 4 days to report those before it goes live, I guess :P
21:59:18 <andythenorth> no 404s
21:59:19 <TrueBrain> glx: can you check if IPv6 works as expected? (including downloading of a nightly and stable (both!))
21:59:38 <glx> 404
21:59:39 <andythenorth> https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.staging.openttd.org%2F
21:59:41 <andythenorth> oof
21:59:55 <glx> but it's openttd 404
22:00:14 <TrueBrain> 404?
22:00:15 <peter1138> I downloaded a nightly.
22:00:17 <glx> with IPv6
22:00:27 <peter1138> Dunno if it used IPv6 or not.
22:00:31 <TrueBrain> the URL above?
22:00:47 <glx> blame kvirc, it pasted the comma
22:00:53 <TrueBrain> :D
22:01:15 <TrueBrain> andythenorth: only 2 mistakes; sounds not too bad, honestly
22:01:32 <glx> platform detection is correct
22:02:07 <andythenorth> TrueBrain: neither are showstoppers, pre-existing issues
22:02:19 <TrueBrain> andythenorth: possibly add them to an issue
22:02:25 <TrueBrain> so if someone wants to fix it, they can
22:02:27 <andythenorth> yes
22:02:32 <glx> and download passed
22:05:08 <TrueBrain> tnx glx :)
22:05:32 <DorpsGek_II> [OpenTTD/website] nikolas opened pull request #33: Add a handful of spelling fixes found with codespell https://git.io/fh27z
22:06:05 *** sla_ro|master has quit IRC
22:06:58 <nielsm> hm changelog link for nightly gives me a file download instead of showing the txt in browser
22:07:48 <nielsm> maybe that depends on which mirror you're sent to?
22:07:56 <TrueBrain> nielsm: yeah .. the new CDN does that
22:08:03 <TrueBrain> not sure what to do about it just yet
22:08:28 <TrueBrain> everything is set correctly, but still .. it mostly downloads the file
22:08:32 <DorpsGek_II> [OpenTTD/website] LordAro approved pull request #33: Add a handful of spelling fixes found with codespell https://git.io/fh27P
22:08:38 <TrueBrain> LordAro: please don't merge
22:08:45 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #33: Add a handful of spelling fixes found with codespell https://git.io/fh27M
22:09:25 <TrueBrain> I wanted the commit message a bit different; but squashing can do that :D
22:09:31 <LordAro> wasn't planning on it
22:09:39 <LordAro> have consumed far too muxh alcohol
22:09:46 <DorpsGek_II> [OpenTTD/website] nikolas commented on pull request #33: Add a handful of spelling fixes found with codespell https://git.io/fh27H
22:10:01 <TrueBrain> lol :)
22:10:08 <TrueBrain> celebrating on a tuesday? living the life!
22:10:34 <LordAro> it's been a somewhat frustrating day :p
22:10:36 <nnyby> lol
22:10:45 <LordAro> but tuesday pub is fairly regular for me :)
22:11:47 <TrueBrain> nielsm: found it ... I did plain/text, instead of text/plain
22:11:48 <TrueBrain> oops :D
22:12:01 <nielsm> lol
22:12:20 <nielsm> plain content of the text kind
22:13:55 <TrueBrain> there we go
22:13:57 <TrueBrain> that is a lot better :)
22:15:18 <TrueBrain> keep finding those tiny issues plz :)
22:20:34 <nielsm> nah. good night :)
22:21:37 <TrueBrain> yeah, same :)
22:21:42 <TrueBrain> tnx for the help with testing all :)
22:22:43 *** gelignite has quit IRC
22:25:44 <supermop_work> andythenorth: could also have secondary manufacturing
22:26:16 <andythenorth> ideas for cargos?
22:26:40 <supermop_work> assembling processed materials and components into finished or near finished good for domestic use and export
22:26:56 <supermop_work> no oil, but fine chemicals
22:27:26 <supermop_work> (tha one is iffy because many cities without heavy industry do still have some refining nearby)
22:28:37 <supermop_work> chemicals, plastic, fuels, stock metals, fish, produce, sub assemblies as inputs
22:28:39 *** nielsm has quit IRC
22:29:33 <supermop_work> food, beer, goods, finished machines, bdmt, other sub assemblies as outputs
22:29:55 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7084: Change: AI/GS Config GUI overhaul https://git.io/fh2dV
22:30:03 <Samu> forgive me
22:30:15 <Samu> I know I shouldn't PR
22:30:16 <supermop_work> heavy equipment to go into buildings or utilities
22:30:24 <Samu> but... I need to start
22:30:33 <andythenorth> I have a mostly-complete design for a heavy chemicals economy
22:30:40 <andythenorth> but that's not the urban one :)
22:30:45 <supermop_work> i am not sure if coal to power plant is needed
22:30:48 <andythenorth> dunno
22:30:59 <supermop_work> because its pretty boring
22:31:10 <andythenorth> I tried one with cheese, coffee, flour, white goods, toys etc
22:31:12 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison updated pull request #7082: Blitter line drawing improvements https://git.io/fh2Ds
22:31:17 <andythenorth> but delivering to towns is just super boring
22:31:21 <supermop_work> by turbines and transformers to power plants and substations might be better
22:31:29 <andythenorth> cargo -> towns is very flawed in OpenTTD currently
22:32:00 <supermop_work> andythenorth: well as i said last night, its just set dressing / back ground for passenger games
22:32:35 <Samu> I'm also interested in knowing if it currently builds or not
22:32:56 <supermop_work> and so i dont have my metropolis sprawling around weird industries that look like they should be in the middle of no where
22:33:09 <milek7> Samu: only 15 AIs? :)
22:33:24 <Samu> hahaha
22:33:38 <Samu> i still have your patch here
22:33:49 <Samu> 200 something companies, i forgot
22:34:38 <Samu> commit checker already failed
22:34:44 <andythenorth> supermop_work: clean industries, in towns? o_O
22:34:57 <supermop_work> tbh contains -> container terminal chain would be fine
22:34:57 <andythenorth> tend not to have heavy rail connections :P
22:35:17 <andythenorth> well intermodal does, but not, e.g. light manufacturing
22:35:34 <supermop_work> dirty is fine, just not like a pig farm surrounded on all sides by high rises
22:37:04 *** frosch123 has quit IRC
22:38:32 <Samu> Linux linux-amd64-clang-3.8 usually likes to expose some warnings that I don't see on visual studio
22:38:53 <peter1138> clang is good for warnings.
22:38:56 <peter1138> You could try using it :p
22:39:18 <LordAro> peter1138: we'd have to teach Samu how linux works
22:39:24 <peter1138> Oh gods
22:39:42 <LordAro> though i think clang can work with windows these days? maybe?
22:40:56 <LordAro> https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain i knew i saw something about it
22:41:56 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison updated pull request #7083: Codechange: [Linkgraph GUI] Replace line visibility detection algorithm https://git.io/fh2PV
22:43:40 <Samu> warning: comparison of integers of different signs: 'int' and 'unsigned long'
22:43:45 <Samu> what's a long?
22:44:03 <Samu> it's an integer
22:44:09 <Samu> but never heard it before
22:44:20 <Samu> or maybe i have, but... why the warning
22:44:33 <milek7> int is signed by default
22:44:49 <Samu> ah, uint will suffice?
22:45:05 <milek7> probably
22:47:37 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison updated pull request #7083: Codechange: [Linkgraph GUI] Replace line visibility detection algorithm https://git.io/fh2PV
22:49:18 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison updated pull request #7083: Codechange: [Linkgraph GUI] Replace line visibility detection algorithm https://git.io/fh2PV
22:52:38 <Samu> oh, it's a int32
22:52:46 <Samu> erm, no uint32
23:07:51 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas opened pull request #7085: Fix: Remove duplicate French and Slovak town names https://git.io/fh2Af
23:08:52 <Samu> for (slot; slot < MAX_COMPANIES; slot++) {
23:09:00 <Samu> statement has no effect
23:09:06 <Samu> well
23:09:13 <Samu> that's what I want
23:09:25 <Samu> take whatever the value slot currently is
23:09:41 <Samu> how do I solve this?
23:10:31 <milek7> just nothing
23:10:38 <milek7> for (; slot < MAX_COMPANIES; slot++) {
23:11:35 <Samu> i see
23:11:36 <Samu> thx
23:17:03 <acklen> does this compile? for (slot; slot < MAX_COMPANIES; slot++) {
23:17:25 <Samu> yes
23:17:52 <Samu> but with warning in linux gccc dude
23:24:40 <Samu> MacOS Job is too scary to look at
23:25:44 <andythenorth> mac compile of master throws boatloads of warnings
23:25:47 <andythenorth> it's not new
23:26:33 <DorpsGek_II> [OpenTTD/OpenTTD] Simons-Mith commented on issue #7037: Smarter random town names https://git.io/fh2xi
23:27:52 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7084: Change: AI/GS Config GUI overhaul https://git.io/fh2dV
23:30:52 <Samu> commit checker failed again?
23:31:37 <Samu> but how? I just removed those whitespaces
23:33:36 <michi_cc> Samu: Each commit has to validate on it's own. You must amend the offending commit and not make a second one.
23:33:51 *** Progman has joined #openttd
23:33:58 <DorpsGek_II> [OpenTTD/OpenTTD] orudge commented on issue #6173: Add support for SDL2 https://git.io/fh2pG
23:35:07 <Samu> ah, i see, must rebase -i and make edits to the first one
23:35:12 <Samu> hmm...
23:35:40 <Samu> or fixup?
23:36:25 <Samu> rebase -i, fixup will do?
23:37:04 <Samu> gonna try fixup
23:40:01 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7084: Change: AI/GS Config GUI overhaul https://git.io/fh2dV
23:42:14 <Samu> Linux commit-checker
23:42:14 <Samu> Succeeded
23:42:16 <Samu> thank u
23:45:54 *** Thedarkb1-T60 has quit IRC
23:48:35 *** andythenorth has left #openttd
23:51:23 <Samu> how do I remove an unused string?
23:51:41 <Samu> only need to remove it from english.txt?
23:52:59 <Samu> must - Get rid of unused string STR_AI_CONFIG_HUMAN_PLAYER.
23:54:45 <LordAro> Samu: separate commit, remove from all language files
23:55:40 <Samu> oh, so it doesn't remove automatically for me?
23:55:45 <Samu> t.t
23:56:01 <Samu> tedious task
23:56:13 <LordAro> mhmm